HasValuePicker::pick() - Code Metrics - Inspection of "wip" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 631589...ae2f10 )

by Song

created 2020-06-03 12:35 UTC

HasValuePicker::pick() A

↳ Parent: HasValuePicker

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	2
dl	0
loc	6
rs	10
c	0
b	0
f	0

<?php

namespace Encore\Admin\Form\Field;

use Encore\Admin\Admin;
use Illuminate\Support\Arr;

trait HasValuePicker
{
    /**
     * @var ValuePicker
     */
    protected $picker;

    /**
     * @var string
     */
    protected $btn = '';

    /**
     * @param string $picker
     * @param string $column
     * @return $this
     */
    public function pick($picker, $column = '')
    {
        $this->picker = new ValuePicker($picker, $column);

        return $this;
    }

    /**
     * @param string $picker
     * @param string $column
     * @param string $delimiter
     */
    public function pickMultiple($picker, $column = '', $delimiter = ',')
    {
        $this->picker = new ValuePicker($picker, $column, true, $delimiter);

        return $this;
    }

    /**
     * @return void
     */
    protected function mountPicker()
    {
        if ($this->picker) {
            $this->picker->mount($this);
            $this->addVariables(['btn' => $this->btn]);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
        }
    }

    /**
     * @return string
     */
    protected function getRules()
    {
        $rules = parent::getRules();

        array_delete($rules, 'image');

        return $rules;
    }

    /**
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View|string
     */
    protected function renderFilePicker()
    {
        $this->view = 'admin::form.filepicker';
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $this->picker->mount($this);

        $this->attribute('type', 'text')
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->attribute('id', $this->id)
class MyClass { }

$x = new MyClass();
$x->foo = true;
            ->attribute('name', $this->elementName ?: $this->formatName($this->column))
class MyClass { }

$x = new MyClass();
$x->foo = true;
            ->attribute('value', old($this->elementName ?: $this->column, $this->value()))
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->attribute('class', 'form-control '.$this->getElementClassString())
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            ->attribute('placeholder', $this->getPlaceholder());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->addVariables([
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            'preview' => $this->picker->preview(),
            'btn'     => $this->btn
        ]);

        return parent::render();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * @param string $wrap
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function addPickBtn($btn)
    {
        $this->btn = $btn;
    }
}


1			<?php
2
3			namespace Encore\Admin\Form\Field;
4
5			use Encore\Admin\Admin;
6			use Illuminate\Support\Arr;
7
8			trait HasValuePicker
9			{
10			/**
11			* @var ValuePicker
12			*/
13			protected $picker;
14
15			/**
16			* @var string
17			*/
18			protected $btn = '';
19
20			/**
21			* @param string $picker
22			* @param string $column
23			* @return $this
24			*/
25			public function pick($picker, $column = '')
26			{
27			$this->picker = new ValuePicker($picker, $column);
28
29			return $this;
30			}
31
32			/**
33			* @param string $picker
34			* @param string $column
35			* @param string $delimiter
36			*/
37			public function pickMultiple($picker, $column = '', $delimiter = ',')
38			{
39			$this->picker = new ValuePicker($picker, $column, true, $delimiter);
40
41			return $this;
42			}
43
44			/**
45			* @return void
46			*/
47			protected function mountPicker()
48			{
49			if ($this->picker) {
50			$this->picker->mount($this);
51			$this->addVariables(['btn' => $this->btn]);
			0 ignored issues – show Bug introduced 2020-06-03 12:37 UTC by Report Bug Copy Issue Report It seems like `addVariables()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
52			}
53			}
54
55			/**
56			* @return string
57			*/
58			protected function getRules()
59			{
60			$rules = parent::getRules();
61
62			array_delete($rules, 'image');
63
64			return $rules;
65			}
66
67			/**
68			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View\|string
69			*/
70			protected function renderFilePicker()
71			{
72			$this->view = 'admin::form.filepicker';
			0 ignored issues – show Bug introduced 2020-06-03 12:37 UTC by Report Bug Copy Issue Report The property `view` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
73
74			$this->picker->mount($this);
75
76			$this->attribute('type', 'text')
			0 ignored issues – show Bug introduced 2020-06-03 12:37 UTC by Report Bug Copy Issue Report It seems like `attribute()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
77			->attribute('id', $this->id)
			0 ignored issues – show Bug introduced 2020-06-03 12:37 UTC by Report Bug Copy Issue Report The property `id` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
78			->attribute('name', $this->elementName ?: $this->formatName($this->column))
			0 ignored issues – show Bug introduced 2020-06-03 12:37 UTC by Report Bug Copy Issue Report The property `elementName` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2020-06-03 12:37 UTC by Report Bug Copy Issue Report The property `column` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2020-06-03 12:37 UTC by Report Bug Copy Issue Report It seems like `formatName()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
79			->attribute('value', old($this->elementName ?: $this->column, $this->value()))
			0 ignored issues – show Bug introduced 2020-06-03 12:37 UTC by Report Bug Copy Issue Report It seems like `value()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
80			->attribute('class', 'form-control '.$this->getElementClassString())
			0 ignored issues – show Bug introduced 2020-06-03 12:37 UTC by Report Bug Copy Issue Report It seems like `getElementClassString()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
81			->attribute('placeholder', $this->getPlaceholder());
			0 ignored issues – show Bug introduced 2020-06-03 12:37 UTC by Report Bug Copy Issue Report It seems like `getPlaceholder()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
82
83			$this->addVariables([
			0 ignored issues – show Bug introduced 2020-06-03 12:37 UTC by Report Bug Copy Issue Report It seems like `addVariables()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
84			'preview' => $this->picker->preview(),
85			'btn' => $this->btn
86			]);
87
88			return parent::render();
			0 ignored issues – show Comprehensibility Bug introduced 2020-06-03 12:37 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`render()` instead of `renderFilePicker()`). Are you sure this is correct? If so, you might want to change this to `$this->render()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
89			}
90
91			/**
92			* @param string $wrap
			0 ignored issues – show Bug introduced 2020-06-03 12:37 UTC by Report Bug Copy Issue Report There is no parameter named `$wrap`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
93			*/
94			public function addPickBtn($btn)
95			{
96			$this->btn = $btn;
97			}
98			}
99

z-song / laravel-admin

Push — master ( 631589...ae2f10 )

HasValuePicker::pick() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like