Footer::checkCreating() - Code Metrics - Inspection of "Fix #3619, class Encore\Admin\Form\Footer add `che..." - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ad6652...6943ef )

by Song

created 2019-07-04 11:14 UTC

Footer::checkCreating() A

↳ Parent: Footer

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	6
rs	10
c	0
b	0
f	0

<?php

namespace Encore\Admin\Form;

use Encore\Admin\Admin;
use Illuminate\Contracts\Support\Renderable;

class Footer implements Renderable
{
    /**
     * Footer view.
     *
     * @var string
     */
    protected $view = 'admin::form.footer';

    /**
     * Form builder instance.
     *
     * @var Builder
     */
    protected $builder;

    /**
     * Available buttons.
     *
     * @var array
     */
    protected $buttons = ['reset', 'submit'];

    /**
     * Available checkboxes.
     *
     * @var array
     */
    protected $checkboxes = ['view', 'continue_editing', 'continue_creating'];

    /**
     * @var string
     */
    protected $defaultCheck;

    /**
     * Footer constructor.
     *
     * @param Builder $builder
     */
    public function __construct(Builder $builder)
    {
        $this->builder = $builder;
    }

    /**
     * Disable reset button.
     *
     * @return $this
     */
    public function disableReset(bool $disable = true)

    {
        if ($disable) {
            array_delete($this->buttons, 'reset');
        } elseif (!in_array('reset', $this->buttons)) {
            array_push($this->buttons, 'reset');
        }

        return $this;
    }

    /**
     * Disable submit button.
     *
     * @return $this
     */
    public function disableSubmit(bool $disable = true)

    {
        if ($disable) {
            array_delete($this->buttons, 'submit');
        } elseif (!in_array('submit', $this->buttons)) {
            array_push($this->buttons, 'submit');
        }

        return $this;
    }

    /**
     * Disable View Checkbox.
     *
     * @return $this
     */
    public function disableViewCheck(bool $disable = true)

    {
        if ($disable) {
            array_delete($this->checkboxes, 'view');
        } elseif (!in_array('view', $this->checkboxes)) {
            array_push($this->checkboxes, 'view');
        }

        return $this;
    }

    /**
     * Disable Editing Checkbox.
     *
     * @return $this
     */
    public function disableEditingCheck(bool $disable = true)

    {
        if ($disable) {
            array_delete($this->checkboxes, 'continue_editing');
        } elseif (!in_array('continue_editing', $this->checkboxes)) {
            array_push($this->checkboxes, 'continue_editing');
        }

        return $this;
    }

    /**
     * Disable Creating Checkbox.
     *
     * @return $this
     */
    public function disableCreatingCheck(bool $disable = true)

    {
        if ($disable) {
            array_delete($this->checkboxes, 'continue_creating');
        } elseif (!in_array('continue_creating', $this->checkboxes)) {
            array_push($this->checkboxes, 'continue_creating');
        }

        return $this;
    }

    /**
     * Set `view` as default check.
     *
     * @return $this
     */
    public function checkView()
    {
        $this->defaultCheck = 'view';

        return $this;
    }

    /**
     * Set `continue_creating` as default check.
     *
     * @return $this
     */
    public function checkCreating()
    {
        $this->defaultCheck = 'continue_creating';

        return $this;
    }

    /**
     * Set `continue_editing` as default check.
     *
     * @return $this
     */
    public function checkEditing()
    {
        $this->defaultCheck = 'continue_editing';

        return $this;
    }

    /**
     * Setup scripts.
     */
    protected function setupScript()
    {
        $script = <<<'EOT'
$('.after-submit').iCheck({checkboxClass:'icheckbox_minimal-blue'}).on('ifChecked', function () {
    $('.after-submit').not(this).iCheck('uncheck');
});
EOT;

        Admin::script($script);
    }

    /**
     * Render footer.
     *
     * @return string
     */
    public function render()
    {
        $this->setupScript();

        $submitRedirects = [
            1 => 'continue_editing',
            2 => 'continue_creating',
            3 => 'view',
        ];

        $data = [
            'width'            => $this->builder->getWidth(),
            'buttons'          => $this->buttons,
            'checkboxes'       => $this->checkboxes,
            'submit_redirects' => $submitRedirects,
            'default_check'    => $this->defaultCheck,
        ];

        return view($this->view, $data)->render();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1		<?php
2
3		namespace Encore\Admin\Form;
4
5		use Encore\Admin\Admin;
6		use Illuminate\Contracts\Support\Renderable;
7
8		class Footer implements Renderable
9		{
10		/**
11		* Footer view.
12		*
13		* @var string
14		*/
15		protected $view = 'admin::form.footer';
16
17		/**
18		* Form builder instance.
19		*
20		* @var Builder
21		*/
22		protected $builder;
23
24		/**
25		* Available buttons.
26		*
27		* @var array
28		*/
29		protected $buttons = ['reset', 'submit'];
30
31		/**
32		* Available checkboxes.
33		*
34		* @var array
35		*/
36		protected $checkboxes = ['view', 'continue_editing', 'continue_creating'];
37
38		/**
39		* @var string
40		*/
41		protected $defaultCheck;
42
43		/**
44		* Footer constructor.
45		*
46		* @param Builder $builder
47		*/
48		public function __construct(Builder $builder)
49		{
50		$this->builder = $builder;
51		}
52
53		/**
54		* Disable reset button.
55		*
56		* @return $this
57		*/
58	View Code Duplication	public function disableReset(bool $disable = true)
		0 ignored issues – show Duplication introduced 2019-03-08 01:30 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		{
60		if ($disable) {
61		array_delete($this->buttons, 'reset');
62		} elseif (!in_array('reset', $this->buttons)) {
63		array_push($this->buttons, 'reset');
64		}
65
66		return $this;
67		}
68
69		/**
70		* Disable submit button.
71		*
72		* @return $this
73		*/
74	View Code Duplication	public function disableSubmit(bool $disable = true)
		0 ignored issues – show Duplication introduced 2019-03-08 01:30 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
75		{
76		if ($disable) {
77		array_delete($this->buttons, 'submit');
78		} elseif (!in_array('submit', $this->buttons)) {
79		array_push($this->buttons, 'submit');
80		}
81
82		return $this;
83		}
84
85		/**
86		* Disable View Checkbox.
87		*
88		* @return $this
89		*/
90	View Code Duplication	public function disableViewCheck(bool $disable = true)
		0 ignored issues – show Duplication introduced 2019-03-08 01:30 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
91		{
92		if ($disable) {
93		array_delete($this->checkboxes, 'view');
94		} elseif (!in_array('view', $this->checkboxes)) {
95		array_push($this->checkboxes, 'view');
96		}
97
98		return $this;
99		}
100
101		/**
102		* Disable Editing Checkbox.
103		*
104		* @return $this
105		*/
106	View Code Duplication	public function disableEditingCheck(bool $disable = true)
		0 ignored issues – show Duplication introduced 2019-03-08 01:30 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
107		{
108		if ($disable) {
109		array_delete($this->checkboxes, 'continue_editing');
110		} elseif (!in_array('continue_editing', $this->checkboxes)) {
111		array_push($this->checkboxes, 'continue_editing');
112		}
113
114		return $this;
115		}
116
117		/**
118		* Disable Creating Checkbox.
119		*
120		* @return $this
121		*/
122	View Code Duplication	public function disableCreatingCheck(bool $disable = true)
		0 ignored issues – show Duplication introduced 2019-03-08 01:30 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
123		{
124		if ($disable) {
125		array_delete($this->checkboxes, 'continue_creating');
126		} elseif (!in_array('continue_creating', $this->checkboxes)) {
127		array_push($this->checkboxes, 'continue_creating');
128		}
129
130		return $this;
131		}
132
133		/**
134		* Set `view` as default check.
135		*
136		* @return $this
137		*/
138		public function checkView()
139		{
140		$this->defaultCheck = 'view';
141
142		return $this;
143		}
144
145		/**
146		* Set `continue_creating` as default check.
147		*
148		* @return $this
149		*/
150		public function checkCreating()
151		{
152		$this->defaultCheck = 'continue_creating';
153
154		return $this;
155		}
156
157		/**
158		* Set `continue_editing` as default check.
159		*
160		* @return $this
161		*/
162		public function checkEditing()
163		{
164		$this->defaultCheck = 'continue_editing';
165
166		return $this;
167		}
168
169		/**
170		* Setup scripts.
171		*/
172		protected function setupScript()
173		{
174		$script = <<<'EOT'
175		$('.after-submit').iCheck({checkboxClass:'icheckbox_minimal-blue'}).on('ifChecked', function () {
176		$('.after-submit').not(this).iCheck('uncheck');
177		});
178		EOT;
179
180		Admin::script($script);
181		}
182
183		/**
184		* Render footer.
185		*
186		* @return string
187		*/
188		public function render()
189		{
190		$this->setupScript();
191
192		$submitRedirects = [
193		1 => 'continue_editing',
194		2 => 'continue_creating',
195		3 => 'view',
196		];
197
198		$data = [
199		'width' => $this->builder->getWidth(),
200		'buttons' => $this->buttons,
201		'checkboxes' => $this->checkboxes,
202		'submit_redirects' => $submitRedirects,
203		'default_check' => $this->defaultCheck,
204		];
205
206		return view($this->view, $data)->render();
		0 ignored issues – show Bug introduced 2018-08-05 07:54 UTC by Report Bug Copy Issue Report The method `render` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
207		}
208		}
209

z-song / laravel-admin

Push — master ( ad6652...6943ef )

Footer::checkCreating() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like