RadioButton::addScript() - Code Metrics - Inspection of "radioCard、checkboxCard、radioButton、checkboxButton" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c833c1...b511be )

by Song

created 2020-05-25 13:36 UTC

RadioButton::addScript() A

↳ Parent: RadioButton

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	11
Ratio	100 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	11
loc	11
rs	9.9
c	0
b	0
f	0

<?php

namespace Encore\Admin\Form\Field;

use Encore\Admin\Admin;

class RadioButton extends Radio

{
    /**
     * @var string
     */
    protected $cascadeEvent = 'change';

    /**
     *
     */
    protected function addScript()
    {
        $script = <<<SCRIPT
$('.radio-group-toggle label').click(function() {
    $(this).parent().children().removeClass('active');
    $(this).addClass('active');
});
SCRIPT;

        Admin::script($script);
    }

    /**
     * {@inheritdoc}
     */
    public function render()
    {
        $this->addScript();

        $this->addCascadeScript();

        $this->addVariables([
            'options' => $this->options,
            'checked' => $this->checked,
        ]);

        return parent::fieldRender();
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }
}


1		<?php
2
3		namespace Encore\Admin\Form\Field;
4
5		use Encore\Admin\Admin;
6
7	View Code Duplication	class RadioButton extends Radio
		0 ignored issues – show Duplication introduced 2020-05-25 13:39 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
8		{
9		/**
10		* @var string
11		*/
12		protected $cascadeEvent = 'change';
13
14		/**
15		*
16		*/
17		protected function addScript()
18		{
19		$script = <<<SCRIPT
20		$('.radio-group-toggle label').click(function() {
21		$(this).parent().children().removeClass('active');
22		$(this).addClass('active');
23		});
24		SCRIPT;
25
26		Admin::script($script);
27		}
28
29		/**
30		* {@inheritdoc}
31		*/
32		public function render()
33		{
34		$this->addScript();
35
36		$this->addCascadeScript();
37
38		$this->addVariables([
39		'options' => $this->options,
40		'checked' => $this->checked,
41		]);
42
43		return parent::fieldRender();
		0 ignored issues – show Bug Compatibility introduced 2020-05-25 13:39 UTC by Report Bug Copy Issue Report The expression `parent::fieldRender();` of type `string\|Illuminate\View\V...\Contracts\View\Factory` adds the type `Illuminate\Contracts\View\Factory` to the return on line 43 which is incompatible with the return type declared by the interface `Illuminate\Contracts\Support\Renderable::render` of type `string`. Loading history... Comprehensibility Bug introduced 2020-05-25 13:39 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`fieldRender()` instead of `render()`). Are you sure this is correct? If so, you might want to change this to `$this->fieldRender()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
44		}
45		}
46

z-song / laravel-admin

Push — master ( c833c1...b511be )

RadioButton::addScript() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like