Completed
Pull Request — master (#5073)
by Song
05:21 queued 02:13
created
src/Grid/Displayers/Modal.php 1 patch
Doc Comments   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -14,7 +14,6 @@  discard block
 block discarded – undo
14 14
     protected $renderable;
15 15
 
16 16
     /**
17
-     * @param int $multiple
18 17
      *
19 18
      * @return string
20 19
      */
@@ -28,7 +27,7 @@  discard block
 block discarded – undo
28 27
     /**
29 28
      * @param \Closure|string $callback
30 29
      *
31
-     * @return mixed|string
30
+     * @return string
32 31
      */
33 32
     public function display($callback = null)
34 33
     {
Please login to merge, or discard this patch.
src/AdminServiceProvider.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -83,11 +83,11 @@  discard block
 block discarded – undo
83 83
 
84 84
         $this->compatibleBlade();
85 85
 
86
-        Blade::directive('box', function ($title) {
86
+        Blade::directive('box', function($title) {
87 87
             return "<?php \$box = new \Encore\Admin\Widgets\Box({$title}, '";
88 88
         });
89 89
 
90
-        Blade::directive('endbox', function ($expression) {
90
+        Blade::directive('endbox', function($expression) {
91 91
             return "'); echo \$box->render(); ?>";
92 92
         });
93 93
     }
@@ -139,8 +139,8 @@  discard block
 block discarded – undo
139 139
      */
140 140
     protected function macroRouter()
141 141
     {
142
-        Router::macro('content', function ($uri, $content, $options = []) {
143
-            return $this->match(['GET', 'HEAD'], $uri, function (Content $layout) use ($content, $options) {
142
+        Router::macro('content', function($uri, $content, $options = []) {
143
+            return $this->match(['GET', 'HEAD'], $uri, function(Content $layout) use ($content, $options) {
144 144
                 return $layout
145 145
                     ->title(Arr::get($options, 'title', ' '))
146 146
                     ->description(Arr::get($options, 'desc', ' '))
@@ -148,8 +148,8 @@  discard block
 block discarded – undo
148 148
             });
149 149
         });
150 150
 
151
-        Router::macro('component', function ($uri, $component, $data = [], $options = []) {
152
-            return $this->match(['GET', 'HEAD'], $uri, function (Content $layout) use ($component, $data, $options) {
151
+        Router::macro('component', function($uri, $component, $data = [], $options = []) {
152
+            return $this->match(['GET', 'HEAD'], $uri, function(Content $layout) use ($component, $data, $options) {
153 153
                 return $layout
154 154
                     ->title(Arr::get($options, 'title', ' '))
155 155
                     ->description(Arr::get($options, 'desc', ' '))
Please login to merge, or discard this patch.
src/Grid/Concerns/HasQuickSearch.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
             $this->search = $search;
43 43
         }
44 44
 
45
-        return tap(new Tools\QuickSearch(), function ($search) {
45
+        return tap(new Tools\QuickSearch(), function($search) {
46 46
             $this->tools->append($search);
47 47
         });
48 48
     }
@@ -67,14 +67,14 @@  discard block
 block discarded – undo
67 67
         }
68 68
 
69 69
         if (is_array($this->search)) {
70
-            $this->model()->where(function (Builder $builder) use ($query) {
70
+            $this->model()->where(function(Builder $builder) use ($query) {
71 71
                 foreach ($this->search as $column) {
72 72
                     $this->addWhereLikeBinding($builder, $column, true, '%'.$query.'%');
73 73
                 }
74 74
             });
75 75
 
76 76
         } elseif (is_null($this->search)) {
77
-            $this->model()->where(function (Builder $builder) use ($query) {
77
+            $this->model()->where(function(Builder $builder) use ($query) {
78 78
                 $this->addWhereBindings($builder, $query);
79 79
             });
80 80
         }
@@ -132,14 +132,14 @@  discard block
 block discarded – undo
132 132
      */
133 133
     protected function parseQueryBindings(array $queries)
134 134
     {
135
-        $columnMap = $this->columns->mapWithKeys(function (Column $column) {
135
+        $columnMap = $this->columns->mapWithKeys(function(Column $column) {
136 136
             $label = $column->getLabel();
137 137
             $name = $column->getName();
138 138
 
139 139
             return [$label => $name, $name => $name];
140 140
         });
141 141
 
142
-        return collect($queries)->map(function ($query) use ($columnMap) {
142
+        return collect($queries)->map(function($query) use ($columnMap) {
143 143
             $segments = explode(':', $query, 2);
144 144
 
145 145
             if (count($segments) != 2) {
Please login to merge, or discard this patch.
src/Form/Field.php 1 patch
Doc Comments   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
      *
283 283
      * @param string $column
284 284
      *
285
-     * @return mixed|string
285
+     * @return string
286 286
      */
287 287
     protected function formatColumn($column = '')
288 288
     {
@@ -591,7 +591,7 @@  discard block
 block discarded – undo
591 591
     }
592 592
 
593 593
     /**
594
-     * @param string|array|Closure $input
594
+     * @param callable|null $input
595 595
      * @param string|array         $original
596 596
      *
597 597
      * @return array|Closure
@@ -802,7 +802,7 @@  discard block
 block discarded – undo
802 802
     /**
803 803
      * Set or get value of the field.
804 804
      *
805
-     * @param null $value
805
+     * @param string $value
806 806
      *
807 807
      * @return mixed
808 808
      */
@@ -973,7 +973,7 @@  discard block
 block discarded – undo
973 973
     /**
974 974
      * Add html attributes to elements.
975 975
      *
976
-     * @param array|string $attribute
976
+     * @param string $attribute
977 977
      * @param mixed        $value
978 978
      *
979 979
      * @return $this
@@ -1103,7 +1103,7 @@  discard block
 block discarded – undo
1103 1103
     /**
1104 1104
      * Get placeholder.
1105 1105
      *
1106
-     * @return mixed
1106
+     * @return string
1107 1107
      */
1108 1108
     public function getPlaceholder()
1109 1109
     {
@@ -1360,7 +1360,7 @@  discard block
 block discarded – undo
1360 1360
     }
1361 1361
 
1362 1362
     /**
1363
-     * @param array $labelClass
1363
+     * @param string[] $labelClass
1364 1364
      * @param bool  $replace
1365 1365
      *
1366 1366
      * @return self
@@ -1415,7 +1415,7 @@  discard block
 block discarded – undo
1415 1415
      *
1416 1416
      * @param string $view
1417 1417
      *
1418
-     * @return string
1418
+     * @return Field
1419 1419
      */
1420 1420
     public function setView($view): self
1421 1421
     {
Please login to merge, or discard this patch.
src/Form/Field/PlainInput.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,7 +15,7 @@  discard block
 block discarded – undo
15 15
     protected $append;
16 16
 
17 17
     /**
18
-     * @param mixed $string
18
+     * @param string $string
19 19
      *
20 20
      * @return $this
21 21
      */
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
     }
30 30
 
31 31
     /**
32
-     * @param mixed $string
32
+     * @param string $string
33 33
      *
34 34
      * @return $this
35 35
      */
Please login to merge, or discard this patch.
src/Grid/Tools/ColumnSelector.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,9 +33,9 @@
 block discarded – undo
33 33
      */
34 34
     protected function getGridColumns()
35 35
     {
36
-        return $this->grid->columns()->reject(function ($column) {
36
+        return $this->grid->columns()->reject(function($column) {
37 37
             return in_array($column->getName(), static::$ignored);
38
-        })->map(function ($column) {
38
+        })->map(function($column) {
39 39
             return [$column->getName() => $column->getLabel()];
40 40
         })->collapse();
41 41
     }
Please login to merge, or discard this patch.
src/Grid/Displayers/AbstractDisplayer.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@
 block discarded – undo
123 123
     {
124 124
         $keys = collect(explode('.', $name ?: $this->getName()));
125 125
 
126
-        return $keys->shift().$keys->reduce(function ($carry, $val) {
126
+        return $keys->shift().$keys->reduce(function($carry, $val) {
127 127
             return $carry."[$val]";
128 128
         });
129 129
     }
Please login to merge, or discard this patch.
src/Grid/Displayers/SwitchGroup.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
         $this->overrideStates($states);
13 13
 
14 14
         if (!Arr::isAssoc($columns)) {
15
-            $columns = collect($columns)->map(function ($column) {
15
+            $columns = collect($columns)->map(function($column) {
16 16
                 return [$column => ucfirst($column)];
17 17
             })->collapse();
18 18
         }
Please login to merge, or discard this patch.
src/Form/Field/CanCascadeFields.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
     {
105 105
         if ($this->form) {
106 106
             $this->form->fields()
107
-                ->filter(function (Form\Field $field) {
107
+                ->filter(function(Form\Field $field) {
108 108
                     return $field instanceof CascadeGroup
109 109
                         && $field->dependsOn($this)
110 110
                         && $this->hitsCondition($field);
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
             return;
167 167
         }
168 168
 
169
-        $cascadeGroups = collect($this->conditions)->map(function ($condition) {
169
+        $cascadeGroups = collect($this->conditions)->map(function($condition) {
170 170
             return [
171 171
                 'class'    => $this->getCascadeClass($condition['value']),
172 172
                 'operator' => $condition['operator'],
Please login to merge, or discard this patch.