Completed
Pull Request — master (#5073)
by Song
05:21 queued 02:13
created
src/Form/Field/Textarea.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,6 @@
 block discarded – undo
59 59
     }
60 60
 
61 61
     /**
62
-     * @param string $wrap
63 62
      */
64 63
     protected function addPickBtn($btn)
65 64
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
             $this->value = json_encode($this->value, JSON_PRETTY_PRINT);
49 49
         }
50 50
 
51
-        $this->mountPicker(function ($btn) {
51
+        $this->mountPicker(function($btn) {
52 52
             $this->addPickBtn($btn);
53 53
         });
54 54
 
Please login to merge, or discard this patch.
src/Form/Field/ValuePicker.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,6 @@
 block discarded – undo
55 55
     }
56 56
 
57 57
     /**
58
-     * @param int $multiple
59 58
      *
60 59
      * @return string
61 60
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@
 block discarded – undo
125 125
             $value = explode($this->separator, $value);
126 126
         }
127 127
 
128
-        return collect(Arr::wrap($value))->map(function ($item) use ($field) {
128
+        return collect(Arr::wrap($value))->map(function($item) use ($field) {
129 129
             return [
130 130
                 'url'     => $this->field->objectUrl($item),
131 131
                 'value'   => $item,
Please login to merge, or discard this patch.
src/Grid/Displayers/Expand.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,6 @@
 block discarded – undo
55 55
     }
56 56
 
57 57
     /**
58
-     * @param int $multiple
59 58
      *
60 59
      * @return string
61 60
      */
Please login to merge, or discard this patch.
src/Grid/Column/InlineEditing.php 2 patches
Doc Comments   -2 removed lines patch added patch discarded remove patch
@@ -70,7 +70,6 @@  discard block
 block discarded – undo
70 70
     /**
71 71
      * Grid inline date picker.
72 72
      *
73
-     * @param string $format
74 73
      *
75 74
      * @return $this
76 75
      */
@@ -82,7 +81,6 @@  discard block
 block discarded – undo
82 81
     /**
83 82
      * Grid inline time picker.
84 83
      *
85
-     * @param string $format
86 84
      *
87 85
      * @return $this
88 86
      */
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -232,7 +232,7 @@  discard block
 block discarded – undo
232 232
     {
233 233
         $identifiers = \DateTimeZone::listIdentifiers(\DateTimeZone::ALL);
234 234
 
235
-        $options = collect($identifiers)->mapWithKeys(function ($timezone) {
235
+        $options = collect($identifiers)->mapWithKeys(function($timezone) {
236 236
             return [$timezone => $timezone];
237 237
         })->toArray();
238 238
 
@@ -294,7 +294,7 @@  discard block
 block discarded – undo
294 294
      *
295 295
      * @return $this
296 296
      */
297
-    public function switch(array $states = [])
297
+    public function switch (array $states = [])
298 298
     {
299 299
         return $this->displayUsing(Displayers\SwitchDisplay::class, [$states]);
300 300
     }
Please login to merge, or discard this patch.
src/Grid/Displayers/BelongsTo.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -9,6 +9,7 @@
 block discarded – undo
9 9
 {
10 10
     /**
11 11
      * @param int $multiple
12
+     * @param string|null $selectable
12 13
      *
13 14
      * @return string
14 15
      */
Please login to merge, or discard this patch.
src/Grid/Column.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -431,7 +431,7 @@  discard block
 block discarded – undo
431 431
 
432 432
         $column = $this;
433 433
 
434
-        return $this->display(function ($value) use ($grid, $column, $abstract, $arguments) {
434
+        return $this->display(function($value) use ($grid, $column, $abstract, $arguments) {
435 435
             /** @var AbstractDisplayer $displayer */
436 436
             $displayer = new $abstract($value, $grid, $column, $this);
437 437
 
@@ -480,7 +480,7 @@  discard block
 block discarded – undo
480 480
 
481 481
         $grid = $this->grid;
482 482
 
483
-        return $this->display(function ($_, $column) use ($action, $grid) {
483
+        return $this->display(function($_, $column) use ($action, $grid) {
484 484
             /** @var RowAction $action */
485 485
             $action = new $action();
486 486
 
@@ -608,7 +608,7 @@  discard block
 block discarded – undo
608 608
         $grid = $this->grid;
609 609
         $column = $this;
610 610
 
611
-        $this->display(function ($value) use ($grid, $column, $class) {
611
+        $this->display(function($value) use ($grid, $column, $class) {
612 612
             /** @var AbstractDisplayer $definition */
613 613
             $definition = new $class($value, $grid, $column, $this);
614 614
 
@@ -626,7 +626,7 @@  discard block
 block discarded – undo
626 626
     protected function htmlEntityEncode($item)
627 627
     {
628 628
         if (is_array($item)) {
629
-            array_walk_recursive($item, function (&$value) {
629
+            array_walk_recursive($item, function(&$value) {
630 630
                 $value = htmlentities($value);
631 631
             });
632 632
         } else {
@@ -663,7 +663,7 @@  discard block
 block discarded – undo
663 663
      */
664 664
     protected function callSupportDisplayer($abstract, $arguments)
665 665
     {
666
-        return $this->display(function ($value) use ($abstract, $arguments) {
666
+        return $this->display(function($value) use ($abstract, $arguments) {
667 667
             if (is_array($value) || $value instanceof Arrayable) {
668 668
                 return call_user_func_array([collect($value), $abstract], $arguments);
669 669
             }
@@ -687,7 +687,7 @@  discard block
 block discarded – undo
687 687
     protected function callBuiltinDisplayer($abstract, $arguments)
688 688
     {
689 689
         if ($abstract instanceof Closure) {
690
-            return $this->display(function ($value) use ($abstract, $arguments) {
690
+            return $this->display(function($value) use ($abstract, $arguments) {
691 691
                 return $abstract->call($this, ...array_merge([$value], $arguments));
692 692
             });
693 693
         }
@@ -696,7 +696,7 @@  discard block
 block discarded – undo
696 696
             $grid = $this->grid;
697 697
             $column = $this;
698 698
 
699
-            return $this->display(function ($value) use ($abstract, $grid, $column, $arguments) {
699
+            return $this->display(function($value) use ($abstract, $grid, $column, $arguments) {
700 700
                 /** @var AbstractDisplayer $displayer */
701 701
                 $displayer = new $abstract($value, $grid, $column, $this);
702 702
 
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -2 removed lines patch added patch discarded remove patch
@@ -201,6 +201,7 @@  discard block
 block discarded – undo
201 201
      * Get column attributes.
202 202
      *
203 203
      * @param string $name
204
+     * @param string $key
204 205
      *
205 206
      * @return mixed
206 207
      */
@@ -281,7 +282,7 @@  discard block
 block discarded – undo
281 282
     /**
282 283
      * Get name of this column.
283 284
      *
284
-     * @return mixed
285
+     * @return string
285 286
      */
286 287
     public function getName()
287 288
     {
@@ -319,7 +320,7 @@  discard block
 block discarded – undo
319 320
     /**
320 321
      * Get label of the column.
321 322
      *
322
-     * @return mixed
323
+     * @return string
323 324
      */
324 325
     public function getLabel()
325 326
     {
Please login to merge, or discard this patch.
src/Grid/Column/ExtendDisplay.php 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
         $name = $this->getName();
90 90
         $query = request()->query();
91 91
 
92
-        $this->prefix(function ($_, $original) use ($name, $query) {
92
+        $this->prefix(function($_, $original) use ($name, $query) {
93 93
             Arr::set($query, $name, $original);
94 94
 
95 95
             $url = request()->fullUrlWithQuery($query);
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
      */
123 123
     public function using(array $values, $default = null)
124 124
     {
125
-        return $this->display(function ($value) use ($values, $default) {
125
+        return $this->display(function($value) use ($values, $default) {
126 126
             if (is_null($value)) {
127 127
                 return $default;
128 128
             }
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
      */
141 141
     public function replace(array $replacements)
142 142
     {
143
-        return $this->display(function ($value) use ($replacements) {
143
+        return $this->display(function($value) use ($replacements) {
144 144
             if (isset($replacements[$value])) {
145 145
                 return $replacements[$value];
146 146
             }
@@ -158,13 +158,13 @@  discard block
 block discarded – undo
158 158
     public function repeat($input, $seperator = '')
159 159
     {
160 160
         if (is_string($input)) {
161
-            $input = function () use ($input) {
161
+            $input = function() use ($input) {
162 162
                 return $input;
163 163
             };
164 164
         }
165 165
 
166 166
         if ($input instanceof Closure) {
167
-            return $this->display(function ($value) use ($input, $seperator) {
167
+            return $this->display(function($value) use ($input, $seperator) {
168 168
                 return join($seperator, array_fill(0, (int) $value, $input->call($this, [$value])));
169 169
             });
170 170
         }
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
      */
182 182
     public function view($view)
183 183
     {
184
-        return $this->display(function ($value) use ($view) {
184
+        return $this->display(function($value) use ($view) {
185 185
             $model = $this;
186 186
 
187 187
             return view($view, compact('model', 'value'))->render();
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
      */
196 196
     public function filesize()
197 197
     {
198
-        return $this->display(function ($value) {
198
+        return $this->display(function($value) {
199 199
             return file_size($value);
200 200
         });
201 201
     }
@@ -209,7 +209,7 @@  discard block
 block discarded – undo
209 209
      */
210 210
     public function gravatar($size = 30)
211 211
     {
212
-        return $this->display(function ($value) use ($size) {
212
+        return $this->display(function($value) use ($size) {
213 213
             $src = sprintf(
214 214
                 'https://www.gravatar.com/avatar/%s?s=%d',
215 215
                 md5(strtolower($value)),
@@ -230,7 +230,7 @@  discard block
 block discarded – undo
230 230
      */
231 231
     public function loading($values = [], $others = [])
232 232
     {
233
-        return $this->display(function ($value) use ($values, $others) {
233
+        return $this->display(function($value) use ($values, $others) {
234 234
             $values = (array) $values;
235 235
 
236 236
             if (in_array($value, $values)) {
@@ -251,7 +251,7 @@  discard block
 block discarded – undo
251 251
      */
252 252
     public function icon(array $setting, $default = '')
253 253
     {
254
-        return $this->display(function ($value) use ($setting, $default) {
254
+        return $this->display(function($value) use ($setting, $default) {
255 255
             $fa = '';
256 256
 
257 257
             if (isset($setting[$value])) {
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
             Carbon::setLocale($locale);
278 278
         }
279 279
 
280
-        return $this->display(function ($value) {
280
+        return $this->display(function($value) {
281 281
             return Carbon::parse($value)->diffForHumans();
282 282
         });
283 283
     }
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
      */
293 293
     public function bool(array $map = [], $default = false)
294 294
     {
295
-        return $this->display(function ($value) use ($map, $default) {
295
+        return $this->display(function($value) use ($map, $default) {
296 296
             $bool = empty($map) ? boolval($value) : Arr::get($map, $value, $default);
297 297
 
298 298
             return $bool ? '<i class="fa fa-check text-green"></i>' : '<i class="fa fa-close text-red"></i>';
@@ -307,7 +307,7 @@  discard block
 block discarded – undo
307 307
      */
308 308
     public function default($default = '-')
309 309
     {
310
-        return $this->display(function ($value) use ($default) {
310
+        return $this->display(function($value) use ($default) {
311 311
             return $value ?: $default;
312 312
         });
313 313
     }
@@ -322,7 +322,7 @@  discard block
 block discarded – undo
322 322
      */
323 323
     public function dot($options = [], $default = '')
324 324
     {
325
-        return $this->prefix(function ($_, $original) use ($options, $default) {
325
+        return $this->prefix(function($_, $original) use ($options, $default) {
326 326
             if (is_null($original)) {
327 327
                 $style = $default;
328 328
             } else {
Please login to merge, or discard this patch.
src/Grid/Exporters/CsvExporter.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -157,16 +157,16 @@  discard block
 block discarded – undo
157 157
             call_user_func($this->callback, $this);
158 158
         }
159 159
 
160
-        $response = function () {
160
+        $response = function() {
161 161
             $handle = fopen('php://output', 'w');
162 162
             $titles = [];
163 163
 
164
-            $this->chunk(function ($collection) use ($handle, &$titles) {
164
+            $this->chunk(function($collection) use ($handle, &$titles) {
165 165
                 Column::setOriginalGridModels($collection);
166 166
 
167 167
                 $original = $current = $collection->toArray();
168 168
 
169
-                $this->grid->getColumns()->map(function (Column $column) use (&$current) {
169
+                $this->grid->getColumns()->map(function(Column $column) use (&$current) {
170 170
                     $current = $column->fill($current);
171 171
                     $this->grid->columnNames[] = $column->getName();
172 172
                 });
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
     protected function getVisiableTitles()
196 196
     {
197 197
         $titles = $this->grid->visibleColumns()
198
-            ->mapWithKeys(function (Column $column) {
198
+            ->mapWithKeys(function(Column $column) {
199 199
                 $columnName = $column->getName();
200 200
                 $columnTitle = $column->getLabel();
201 201
                 if (isset($this->titleCallbacks[$columnName])) {
Please login to merge, or discard this patch.
src/Grid/Displayers/DropdownActions.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -123,7 +123,7 @@
 block discarded – undo
123 123
     /**
124 124
      * @param null|\Closure $callback
125 125
      *
126
-     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View|string
126
+     * @return string|null
127 127
      */
128 128
     public function display($callback = null)
129 129
     {
Please login to merge, or discard this patch.