Row - Code Metrics - Inspection of "[fix]Fix issue #2339" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 11c39b...041fc3 )

by Song

created 2018-08-21 04:19 UTC

Row A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	192
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	4

Importance

Changes

Metric	Value
dl	0
loc	192
rs	10
c	0
b	0
f	0
wmc	22
lcom	2
cbo	4

11 Methods

Rating	Name	Size	Complexity
A	__construct()	6	1
A	getKey()	4	1
A	getRowAttributes()	4	1
A	getColumnAttributes()	8	2
A	formatHtmlAttribute()	9	2
A	setAttributes()	4	1
A	style()	12	3
A	model()	4	1
A	__get()	4	1
A	column()	16	3
B	output()	20	6

<?php

namespace Encore\Admin\Grid;

use Closure;
use Illuminate\Contracts\Support\Htmlable;
use Illuminate\Contracts\Support\Jsonable;
use Illuminate\Contracts\Support\Renderable;

class Row
{
    /**
     * Row number.
     *
     * @var
     */
    public $number;

    /**
     * Row data.
     *
     * @var
     */
    protected $data;

    /**
     * Attributes of row.
     *
     * @var array
     */
    protected $attributes = [];

    /**
     * Constructor.
     *
     * @param $number
     * @param $data
     */
    public function __construct($number, $data)
    {
        $this->number = $number;

        $this->data = $data;
    }

    /**
     * Get the value of the model's primary key.
     *
     * @return mixed
     */
    public function getKey()
    {
        return $this->model->getKey();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Get attributes in html format.
     *
     * @return string
     */
    public function getRowAttributes()
    {
        return $this->formatHtmlAttribute($this->attributes);
    }

    /**
     * Get column attributes.
     *
     * @param string $column
     *
     * @return string
     */
    public function getColumnAttributes($column)
    {
        if ($attributes = Column::getAttributes($column)) {
            return $this->formatHtmlAttribute($attributes);
        }

        return '';
    }

    /**
     * Format attributes to html.
     *
     * @param array $attributes
     *
     * @return string
     */
    private function formatHtmlAttribute($attributes = [])
    {
        $attrArr = [];
        foreach ($attributes as $name => $val) {
            $attrArr[] = "$name=\"$val\"";
        }

        return implode(' ', $attrArr);
    }

    /**
     * Set attributes.
     *
     * @param array $attributes
     */
    public function setAttributes(array $attributes)
    {
        $this->attributes = $attributes;
    }

    /**
     * Set style of the row.
     *
     * @param array|string $style
     */
    public function style($style)
    {
        if (is_array($style)) {
            $style = implode('', array_map(function ($key, $val) {
                return "$key:$val";
            }, array_keys($style), array_values($style)));
        }

        if (is_string($style)) {
            $this->attributes['style'] = $style;
        }
    }

    /**
     * Get data of this row.
     *
     * @return mixed
     */
    public function model()
    {
        return $this->data;
    }

    /**
     * Getter.
     *
     * @param mixed $attr
     *
     * @return mixed
     */
    public function __get($attr)
    {
        return array_get($this->data, $attr);
    }

    /**
     * Get or set value of column in this row.
     *
     * @param string $name
     * @param mixed  $value
     *
     * @return $this|mixed
     */
    public function column($name, $value = null)
    {
        if (is_null($value)) {
            $column = array_get($this->data, $name);

            return $this->output($column);
        }

        if ($value instanceof Closure) {
            $value = $value->call($this, $this->column($name));
        }

        array_set($this->data, $name, $value);

        return $this;
    }

    /**
     * Output column value.
     *
     * @param mixed $value
     *
     * @return mixed|string
     */
    protected function output($value)
    {
        if ($value instanceof Renderable) {
            $value = $value->render();
        }

        if ($value instanceof Htmlable) {
            $value = $value->toHtml();
        }

        if ($value instanceof Jsonable) {
            $value = $value->toJson();
        }

        if (!is_null($value) && !is_scalar($value)) {
            return sprintf('<pre>%s</pre>', var_export($value, true));
        }

        return $value;
    }
}


1			<?php
2
3			namespace Encore\Admin\Grid;
4
5			use Closure;
6			use Illuminate\Contracts\Support\Htmlable;
7			use Illuminate\Contracts\Support\Jsonable;
8			use Illuminate\Contracts\Support\Renderable;
9
10			class Row
11			{
12			/**
13			* Row number.
14			*
15			* @var
16			*/
17			public $number;
18
19			/**
20			* Row data.
21			*
22			* @var
23			*/
24			protected $data;
25
26			/**
27			* Attributes of row.
28			*
29			* @var array
30			*/
31			protected $attributes = [];
32
33			/**
34			* Constructor.
35			*
36			* @param $number
37			* @param $data
38			*/
39			public function __construct($number, $data)
40			{
41			$this->number = $number;
42
43			$this->data = $data;
44			}
45
46			/**
47			* Get the value of the model's primary key.
48			*
49			* @return mixed
50			*/
51			public function getKey()
52			{
53			return $this->model->getKey();
			0 ignored issues – show Documentation introduced 2017-09-01 02:27 UTC by Report Bug Copy Issue Report The property `model` does not exist on `object<Encore\Admin\Grid\Row>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
54			}
55
56			/**
57			* Get attributes in html format.
58			*
59			* @return string
60			*/
61			public function getRowAttributes()
62			{
63			return $this->formatHtmlAttribute($this->attributes);
64			}
65
66			/**
67			* Get column attributes.
68			*
69			* @param string $column
70			*
71			* @return string
72			*/
73			public function getColumnAttributes($column)
74			{
75			if ($attributes = Column::getAttributes($column)) {
76			return $this->formatHtmlAttribute($attributes);
77			}
78
79			return '';
80			}
81
82			/**
83			* Format attributes to html.
84			*
85			* @param array $attributes
86			*
87			* @return string
88			*/
89			private function formatHtmlAttribute($attributes = [])
90			{
91			$attrArr = [];
92			foreach ($attributes as $name => $val) {
93			$attrArr[] = "$name=\"$val\"";
94			}
95
96			return implode(' ', $attrArr);
97			}
98
99			/**
100			* Set attributes.
101			*
102			* @param array $attributes
103			*/
104			public function setAttributes(array $attributes)
105			{
106			$this->attributes = $attributes;
107			}
108
109			/**
110			* Set style of the row.
111			*
112			* @param array\|string $style
113			*/
114			public function style($style)
115			{
116			if (is_array($style)) {
117			$style = implode('', array_map(function ($key, $val) {
118			return "$key:$val";
119			}, array_keys($style), array_values($style)));
120			}
121
122			if (is_string($style)) {
123			$this->attributes['style'] = $style;
124			}
125			}
126
127			/**
128			* Get data of this row.
129			*
130			* @return mixed
131			*/
132			public function model()
133			{
134			return $this->data;
135			}
136
137			/**
138			* Getter.
139			*
140			* @param mixed $attr
141			*
142			* @return mixed
143			*/
144			public function __get($attr)
145			{
146			return array_get($this->data, $attr);
147			}
148
149			/**
150			* Get or set value of column in this row.
151			*
152			* @param string $name
153			* @param mixed $value
154			*
155			* @return $this\|mixed
156			*/
157			public function column($name, $value = null)
158			{
159			if (is_null($value)) {
160			$column = array_get($this->data, $name);
161
162			return $this->output($column);
163			}
164
165			if ($value instanceof Closure) {
166			$value = $value->call($this, $this->column($name));
167			}
168
169			array_set($this->data, $name, $value);
170
171			return $this;
172			}
173
174			/**
175			* Output column value.
176			*
177			* @param mixed $value
178			*
179			* @return mixed\|string
180			*/
181			protected function output($value)
182			{
183			if ($value instanceof Renderable) {
184			$value = $value->render();
185			}
186
187			if ($value instanceof Htmlable) {
188			$value = $value->toHtml();
189			}
190
191			if ($value instanceof Jsonable) {
192			$value = $value->toJson();
193			}
194
195			if (!is_null($value) && !is_scalar($value)) {
196			return sprintf('<pre>%s</pre>', var_export($value, true));
197			}
198
199			return $value;
200			}
201			}
202

z-song / laravel-admin

Push — master ( 11c39b...041fc3 )

Row A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

11 Methods

Duplication Side-by-Side

Filter issues like