Encore\Admin\Grid\Displayers\Modal::addRenderableModalScript()

Complexity

Conditions	1
Paths	1

Size

Total Lines

34

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	Modal::display()	0	27	4

<?php

namespace Encore\Admin\Grid\Displayers;

use Encore\Admin\Admin;
use Encore\Admin\Grid\Simple;
use Illuminate\Contracts\Support\Renderable;

class Modal extends AbstractDisplayer
{
    /**
     * @var string
     */
    protected $renderable;

    /**
     * @param int $multiple

There is no parameter named $multiple. Was it maybe removed?

     *
     * @return string
     */
    protected function getLoadUrl()
    {
        $renderable = str_replace('\\', '_', $this->renderable);

        return route('admin.handle-renderable', compact('renderable'));
    }

    /**
     * @param \Closure|string $callback
     *
     * @return mixed|string
     */
    public function display($callback = null)
    {
        if (func_num_args() == 2) {
            list($title, $callback) = func_get_args();
        } elseif (func_num_args() == 1) {
            $title = $this->trans('title');
        }

        $html  = '';

        if ($async = is_subclass_of($callback, Renderable::class)) {

Due to PHP Bug #53727, is_subclass_of might return inconsistent results on some PHP versions if \Illuminate\Contracts\Support\Renderable::class can be an interface. If so, you could instead use ReflectionClass::implementsInterface.

            $this->renderable = $callback;
        } else {
            $html = call_user_func_array($callback->bindTo($this->row), [$this->row]);
        }

        return Admin::component('admin::components.column-modal', [
            'url'     => $this->getLoadUrl(),
            'async'   => $async,
            'grid'    => is_subclass_of($callback, Simple::class),

Due to PHP Bug #53727, is_subclass_of might return inconsistent results on some PHP versions if \Encore\Admin\Grid\Simple::class can be an interface. If so, you could instead use ReflectionClass::implementsInterface.

            'title'   => $title,

The variable $title does not seem to be defined for all execution paths leading up to this point.

            'html'    => $html,
            'key'     => $this->getKey(),
            'value'   => $this->value,
            'name'    => $this->getKey() . '-' . str_replace('.', '_', $this->getColumn()->getName()),
        ]);
    }
}