Modal::display() - Code Metrics - Inspection of "wip" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8f0aef...6f5bb3 )

by Song

created 2020-06-15 13:17 UTC

Modal::display() A

↳ Parent: Modal

Complexity

Conditions	4
Paths	6

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	4
nc	6
nop	1
dl	0
loc	27
rs	9.488
c	0
b	0
f	0

<?php

namespace Encore\Admin\Grid\Displayers;

use Encore\Admin\Admin;
use Encore\Admin\Grid\Simple;
use Illuminate\Contracts\Support\Renderable;

class Modal extends AbstractDisplayer
{
    /**
     * @var string
     */
    protected $renderable;

    /**
     * @param int $multiple
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return string
     */
    protected function getLoadUrl()
    {
        $renderable = str_replace('\\', '_', $this->renderable);

        return route('admin.handle-renderable', compact('renderable'));
    }

    /**
     * @param \Closure|string $callback
     *
     * @return mixed|string
     */
    public function display($callback = null)
    {
        if (func_num_args() == 2) {
            list($title, $callback) = func_get_args();
        } elseif (func_num_args() == 1) {
            $title = $this->trans('title');
        }

        $html  = '';

        if ($async = is_subclass_of($callback, Renderable::class)) {

            $this->renderable = $callback;
        } else {
            $html = call_user_func_array($callback->bindTo($this->row), [$this->row]);
        }

        return Admin::component('admin::components.column-modal', [
            'url'     => $this->getLoadUrl(),
            'async'   => $async,
            'grid'    => is_subclass_of($callback, Simple::class),

            'title'   => $title,
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
            'html'    => $html,
            'key'     => $this->getKey(),
            'value'   => $this->value,
            'name'    => $this->getKey() . '-' . str_replace('.', '_', $this->getColumn()->getName()),
        ]);
    }
}


1			<?php
2
3			namespace Encore\Admin\Grid\Displayers;
4
5			use Encore\Admin\Admin;
6			use Encore\Admin\Grid\Simple;
7			use Illuminate\Contracts\Support\Renderable;
8
9			class Modal extends AbstractDisplayer
10			{
11			/**
12			* @var string
13			*/
14			protected $renderable;
15
16			/**
17			* @param int $multiple
			0 ignored issues – show Bug introduced 2020-05-26 11:37 UTC by Report Bug Copy Issue Report There is no parameter named `$multiple`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
18			*
19			* @return string
20			*/
21			protected function getLoadUrl()
22			{
23			$renderable = str_replace('\\', '_', $this->renderable);
24
25			return route('admin.handle-renderable', compact('renderable'));
26			}
27
28			/**
29			* @param \Closure\|string $callback
30			*
31			* @return mixed\|string
32			*/
33			public function display($callback = null)
34			{
35			if (func_num_args() == 2) {
36			list($title, $callback) = func_get_args();
37			} elseif (func_num_args() == 1) {
38			$title = $this->trans('title');
39			}
40
41			$html = '';
42
43			if ($async = is_subclass_of($callback, Renderable::class)) {
			0 ignored issues – show Bug introduced 2020-05-26 11:37 UTC by Report Bug Copy Issue Report Due to PHP Bug #53727, `is_subclass_of` might return inconsistent results on some PHP versions if `\Illuminate\Contracts\Support\Renderable::class` can be an interface. If so, you could instead use `ReflectionClass::implementsInterface`. Loading history...
44			$this->renderable = $callback;
45			} else {
46			$html = call_user_func_array($callback->bindTo($this->row), [$this->row]);
47			}
48
49			return Admin::component('admin::components.column-modal', [
50			'url' => $this->getLoadUrl(),
51			'async' => $async,
52			'grid' => is_subclass_of($callback, Simple::class),
			0 ignored issues – show Bug introduced 2020-06-15 13:19 UTC by Report Bug Copy Issue Report Due to PHP Bug #53727, `is_subclass_of` might return inconsistent results on some PHP versions if `\Encore\Admin\Grid\Simple::class` can be an interface. If so, you could instead use `ReflectionClass::implementsInterface`. Loading history...
53			'title' => $title,
			0 ignored issues – show Bug introduced 2020-06-15 13:19 UTC by Report Bug Copy Issue Report The variable `$title` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
54			'html' => $html,
55			'key' => $this->getKey(),
56			'value' => $this->value,
57			'name' => $this->getKey() . '-' . str_replace('.', '_', $this->getColumn()->getName()),
58			]);
59			}
60			}
61

z-song / laravel-admin

Push — master ( 8f0aef...6f5bb3 )

Modal::display() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like