Completed
Pull Request — master (#3215)
by Hiroyuki
02:22
created
src/Console/AdminCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
      */
57 57
     protected function listAdminCommands()
58 58
     {
59
-        $commands = collect(Artisan::all())->mapWithKeys(function ($command, $key) {
59
+        $commands = collect(Artisan::all())->mapWithKeys(function($command, $key) {
60 60
             if (Str::startsWith($key, 'admin:')) {
61 61
                 return [$key => $command];
62 62
             }
Please login to merge, or discard this patch.
src/Form/Tab.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
         $all = $fields->toArray();
71 71
 
72 72
         foreach ($this->form->rows as $row) {
73
-            $rowFields = array_map(function ($field) {
73
+            $rowFields = array_map(function($field) {
74 74
                 return $field['element'];
75 75
             }, $row->getFields());
76 76
 
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
     public function getTabs()
105 105
     {
106 106
         // If there is no active tab, then active the first.
107
-        if ($this->tabs->filter(function ($tab) {
107
+        if ($this->tabs->filter(function($tab) {
108 108
             return $tab['active'];
109 109
         })->isEmpty()) {
110 110
             $first = $this->tabs->first();
Please login to merge, or discard this patch.
src/Form.php 2 patches
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
      *
266 266
      * @param $id
267 267
      *
268
-     * @return mixed
268
+     * @return boolean
269 269
      */
270 270
     public function destroy($id)
271 271
     {
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
      *
370 370
      * @param array $data
371 371
      *
372
-     * @return mixed
372
+     * @return Response|null
373 373
      */
374 374
     protected function prepare($data = [])
375 375
     {
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
     /**
430 430
      * Call submitted callback.
431 431
      *
432
-     * @return mixed
432
+     * @return Response|null
433 433
      */
434 434
     protected function callSubmitted()
435 435
     {
@@ -443,7 +443,7 @@  discard block
 block discarded – undo
443 443
     /**
444 444
      * Call saving callback.
445 445
      *
446
-     * @return mixed
446
+     * @return Response|null
447 447
      */
448 448
     protected function callSaving()
449 449
     {
@@ -457,7 +457,7 @@  discard block
 block discarded – undo
457 457
     /**
458 458
      * Callback after saving a Model.
459 459
      *
460
-     * @return mixed|null
460
+     * @return Response|null
461 461
      */
462 462
     protected function callSaved()
463 463
     {
@@ -551,7 +551,7 @@  discard block
 block discarded – undo
551 551
     /**
552 552
      * Get RedirectResponse after update.
553 553
      *
554
-     * @param mixed $key
554
+     * @param integer $key
555 555
      *
556 556
      * @return \Illuminate\Http\RedirectResponse
557 557
      */
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
      */
292 292
     public function destroy($id)
293 293
     {
294
-        collect(explode(',', $id))->filter()->each(function ($id) {
294
+        collect(explode(',', $id))->filter()->each(function($id) {
295 295
             $builder = $this->model()->newQuery();
296 296
 
297 297
             if ($this->isSoftDeletes) {
@@ -329,9 +329,9 @@  discard block
 block discarded – undo
329 329
 
330 330
         $data = $model->toArray();
331 331
 
332
-        $this->builder->fields()->filter(function ($field) {
332
+        $this->builder->fields()->filter(function($field) {
333 333
             return $field instanceof Field\File;
334
-        })->each(function (Field\File $file) use ($data) {
334
+        })->each(function(Field\File $file) use ($data) {
335 335
             $file->setOriginal($data);
336 336
 
337 337
             $file->destroy();
@@ -356,7 +356,7 @@  discard block
 block discarded – undo
356 356
             return $response;
357 357
         }
358 358
 
359
-        DB::transaction(function () {
359
+        DB::transaction(function() {
360 360
             $inserts = $this->prepareInsert($this->updates);
361 361
 
362 362
             foreach ($inserts as $column => $value) {
@@ -559,7 +559,7 @@  discard block
 block discarded – undo
559 559
             return $response;
560 560
         }
561 561
 
562
-        DB::transaction(function () {
562
+        DB::transaction(function() {
563 563
             $updates = $this->prepareUpdate($this->updates);
564 564
 
565 565
             foreach ($updates as $column => $value) {
@@ -1028,7 +1028,7 @@  discard block
 block discarded – undo
1028 1028
     protected function getFieldByColumn($column)
1029 1029
     {
1030 1030
         return $this->builder->fields()->first(
1031
-            function (Field $field) use ($column) {
1031
+            function(Field $field) use ($column) {
1032 1032
                 if (is_array($field->column())) {
1033 1033
                     return in_array($column, $field->column());
1034 1034
                 }
@@ -1049,7 +1049,7 @@  discard block
 block discarded – undo
1049 1049
 
1050 1050
         $values = $this->model->toArray();
1051 1051
 
1052
-        $this->builder->fields()->each(function (Field $field) use ($values) {
1052
+        $this->builder->fields()->each(function(Field $field) use ($values) {
1053 1053
             $field->setOriginal($values);
1054 1054
         });
1055 1055
     }
@@ -1079,7 +1079,7 @@  discard block
 block discarded – undo
1079 1079
 
1080 1080
         $data = $this->model->toArray();
1081 1081
 
1082
-        $this->builder->fields()->each(function (Field $field) use ($data) {
1082
+        $this->builder->fields()->each(function(Field $field) use ($data) {
1083 1083
             if (!in_array($field->column(), $this->ignored)) {
1084 1084
                 $field->fill($data);
1085 1085
             }
@@ -1202,7 +1202,7 @@  discard block
 block discarded – undo
1202 1202
      */
1203 1203
     public function setWidth($fieldWidth = 8, $labelWidth = 2)
1204 1204
     {
1205
-        $this->builder()->fields()->each(function ($field) use ($fieldWidth, $labelWidth) {
1205
+        $this->builder()->fields()->each(function($field) use ($fieldWidth, $labelWidth) {
1206 1206
             /* @var Field $field  */
1207 1207
             $field->setWidth($fieldWidth, $labelWidth);
1208 1208
         });
Please login to merge, or discard this patch.
src/Grid/Filter/Layout/Column.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
      */
74 74
     public function removeFilterByID($id)
75 75
     {
76
-        $this->filters = $this->filters->reject(function (AbstractFilter $filter) use ($id) {
76
+        $this->filters = $this->filters->reject(function(AbstractFilter $filter) use ($id) {
77 77
             return $filter->getId() == $id;
78 78
         });
79 79
     }
Please login to merge, or discard this patch.
src/Middleware/LogOperation.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@
 block discarded – undo
66 66
             return true;
67 67
         }
68 68
 
69
-        return $allowedMethods->map(function ($method) {
69
+        return $allowedMethods->map(function($method) {
70 70
             return strtoupper($method);
71 71
         })->contains($method);
72 72
     }
Please login to merge, or discard this patch.
src/Grid/Displayers/SwitchDisplay.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
         if ($keys->isEmpty()) {
31 31
             $key = $name;
32 32
         } else {
33
-            $key = $keys->shift().$keys->reduce(function ($carry, $val) {
33
+            $key = $keys->shift().$keys->reduce(function($carry, $val) {
34 34
                 return $carry."[$val]";
35 35
             });
36 36
         }
Please login to merge, or discard this patch.
src/Grid/Displayers/SwitchGroup.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
         if ($keys->isEmpty()) {
31 31
             $key = $name;
32 32
         } else {
33
-            $key = $keys->shift().$keys->reduce(function ($carry, $val) {
33
+            $key = $keys->shift().$keys->reduce(function($carry, $val) {
34 34
                 return $carry."[$val]";
35 35
             });
36 36
         }
Please login to merge, or discard this patch.
src/Grid/Column.php 2 patches
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
     /**
126 126
      * Extend column displayer.
127 127
      *
128
-     * @param $name
128
+     * @param string $name
129 129
      * @param $displayer
130 130
      */
131 131
     public static function extend($name, $displayer)
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
     /**
160 160
      * Set model for column.
161 161
      *
162
-     * @param $model
162
+     * @param Model $model
163 163
      */
164 164
     public function setModel($model)
165 165
     {
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
     /**
220 220
      * Get name of this column.
221 221
      *
222
-     * @return mixed
222
+     * @return string
223 223
      */
224 224
     public function getName()
225 225
     {
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
     /**
230 230
      * Format label.
231 231
      *
232
-     * @param $label
232
+     * @param string $label
233 233
      *
234 234
      * @return mixed
235 235
      */
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
     /**
244 244
      * Get label of the column.
245 245
      *
246
-     * @return mixed
246
+     * @return string
247 247
      */
248 248
     public function getLabel()
249 249
     {
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
      * Display using display abstract.
307 307
      *
308 308
      * @param string $abstract
309
-     * @param array  $arguments
309
+     * @param Closure[]  $arguments
310 310
      *
311 311
      * @return Column
312 312
      */
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 
317 317
         $column = $this;
318 318
 
319
-        return $this->display(function ($value) use ($grid, $column, $abstract, $arguments) {
319
+        return $this->display(function($value) use ($grid, $column, $abstract, $arguments) {
320 320
             /** @var AbstractDisplayer $displayer */
321 321
             $displayer = new $abstract($value, $grid, $column, $this);
322 322
 
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
      */
335 335
     public function using(array $values, $default = null)
336 336
     {
337
-        return $this->display(function ($value) use ($values, $default) {
337
+        return $this->display(function($value) use ($values, $default) {
338 338
             if (is_null($value)) {
339 339
                 return $default;
340 340
             }
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
      */
353 353
     public function view($view)
354 354
     {
355
-        return $this->display(function ($value) use ($view) {
355
+        return $this->display(function($value) use ($view) {
356 356
             $model = $this;
357 357
 
358 358
             return view($view, compact('model', 'value'))->render();
@@ -475,7 +475,7 @@  discard block
 block discarded – undo
475 475
         $grid = $this->grid;
476 476
         $column = $this;
477 477
 
478
-        $this->display(function ($value) use ($grid, $column, $class) {
478
+        $this->display(function($value) use ($grid, $column, $class) {
479 479
             /** @var AbstractDisplayer $definition */
480 480
             $definition = new $class($value, $grid, $column, $this);
481 481
 
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
     protected function htmlEntityEncode($item)
494 494
     {
495 495
         if (is_array($item)) {
496
-            array_walk_recursive($item, function (&$value) {
496
+            array_walk_recursive($item, function(&$value) {
497 497
                 $value = htmlentities($value);
498 498
             });
499 499
         } else {
@@ -573,7 +573,7 @@  discard block
 block discarded – undo
573 573
      */
574 574
     protected function callSupportDisplayer($abstract, $arguments)
575 575
     {
576
-        return $this->display(function ($value) use ($abstract, $arguments) {
576
+        return $this->display(function($value) use ($abstract, $arguments) {
577 577
             if (is_array($value) || $value instanceof Arrayable) {
578 578
                 return call_user_func_array([collect($value), $abstract], $arguments);
579 579
             }
@@ -597,7 +597,7 @@  discard block
 block discarded – undo
597 597
     protected function callBuiltinDisplayer($abstract, $arguments)
598 598
     {
599 599
         if ($abstract instanceof Closure) {
600
-            return $this->display(function ($value) use ($abstract, $arguments) {
600
+            return $this->display(function($value) use ($abstract, $arguments) {
601 601
                 return $abstract->call($this, ...array_merge([$value], $arguments));
602 602
             });
603 603
         }
@@ -606,7 +606,7 @@  discard block
 block discarded – undo
606 606
             $grid = $this->grid;
607 607
             $column = $this;
608 608
 
609
-            return $this->display(function ($value) use ($abstract, $grid, $column, $arguments) {
609
+            return $this->display(function($value) use ($abstract, $grid, $column, $arguments) {
610 610
                 /** @var AbstractDisplayer $displayer */
611 611
                 $displayer = new $abstract($value, $grid, $column, $this);
612 612
 
Please login to merge, or discard this patch.
src/Controllers/MenuController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,10 +26,10 @@  discard block
 block discarded – undo
26 26
         return $content
27 27
             ->header(trans('admin.menu'))
28 28
             ->description(trans('admin.list'))
29
-            ->row(function (Row $row) {
29
+            ->row(function(Row $row) {
30 30
                 $row->column(6, $this->treeView()->render());
31 31
 
32
-                $row->column(6, function (Column $column) {
32
+                $row->column(6, function(Column $column) {
33 33
                     $form = new \Encore\Admin\Widgets\Form();
34 34
                     $form->action(admin_base_path('auth/menu'));
35 35
 
@@ -71,10 +71,10 @@  discard block
 block discarded – undo
71 71
     {
72 72
         $menuModel = config('admin.database.menu_model');
73 73
 
74
-        return $menuModel::tree(function (Tree $tree) {
74
+        return $menuModel::tree(function(Tree $tree) {
75 75
             $tree->disableCreate();
76 76
 
77
-            $tree->branch(function ($branch) {
77
+            $tree->branch(function($branch) {
78 78
                 $payload = "<i class='fa {$branch['icon']}'></i>&nbsp;<strong>{$branch['title']}</strong>";
79 79
 
80 80
                 if (!isset($branch['children'])) {
Please login to merge, or discard this patch.