HasPermissions - Code Metrics - Inspection of "[Refactor]" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c827fa...700be2 )

by Song

created 2018-08-29 15:43 UTC

HasPermissions A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	112
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	112
rs	10
c	0
b	0
f	0
wmc	12
lcom	1
cbo	0

8 Methods

Rating	Name	Size	Complexity
A	allPermissions()	4	1
A	can()	12	3
A	cannot()	4	1
A	isAdministrator()	4	1
A	isRole()	4	1
A	inRoles()	4	1
A	visible()	10	3
A	boot()	10	1

<?php

namespace Encore\Admin\Auth\Database;

use Illuminate\Support\Collection;

trait HasPermissions
{
    /**
     * Get all permissions of user.
     *
     * @return mixed
     */
    public function allPermissions() : Collection
    {
        return $this->roles()->with('permissions')->get()->pluck('permissions')->flatten()->merge($this->permissions);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Check if user has permission.
     *
     * @param $permission
     *
     * @return bool
     */
    public function can(string $permission) : bool
    {
        if ($this->isAdministrator()) {
            return true;
        }

        if ($this->permissions->pluck('slug')->contains($permission)) {
            return true;
        }

        return $this->roles->pluck('permissions')->flatten()->pluck('slug')->contains($permission);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Check if user has no permission.
     *
     * @param $permission
     *
     * @return bool
     */
    public function cannot(string $permission) : bool
    {
        return !$this->can($permission);
    }

    /**
     * Check if user is administrator.
     *
     * @return mixed
     */
    public function isAdministrator() : bool
    {
        return $this->isRole('administrator');
    }

    /**
     * Check if user is $role.
     *
     * @param string $role
     *
     * @return mixed
     */
    public function isRole(string $role) : bool
    {
        return $this->roles->pluck('slug')->contains($role);
    }

    /**
     * Check if user in $roles.
     *
     * @param array $roles
     *
     * @return mixed
     */
    public function inRoles(array $roles = []) : bool
    {
        return $this->roles->pluck('slug')->intersect($roles)->isNotEmpty();
    }

    /**
     * If visible for roles.
     *
     * @param $roles
     *
     * @return bool
     */
    public function visible(array $roles = []) : bool
    {
        if (empty($roles)) {
            return true;
        }

        $roles = array_column($roles, 'slug');

        return $this->inRoles($roles) || $this->isAdministrator();
    }

    /**
     * Detach models from the relationship.
     *
     * @return void
     */
    protected static function boot()
    {
        parent::boot();

        static::deleting(function ($model) {
            $model->roles()->detach();

            $model->permissions()->detach();
        });
    }
}


1			<?php
2
3			namespace Encore\Admin\Auth\Database;
4
5			use Illuminate\Support\Collection;
6
7			trait HasPermissions
8			{
9			/**
10			* Get all permissions of user.
11			*
12			* @return mixed
13			*/
14			public function allPermissions() : Collection
15			{
16			return $this->roles()->with('permissions')->get()->pluck('permissions')->flatten()->merge($this->permissions);
			0 ignored issues – show Bug introduced 2017-09-19 15:53 UTC by Report Bug Copy Issue Report The property `permissions` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2018-08-29 15:47 UTC by Report Bug Copy Issue Report It seems like `roles()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17			}
18
19			/**
20			* Check if user has permission.
21			*
22			* @param $permission
23			*
24			* @return bool
25			*/
26			public function can(string $permission) : bool
27			{
28			if ($this->isAdministrator()) {
29			return true;
30			}
31
32			if ($this->permissions->pluck('slug')->contains($permission)) {
33			return true;
34			}
35
36			return $this->roles->pluck('permissions')->flatten()->pluck('slug')->contains($permission);
			0 ignored issues – show Bug introduced 2017-09-19 15:53 UTC by Report Bug Copy Issue Report The property `roles` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
37			}
38
39			/**
40			* Check if user has no permission.
41			*
42			* @param $permission
43			*
44			* @return bool
45			*/
46			public function cannot(string $permission) : bool
47			{
48			return !$this->can($permission);
49			}
50
51			/**
52			* Check if user is administrator.
53			*
54			* @return mixed
55			*/
56			public function isAdministrator() : bool
57			{
58			return $this->isRole('administrator');
59			}
60
61			/**
62			* Check if user is $role.
63			*
64			* @param string $role
65			*
66			* @return mixed
67			*/
68			public function isRole(string $role) : bool
69			{
70			return $this->roles->pluck('slug')->contains($role);
71			}
72
73			/**
74			* Check if user in $roles.
75			*
76			* @param array $roles
77			*
78			* @return mixed
79			*/
80			public function inRoles(array $roles = []) : bool
81			{
82			return $this->roles->pluck('slug')->intersect($roles)->isNotEmpty();
83			}
84
85			/**
86			* If visible for roles.
87			*
88			* @param $roles
89			*
90			* @return bool
91			*/
92			public function visible(array $roles = []) : bool
93			{
94			if (empty($roles)) {
95			return true;
96			}
97
98			$roles = array_column($roles, 'slug');
99
100			return $this->inRoles($roles) \|\| $this->isAdministrator();
101			}
102
103			/**
104			* Detach models from the relationship.
105			*
106			* @return void
107			*/
108			protected static function boot()
109			{
110			parent::boot();
111
112			static::deleting(function ($model) {
113			$model->roles()->detach();
114
115			$model->permissions()->detach();
116			});
117			}
118			}
119

z-song / laravel-admin

Push — master ( c827fa...700be2 )

HasPermissions A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

8 Methods

Duplication Side-by-Side

Filter issues like