CanDoubleClick::enableDblClick() - Code Metrics - Inspection of "Fix master" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4824)

unknown

created 2020-08-05 06:21 UTC

CanDoubleClick::enableDblClick() A

↳ Parent: CanDoubleClick

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	12
rs	9.8666
c	0
b	0
f	0

<?php

namespace Encore\Admin\Grid\Concerns;

use Encore\Admin\Admin;

trait CanDoubleClick
{
    /**
     * Double-click grid row to jump to the edit page.
     *
     * @return $this
     */
    public function enableDblClick()
    {
        $script = <<<SCRIPT
$('body').on('dblclick', 'table#{$this->tableID}>tbody>tr', function(e) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
    var url = "{$this->resource()}/"+$(this).data('key')+"/edit";
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    $.admin.redirect(url);
});
SCRIPT;
        Admin::script($script);

        return $this;
    }
}


1			<?php
2
3			namespace Encore\Admin\Grid\Concerns;
4
5			use Encore\Admin\Admin;
6
7			trait CanDoubleClick
8			{
9			/**
10			* Double-click grid row to jump to the edit page.
11			*
12			* @return $this
13			*/
14			public function enableDblClick()
15			{
16			$script = <<<SCRIPT
17			$('body').on('dblclick', 'table#{$this->tableID}>tbody>tr', function(e) {
			0 ignored issues – show Bug introduced 2020-08-05 06:23 UTC by Report Bug Copy Issue Report The property `tableID` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18			var url = "{$this->resource()}/"+$(this).data('key')+"/edit";
			0 ignored issues – show Bug introduced 2020-08-05 06:23 UTC by Report Bug Copy Issue Report It seems like `resource()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
19			$.admin.redirect(url);
20			});
21			SCRIPT;
22			Admin::script($script);
23
24			return $this;
25			}
26			}
27

z-song / laravel-admin

Pull Request — master (#4824)

CanDoubleClick::enableDblClick() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like