Completed
Pull Request — master (#3469)
by jxlwqq
02:17
created
src/Grid/Tools.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
      */
85 85
     public function disableFilterButton(bool $disable = true)
86 86
     {
87
-        $this->tools = $this->tools->map(function ($tool) use ($disable) {
87
+        $this->tools = $this->tools->map(function($tool) use ($disable) {
88 88
             if ($tool instanceof FilterButton) {
89 89
                 return $tool->disable($disable);
90 90
             }
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
      */
113 113
     public function disableBatchActions(bool $disable = true)
114 114
     {
115
-        $this->tools = $this->tools->map(function ($tool) use ($disable) {
115
+        $this->tools = $this->tools->map(function($tool) use ($disable) {
116 116
             if ($tool instanceof BatchActions) {
117 117
                 return $tool->disable($disable);
118 118
             }
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
      */
127 127
     public function batch(\Closure $closure)
128 128
     {
129
-        call_user_func($closure, $this->tools->first(function ($tool) {
129
+        call_user_func($closure, $this->tools->first(function($tool) {
130 130
             return $tool instanceof BatchActions;
131 131
         }));
132 132
     }
@@ -138,7 +138,7 @@  discard block
 block discarded – undo
138 138
      */
139 139
     public function render()
140 140
     {
141
-        return $this->tools->map(function ($tool) {
141
+        return $this->tools->map(function($tool) {
142 142
             if ($tool instanceof AbstractTool) {
143 143
                 if (!$tool->allowed()) {
144 144
                     return '';
Please login to merge, or discard this patch.
src/Widgets/Navbar.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
             $this->right(new RefreshButton());
76 76
         }
77 77
 
78
-        return $this->elements[$part]->map(function ($element) {
78
+        return $this->elements[$part]->map(function($element) {
79 79
             if ($element instanceof Htmlable) {
80 80
                 return $element->toHtml();
81 81
             }
Please login to merge, or discard this patch.
src/Grid.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
      * Get or set option for grid.
270 270
      *
271 271
      * @param string $key
272
-     * @param mixed  $value
272
+     * @param boolean  $value
273 273
      *
274 274
      * @return $this|mixed
275 275
      */
@@ -454,7 +454,7 @@  discard block
 block discarded – undo
454 454
     /**
455 455
      * Get the grid paginator.
456 456
      *
457
-     * @return mixed
457
+     * @return Tools\Paginator
458 458
      */
459 459
     public function paginator()
460 460
     {
@@ -506,7 +506,7 @@  discard block
 block discarded – undo
506 506
     /**
507 507
      * Set grid action callback.
508 508
      *
509
-     * @param Closure|string $actions
509
+     * @param Closure $actions
510 510
      *
511 511
      * @return $this
512 512
      */
@@ -838,7 +838,7 @@  discard block
 block discarded – undo
838 838
     /**
839 839
      * Dynamically add columns to the grid view.
840 840
      *
841
-     * @param $method
841
+     * @param string $method
842 842
      * @param $arguments
843 843
      *
844 844
      * @return Column
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
         $column = new Column($column, $label);
359 359
         $column->setGrid($this);
360 360
 
361
-        return tap($column, function ($value) {
361
+        return tap($column, function($value) {
362 362
             $this->columns->push($value);
363 363
         });
364 364
     }
@@ -422,7 +422,7 @@  discard block
 block discarded – undo
422 422
         $column = new Column($column, $label);
423 423
         $column->setGrid($this);
424 424
 
425
-        return tap($column, function ($value) {
425
+        return tap($column, function($value) {
426 426
             $this->columns->prepend($value);
427 427
         });
428 428
     }
@@ -587,7 +587,7 @@  discard block
 block discarded – undo
587 587
 
588 588
         $data = $collection->toArray();
589 589
 
590
-        $this->columns->map(function (Column $column) use (&$data) {
590
+        $this->columns->map(function(Column $column) use (&$data) {
591 591
             $data = $column->fill($data);
592 592
 
593 593
             $this->columnNames[] = $column->getName();
@@ -607,7 +607,7 @@  discard block
 block discarded – undo
607 607
      */
608 608
     protected function buildRows(array $data)
609 609
     {
610
-        $this->rows = collect($data)->map(function ($model, $number) {
610
+        $this->rows = collect($data)->map(function($model, $number) {
611 611
             return new Row($number, $model);
612 612
         });
613 613
 
Please login to merge, or discard this patch.
src/helpers.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
      * @param array  $replace
162 162
      * @param string $locale
163 163
      *
164
-     * @return \Illuminate\Contracts\Translation\Translator|string|array|null
164
+     * @return string|null
165 165
      */
166 166
     function admin_trans($key = null, $replace = [], $locale = null)
167 167
     {
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
      * Delete from array by value.
182 182
      *
183 183
      * @param array $array
184
-     * @param mixed $value
184
+     * @param string $value
185 185
      */
186 186
     function array_delete(&$array, $value)
187 187
     {
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -250,15 +250,15 @@
 block discarded – undo
250 250
     function file_size($bytes)
251 251
     {
252 252
         if ($bytes >= 1073741824) {
253
-            $bytes = number_format($bytes / 1073741824, 2) . ' GB';
253
+            $bytes = number_format($bytes / 1073741824, 2).' GB';
254 254
         } elseif ($bytes >= 1048576) {
255
-            $bytes = number_format($bytes / 1048576, 2) . ' MB';
255
+            $bytes = number_format($bytes / 1048576, 2).' MB';
256 256
         } elseif ($bytes >= 1024) {
257
-            $bytes = number_format($bytes / 1024, 2) . ' KB';
257
+            $bytes = number_format($bytes / 1024, 2).' KB';
258 258
         } elseif ($bytes > 1) {
259
-            $bytes = $bytes . ' bytes';
259
+            $bytes = $bytes.' bytes';
260 260
         } elseif ($bytes == 1) {
261
-            $bytes = $bytes . ' byte';
261
+            $bytes = $bytes.' byte';
262 262
         } else {
263 263
             $bytes = '0 bytes';
264 264
         }
Please login to merge, or discard this patch.
src/Grid/Concerns/HasFilter.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -54,7 +54,7 @@
 block discarded – undo
54 54
      *
55 55
      * @param bool $toArray
56 56
      *
57
-     * @return array|Collection|mixed
57
+     * @return Collection
58 58
      */
59 59
     public function applyFilter($toArray = true)
60 60
     {
Please login to merge, or discard this patch.
src/Grid/Tools/QuickSearch.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
         Arr::forget($query, HasQuickSearch::$searchKey);
23 23
 
24 24
         $vars = [
25
-            'action' => request()->url() . '?' . http_build_query($query),
25
+            'action' => request()->url().'?'.http_build_query($query),
26 26
             'key'    => HasQuickSearch::$searchKey,
27 27
             'value'  => request(HasQuickSearch::$searchKey),
28 28
         ];
Please login to merge, or discard this patch.
src/Grid/Concerns/HasQuickSearch.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
         if (is_array($this->search)) {
68 68
             foreach ($this->search as $column) {
69
-                $this->addWhereLikeBinding($column, true, '%' . $query . '%');
69
+                $this->addWhereLikeBinding($column, true, '%'.$query.'%');
70 70
             }
71 71
         } elseif (is_null($this->search)) {
72 72
             $this->addWhereBindings($query);
@@ -85,7 +85,7 @@  discard block
 block discarded – undo
85 85
         foreach ($this->parseQueryBindings($queries) as list($column, $condition, $or)) {
86 86
 
87 87
             if (preg_match('/(?<not>!?)\((?<values>.+)\)/', $condition, $match) !== 0) {
88
-                $this->addWhereInBinding($column, $or, (bool)$match['not'], $match['values']);
88
+                $this->addWhereInBinding($column, $or, (bool) $match['not'], $match['values']);
89 89
                 continue;
90 90
             }
91 91
 
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
      */
125 125
     protected function parseQueryBindings(array $queries)
126 126
     {
127
-        $columnMap = $this->columns->mapWithKeys(function (Column $column) {
127
+        $columnMap = $this->columns->mapWithKeys(function(Column $column) {
128 128
 
129 129
             $label = $column->getLabel();
130 130
             $name  = $column->getName();
@@ -132,7 +132,7 @@  discard block
 block discarded – undo
132 132
             return [$label => $name, $name => $name];
133 133
         });
134 134
 
135
-        return collect($queries)->map(function ($query) use ($columnMap) {
135
+        return collect($queries)->map(function($query) use ($columnMap) {
136 136
             $segments = explode(':', $query, 2);
137 137
 
138 138
             if (count($segments) != 2) {
@@ -181,7 +181,7 @@  discard block
 block discarded – undo
181 181
      */
182 182
     protected function addWhereDatetimeBinding(string $column, bool $or, string $function, string $value)
183 183
     {
184
-        $method = ($or ? 'orWhere' : 'where') . ucfirst($function);
184
+        $method = ($or ? 'orWhere' : 'where').ucfirst($function);
185 185
 
186 186
         $this->model()->$method($column, $value);
187 187
     }
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
 
207 207
         $where = $or ? 'orWhere' : 'where';
208 208
 
209
-        $method = $where . ($not ? 'NotIn' : 'In');
209
+        $method = $where.($not ? 'NotIn' : 'In');
210 210
 
211 211
         $this->model()->$method($column, $values);
212 212
     }
Please login to merge, or discard this patch.