ContainsForms::buildTabbedForms() - Code Metrics - Inspection of "Apply fixes from StyleCI" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3476)

by Song

created 2019-06-06 16:45 UTC

ContainsForms::buildTabbedForms() B

↳ Parent: ContainsForms

Complexity

Conditions	6
Paths	16

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	6
nc	16
nop	2
dl	0
loc	26
rs	8.8817
c	0
b	0
f	0

<?php

namespace Encore\Admin\Widgets;

trait ContainsForms
{
    protected $activeName = 'active';

    public static function forms($forms, $active = null)
    {
        $tab = new static();

        return $tab->buildTabbedForms($forms, $active);
    }

    protected function buildTabbedForms($forms, $active = null)
    {
        $active = $active ?: request($this->activeName);

        if (!isset($forms[$active])) {
            $active = key($forms);
        }

        foreach ($forms as $name => $class) {
            if (!is_subclass_of($class, Form::class)) {

                admin_error("Class [{$class}] must be a sub-class of [Encore\Admin\Widgets\Form].");
                continue;
            }

            /** @var Form $form */
            $form = app()->make($class);

            if ($name == $active) {
                $this->add($form->title, $form->unbox(), true);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            } else {
                $this->addLink($form->title, $this->getTabUrl($name));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            }
        }

        return $this;
    }

    protected function getTabUrl($name)
    {
        $query = [$this->activeName => $name];

        return request()->fullUrlWithQuery($query);
    }
}


1			<?php
2
3			namespace Encore\Admin\Widgets;
4
5			trait ContainsForms
6			{
7			protected $activeName = 'active';
8
9			public static function forms($forms, $active = null)
10			{
11			$tab = new static();
12
13			return $tab->buildTabbedForms($forms, $active);
14			}
15
16			protected function buildTabbedForms($forms, $active = null)
17			{
18			$active = $active ?: request($this->activeName);
19
20			if (!isset($forms[$active])) {
21			$active = key($forms);
22			}
23
24			foreach ($forms as $name => $class) {
25			if (!is_subclass_of($class, Form::class)) {
			0 ignored issues – show Bug introduced 2019-06-06 16:48 UTC by Report Bug Copy Issue Report Due to PHP Bug #53727, `is_subclass_of` might return inconsistent results on some PHP versions if `\Encore\Admin\Widgets\Form::class` can be an interface. If so, you could instead use `ReflectionClass::implementsInterface`. Loading history...
26			admin_error("Class [{$class}] must be a sub-class of [Encore\Admin\Widgets\Form].");
27			continue;
28			}
29
30			/** @var Form $form */
31			$form = app()->make($class);
32
33			if ($name == $active) {
34			$this->add($form->title, $form->unbox(), true);
			0 ignored issues – show Bug introduced 2019-06-06 16:48 UTC by Report Bug Copy Issue Report It seems like `add()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
35			} else {
36			$this->addLink($form->title, $this->getTabUrl($name));
			0 ignored issues – show Bug introduced 2019-06-06 16:48 UTC by Report Bug Copy Issue Report It seems like `addLink()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
37			}
38			}
39
40			return $this;
41			}
42
43			protected function getTabUrl($name)
44			{
45			$query = [$this->activeName => $name];
46
47			return request()->fullUrlWithQuery($query);
48			}
49			}
50

z-song / laravel-admin

Pull Request — master (#3476)

ContainsForms::buildTabbedForms() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like