Completed
Pull Request — master (#3396)
by Edwin
04:02
created
src/Auth/Database/Menu.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@
 block discarded – undo
78 78
     {
79 79
         static::treeBoot();
80 80
 
81
-        static::deleting(function ($model) {
81
+        static::deleting(function($model) {
82 82
             $model->roles()->detach();
83 83
         });
84 84
     }
Please login to merge, or discard this patch.
src/Show.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -317,7 +317,7 @@
 block discarded – undo
317 317
      * @param string $method
318 318
      * @param array  $arguments
319 319
      *
320
-     * @return bool|mixed
320
+     * @return Field
321 321
      */
322 322
     public function __call($method, $arguments = [])
323 323
     {
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 
223 223
         $this->overwriteExistingField($name);
224 224
 
225
-        return tap($field, function ($field) {
225
+        return tap($field, function($field) {
226 226
             $this->fields->push($field);
227 227
         });
228 228
     }
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
 
245 245
         $this->overwriteExistingRelation($name);
246 246
 
247
-        return tap($relation, function ($relation) {
247
+        return tap($relation, function($relation) {
248 248
             $this->relations->push($relation);
249 249
         });
250 250
     }
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
         }
262 262
 
263 263
         $this->fields = $this->fields->filter(
264
-            function (Field $field) use ($name) {
264
+            function(Field $field) use ($name) {
265 265
                 return $field->getName() != $name;
266 266
             }
267 267
         );
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
         }
280 280
 
281 281
         $this->relations = $this->relations->filter(
282
-            function (Relation $relation) use ($name) {
282
+            function(Relation $relation) use ($name) {
283 283
                 return $relation->getName() != $name;
284 284
             }
285 285
         );
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
      */
337 337
     public function setWidth($fieldWidth = 8, $labelWidth = 2)
338 338
     {
339
-        collect($this->fields)->each(function ($field) use ($fieldWidth, $labelWidth) {
339
+        collect($this->fields)->each(function($field) use ($fieldWidth, $labelWidth) {
340 340
             $field->each->setWidth($fieldWidth, $labelWidth);
341 341
         });
342 342
 
Please login to merge, or discard this patch.
src/Show/Field.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     /**
89 89
      * Get name of this column.
90 90
      *
91
-     * @return mixed
91
+     * @return string
92 92
      */
93 93
     public function getName()
94 94
     {
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     /**
113 113
      * Get label of the column.
114 114
      *
115
-     * @return mixed
115
+     * @return string
116 116
      */
117 117
     public function getLabel()
118 118
     {
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -191,7 +191,7 @@  discard block
 block discarded – undo
191 191
      */
192 192
     public function using(array $values, $default = null)
193 193
     {
194
-        return $this->as(function ($value) use ($values, $default) {
194
+        return $this->as(function($value) use ($values, $default) {
195 195
             if (is_null($value)) {
196 196
                 return $default;
197 197
             }
@@ -211,8 +211,8 @@  discard block
 block discarded – undo
211 211
      */
212 212
     public function image($server = '', $width = 200, $height = 200)
213 213
     {
214
-        return $this->unescape()->as(function ($images) use ($server, $width, $height) {
215
-            return collect($images)->map(function ($path) use ($server, $width, $height) {
214
+        return $this->unescape()->as(function($images) use ($server, $width, $height) {
215
+            return collect($images)->map(function($path) use ($server, $width, $height) {
216 216
                 if (empty($path)) {
217 217
                     return '';
218 218
                 }
@@ -247,8 +247,8 @@  discard block
 block discarded – undo
247 247
      */
248 248
     public function carousel($width = 300, $height = 200, $server = '')
249 249
     {
250
-        return $this->unescape()->as(function ($images) use ($server, $width, $height) {
251
-            $items = collect($images)->map(function ($path) use ($server, $width, $height) {
250
+        return $this->unescape()->as(function($images) use ($server, $width, $height) {
251
+            $items = collect($images)->map(function($path) use ($server, $width, $height) {
252 252
                 if (empty($path)) {
253 253
                     return '';
254 254
                 }
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
     {
289 289
         $field = $this;
290 290
 
291
-        return $this->unescape()->as(function ($path) use ($server, $download, $field) {
291
+        return $this->unescape()->as(function($path) use ($server, $download, $field) {
292 292
             $name = basename($path);
293 293
 
294 294
             $field->border = false;
@@ -340,7 +340,7 @@  discard block
 block discarded – undo
340 340
      */
341 341
     public function link($href = '', $target = '_blank')
342 342
     {
343
-        return $this->unescape()->as(function ($link) use ($href, $target) {
343
+        return $this->unescape()->as(function($link) use ($href, $target) {
344 344
             $href = $href ?: $link;
345 345
 
346 346
             return "<a href='$href' target='{$target}'>{$link}</a>";
@@ -356,12 +356,12 @@  discard block
 block discarded – undo
356 356
      */
357 357
     public function label($style = 'success')
358 358
     {
359
-        return $this->unescape()->as(function ($value) use ($style) {
359
+        return $this->unescape()->as(function($value) use ($style) {
360 360
             if ($value instanceof Arrayable) {
361 361
                 $value = $value->toArray();
362 362
             }
363 363
 
364
-            return collect((array) $value)->map(function ($name) use ($style) {
364
+            return collect((array) $value)->map(function($name) use ($style) {
365 365
                 return "<span class='label label-{$style}'>$name</span>";
366 366
             })->implode('&nbsp;');
367 367
         });
@@ -376,12 +376,12 @@  discard block
 block discarded – undo
376 376
      */
377 377
     public function badge($style = 'blue')
378 378
     {
379
-        return $this->unescape()->as(function ($value) use ($style) {
379
+        return $this->unescape()->as(function($value) use ($style) {
380 380
             if ($value instanceof Arrayable) {
381 381
                 $value = $value->toArray();
382 382
             }
383 383
 
384
-            return collect((array) $value)->map(function ($name) use ($style) {
384
+            return collect((array) $value)->map(function($name) use ($style) {
385 385
                 return "<span class='badge bg-{$style}'>$name</span>";
386 386
             })->implode('&nbsp;');
387 387
         });
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
     {
397 397
         $field = $this;
398 398
 
399
-        return $this->unescape()->as(function ($value) use ($field) {
399
+        return $this->unescape()->as(function($value) use ($field) {
400 400
             $content = json_decode($value, true);
401 401
 
402 402
             if (json_last_error() == 0) {
@@ -543,7 +543,7 @@  discard block
 block discarded – undo
543 543
 
544 544
         $field = $this;
545 545
 
546
-        return $this->as(function ($value) use ($extend, $field, $arguments) {
546
+        return $this->as(function($value) use ($extend, $field, $arguments) {
547 547
             if (!$extend->border) {
548 548
                 $field->border = false;
549 549
             }
@@ -602,7 +602,7 @@  discard block
 block discarded – undo
602 602
     public function render()
603 603
     {
604 604
         if ($this->showAs->isNotEmpty()) {
605
-            $this->showAs->each(function ($callable) {
605
+            $this->showAs->each(function($callable) {
606 606
                 $this->value = $callable->call(
607 607
                     $this->parent->getModel(),
608 608
                     $this->value
Please login to merge, or discard this patch.
src/Show/Panel.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@
 block discarded – undo
138 138
     /**
139 139
      * Fill fields to panel.
140 140
      *
141
-     * @param []Field $fields
141
+     * @param Collection $fields
142 142
      *
143 143
      * @return $this
144 144
      */
Please login to merge, or discard this patch.
src/Grid/Tools/BatchActions.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
     /**
53 53
      * Add a batch action.
54 54
      *
55
-     * @param $title
55
+     * @param BatchDelete $title
56 56
      * @param BatchAction|null $action
57 57
      *
58 58
      * @return $this
Please login to merge, or discard this patch.
src/Grid/Filter/Scope.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
      */
56 56
     public function condition()
57 57
     {
58
-        return $this->queries->map(function ($query) {
58
+        return $this->queries->map(function($query) {
59 59
             return [$query['method'] => $query['arguments']];
60 60
         })->toArray();
61 61
     }
Please login to merge, or discard this patch.
src/Form/Tools.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -288,7 +288,7 @@
 block discarded – undo
288 288
             return '';
289 289
         }
290 290
 
291
-        return $tools->map(function ($tool) {
291
+        return $tools->map(function($tool) {
292 292
             if ($tool instanceof Renderable) {
293 293
                 return $tool->render();
294 294
             }
Please login to merge, or discard this patch.
src/Show/Tools.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -275,7 +275,7 @@
 block discarded – undo
275 275
      */
276 276
     protected function renderCustomTools($tools)
277 277
     {
278
-        return $tools->map(function ($tool) {
278
+        return $tools->map(function($tool) {
279 279
             if ($tool instanceof Renderable) {
280 280
                 return $tool->render();
281 281
             }
Please login to merge, or discard this patch.
src/Controllers/AuthController.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      *
35 35
      * @param Request $request
36 36
      *
37
-     * @return mixed
37
+     * @return \Illuminate\Http\RedirectResponse
38 38
      */
39 39
     public function postLogin(Request $request)
40 40
     {
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     /**
63 63
      * User logout.
64 64
      *
65
-     * @return Redirect
65
+     * @return \Illuminate\Http\RedirectResponse
66 66
      */
67 67
     public function getLogout(Request $request)
68 68
     {
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
      *
171 171
      * @param \Illuminate\Http\Request $request
172 172
      *
173
-     * @return \Illuminate\Http\Response
173
+     * @return \Illuminate\Http\RedirectResponse
174 174
      */
175 175
     protected function sendLoginResponse(Request $request)
176 176
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     {
84 84
         $form = $this->settingForm();
85 85
         $form->tools(
86
-            function (Form\Tools $tools) {
86
+            function(Form\Tools $tools) {
87 87
                 $tools->disableList();
88 88
             }
89 89
         );
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
         $form->image('avatar', trans('admin.avatar'));
119 119
         $form->password('password', trans('admin.password'))->rules('confirmed|required');
120 120
         $form->password('password_confirmation', trans('admin.password_confirmation'))->rules('required')
121
-            ->default(function ($form) {
121
+            ->default(function($form) {
122 122
                 return $form->model()->password;
123 123
             });
124 124
 
@@ -126,13 +126,13 @@  discard block
 block discarded – undo
126 126
 
127 127
         $form->ignore(['password_confirmation']);
128 128
 
129
-        $form->saving(function (Form $form) {
129
+        $form->saving(function(Form $form) {
130 130
             if ($form->password && $form->model()->password != $form->password) {
131 131
                 $form->password = bcrypt($form->password);
132 132
             }
133 133
         });
134 134
 
135
-        $form->saved(function () {
135
+        $form->saved(function() {
136 136
             admin_toastr(trans('admin.update_succeeded'));
137 137
 
138 138
             return redirect(admin_base_path('auth/setting'));
Please login to merge, or discard this patch.