Completed
Pull Request — master (#2374)
by Limon
03:00
created
src/Show/Field.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     /**
89 89
      * Get name of this column.
90 90
      *
91
-     * @return mixed
91
+     * @return string
92 92
      */
93 93
     public function getName()
94 94
     {
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     /**
113 113
      * Get label of the column.
114 114
      *
115
-     * @return mixed
115
+     * @return string
116 116
      */
117 117
     public function getLabel()
118 118
     {
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
      */
173 173
     public function using(array $values, $default = null)
174 174
     {
175
-        return $this->as(function ($value) use ($values, $default) {
175
+        return $this->as(function($value) use ($values, $default) {
176 176
             if (is_null($value)) {
177 177
                 return $default;
178 178
             }
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
      */
193 193
     public function image($server = '', $width = 200, $height = 200)
194 194
     {
195
-        return $this->as(function ($path) use ($server, $width, $height) {
195
+        return $this->as(function($path) use ($server, $width, $height) {
196 196
 
197 197
             if (empty($path)) {
198 198
                 return '';
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
     {
229 229
         $field = $this;
230 230
 
231
-        return $this->as(function ($path) use ($server, $download, $field) {
231
+        return $this->as(function($path) use ($server, $download, $field) {
232 232
             $name = basename($path);
233 233
 
234 234
             $field->wrapped = false;
@@ -276,7 +276,7 @@  discard block
 block discarded – undo
276 276
      */
277 277
     public function link($href = '', $target = '_blank')
278 278
     {
279
-        return $this->as(function ($link) use ($href, $target) {
279
+        return $this->as(function($link) use ($href, $target) {
280 280
             $href = $href ?: $link;
281 281
 
282 282
             return "<a href='$href' target='{$target}'>{$link}</a>";
@@ -292,12 +292,12 @@  discard block
 block discarded – undo
292 292
      */
293 293
     public function label($style = 'success')
294 294
     {
295
-        return $this->as(function ($value) use ($style) {
295
+        return $this->as(function($value) use ($style) {
296 296
             if ($value instanceof Arrayable) {
297 297
                 $value = $value->toArray();
298 298
             }
299 299
 
300
-            return collect((array) $value)->map(function ($name) use ($style) {
300
+            return collect((array) $value)->map(function($name) use ($style) {
301 301
                 return "<span class='label label-{$style}'>$name</span>";
302 302
             })->implode('&nbsp;');
303 303
         });
@@ -312,12 +312,12 @@  discard block
 block discarded – undo
312 312
      */
313 313
     public function badge($style = 'blue')
314 314
     {
315
-        return $this->as(function ($value) use ($style) {
315
+        return $this->as(function($value) use ($style) {
316 316
             if ($value instanceof Arrayable) {
317 317
                 $value = $value->toArray();
318 318
             }
319 319
 
320
-            return collect((array) $value)->map(function ($name) use ($style) {
320
+            return collect((array) $value)->map(function($name) use ($style) {
321 321
                 return "<span class='badge bg-{$style}'>$name</span>";
322 322
             })->implode('&nbsp;');
323 323
         });
@@ -332,7 +332,7 @@  discard block
 block discarded – undo
332 332
     {
333 333
         $field = $this;
334 334
 
335
-        return $this->as(function ($value) use ($field) {
335
+        return $this->as(function($value) use ($field) {
336 336
             $content = json_decode($value, true);
337 337
 
338 338
             if (json_last_error() == 0) {
@@ -443,7 +443,7 @@  discard block
 block discarded – undo
443 443
     public function render()
444 444
     {
445 445
         if ($this->showAs->isNotEmpty()) {
446
-            $this->showAs->each(function ($callable) {
446
+            $this->showAs->each(function($callable) {
447 447
                 $this->value = $callable->call(
448 448
                     $this->parent->getModel(),
449 449
                     $this->value
Please login to merge, or discard this patch.
src/Show/Panel.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@
 block discarded – undo
138 138
     /**
139 139
      * Fill fields to panel.
140 140
      *
141
-     * @param []Field $fields
141
+     * @param Collection $fields
142 142
      *
143 143
      * @return $this
144 144
      */
Please login to merge, or discard this patch.
src/Grid/Tools/BatchActions.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
     /**
53 53
      * Add a batch action.
54 54
      *
55
-     * @param $title
55
+     * @param BatchDelete $title
56 56
      * @param BatchAction|null $action
57 57
      *
58 58
      * @return $this
Please login to merge, or discard this patch.
src/Grid/Filter/Scope.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
      */
56 56
     public function condition()
57 57
     {
58
-        return $this->queries->map(function ($query) {
58
+        return $this->queries->map(function($query) {
59 59
             return [$query['method'] => $query['arguments']];
60 60
         })->toArray();
61 61
     }
Please login to merge, or discard this patch.
src/Form/Tools.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -288,7 +288,7 @@
 block discarded – undo
288 288
             return '';
289 289
         }
290 290
 
291
-        return $tools->map(function ($tool) {
291
+        return $tools->map(function($tool) {
292 292
             if ($tool instanceof Renderable) {
293 293
                 return $tool->render();
294 294
             }
Please login to merge, or discard this patch.
src/Show/Tools.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -275,7 +275,7 @@
 block discarded – undo
275 275
      */
276 276
     protected function renderCustomTools($tools)
277 277
     {
278
-        return $tools->map(function ($tool) {
278
+        return $tools->map(function($tool) {
279 279
             if ($tool instanceof Renderable) {
280 280
                 return $tool->render();
281 281
             }
Please login to merge, or discard this patch.
src/Grid/Displayers/Table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
             $columns = $titles;
24 24
         }
25 25
 
26
-        $data = array_map(function ($item) use ($columns) {
26
+        $data = array_map(function($item) use ($columns) {
27 27
             $sorted = [];
28 28
 
29 29
             $arr = array_only($item, $columns);
Please login to merge, or discard this patch.
src/Form.php 2 patches
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -292,9 +292,9 @@  discard block
 block discarded – undo
292 292
         $data = $this->model->with($this->getRelations())
293 293
             ->findOrFail($id)->toArray();
294 294
 
295
-        $this->builder->fields()->filter(function ($field) {
295
+        $this->builder->fields()->filter(function($field) {
296 296
             return $field instanceof Field\File;
297
-        })->each(function (Field\File $file) use ($data) {
297
+        })->each(function(Field\File $file) use ($data) {
298 298
             $file->setOriginal($data);
299 299
 
300 300
             $file->destroy();
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
             return $response;
320 320
         }
321 321
 
322
-        DB::transaction(function () {
322
+        DB::transaction(function() {
323 323
             $inserts = $this->prepareInsert($this->updates);
324 324
 
325 325
             foreach ($inserts as $column => $value) {
@@ -506,7 +506,7 @@  discard block
 block discarded – undo
506 506
             return $response;
507 507
         }
508 508
 
509
-        DB::transaction(function () {
509
+        DB::transaction(function() {
510 510
             $updates = $this->prepareUpdate($this->updates);
511 511
 
512 512
             foreach ($updates as $column => $value) {
@@ -939,7 +939,7 @@  discard block
 block discarded – undo
939 939
     protected function getFieldByColumn($column)
940 940
     {
941 941
         return $this->builder->fields()->first(
942
-            function (Field $field) use ($column) {
942
+            function(Field $field) use ($column) {
943 943
                 if (is_array($field->column())) {
944 944
                     return in_array($column, $field->column());
945 945
                 }
@@ -960,7 +960,7 @@  discard block
 block discarded – undo
960 960
 
961 961
         $values = $this->model->toArray();
962 962
 
963
-        $this->builder->fields()->each(function (Field $field) use ($values) {
963
+        $this->builder->fields()->each(function(Field $field) use ($values) {
964 964
             $field->setOriginal($values);
965 965
         });
966 966
     }
@@ -982,7 +982,7 @@  discard block
 block discarded – undo
982 982
 
983 983
         $data = $this->model->toArray();
984 984
 
985
-        $this->builder->fields()->each(function (Field $field) use ($data) {
985
+        $this->builder->fields()->each(function(Field $field) use ($data) {
986 986
             if (!in_array($field->column(), $this->ignored)) {
987 987
                 $field->fill($data);
988 988
             }
@@ -1105,7 +1105,7 @@  discard block
 block discarded – undo
1105 1105
      */
1106 1106
     public function setWidth($fieldWidth = 8, $labelWidth = 2)
1107 1107
     {
1108
-        $this->builder()->fields()->each(function ($field) use ($fieldWidth, $labelWidth) {
1108
+        $this->builder()->fields()->each(function($field) use ($fieldWidth, $labelWidth) {
1109 1109
             /* @var Field $field  */
1110 1110
             $field->setWidth($fieldWidth, $labelWidth);
1111 1111
         });
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
      *
266 266
      * @param $id
267 267
      *
268
-     * @return mixed
268
+     * @return boolean
269 269
      */
270 270
     public function destroy($id)
271 271
     {
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
      *
370 370
      * @param array $data
371 371
      *
372
-     * @return mixed
372
+     * @return Response|null
373 373
      */
374 374
     protected function prepare($data = [])
375 375
     {
@@ -547,7 +547,7 @@  discard block
 block discarded – undo
547 547
     /**
548 548
      * Get RedirectResponse after update.
549 549
      *
550
-     * @param mixed $key
550
+     * @param integer $key
551 551
      *
552 552
      * @return \Illuminate\Http\RedirectResponse
553 553
      */
Please login to merge, or discard this patch.
src/Controllers/AuthController.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      *
35 35
      * @param Request $request
36 36
      *
37
-     * @return mixed
37
+     * @return \Illuminate\Http\RedirectResponse
38 38
      */
39 39
     public function postLogin(Request $request)
40 40
     {
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     /**
63 63
      * User logout.
64 64
      *
65
-     * @return Redirect
65
+     * @return \Illuminate\Http\RedirectResponse
66 66
      */
67 67
     public function getLogout(Request $request)
68 68
     {
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
      *
171 171
      * @param \Illuminate\Http\Request $request
172 172
      *
173
-     * @return \Illuminate\Http\Response
173
+     * @return \Illuminate\Http\RedirectResponse
174 174
      */
175 175
     protected function sendLoginResponse(Request $request)
176 176
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     {
84 84
         $form = $this->settingForm();
85 85
         $form->tools(
86
-            function (Form\Tools $tools) {
86
+            function(Form\Tools $tools) {
87 87
                 $tools->disableList();
88 88
             }
89 89
         );
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
         $form->image('avatar', trans('admin.avatar'));
119 119
         $form->password('password', trans('admin.password'))->rules('confirmed|required');
120 120
         $form->password('password_confirmation', trans('admin.password_confirmation'))->rules('required')
121
-            ->default(function ($form) {
121
+            ->default(function($form) {
122 122
                 return $form->model()->password;
123 123
             });
124 124
 
@@ -126,13 +126,13 @@  discard block
 block discarded – undo
126 126
 
127 127
         $form->ignore(['password_confirmation']);
128 128
 
129
-        $form->saving(function (Form $form) {
129
+        $form->saving(function(Form $form) {
130 130
             if ($form->password && $form->model()->password != $form->password) {
131 131
                 $form->password = bcrypt($form->password);
132 132
             }
133 133
         });
134 134
 
135
-        $form->saved(function () {
135
+        $form->saved(function() {
136 136
             admin_toastr(trans('admin.update_succeeded'));
137 137
 
138 138
             return redirect(admin_base_path('auth/setting'));
Please login to merge, or discard this patch.