Completed
Pull Request — master (#2374)
by Limon
03:00
created
src/Admin.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -235,10 +235,10 @@
 block discarded – undo
235 235
             'middleware' => config('admin.route.middleware'),
236 236
         ];
237 237
 
238
-        Route::group($attributes, function ($router) {
238
+        Route::group($attributes, function($router) {
239 239
 
240 240
             /* @var \Illuminate\Routing\Router $router */
241
-            $router->group([], function ($router) {
241
+            $router->group([], function($router) {
242 242
 
243 243
                 /* @var \Illuminate\Routing\Router $router */
244 244
                 $router->resource('auth/users', 'UserController');
Please login to merge, or discard this patch.
src/Form/Field/Select.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
      *
39 39
      * @param array|callable|string $options
40 40
      *
41
-     * @return $this|mixed
41
+     * @return Select
42 42
      */
43 43
     public function options($options = [])
44 44
     {
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -198,13 +198,13 @@  discard block
 block discarded – undo
198 198
      */
199 199
     protected function selected($model, $textField = 'name', $idField = 'id')
200 200
     {
201
-        $this->options = function ($resource) use ($model, $textField, $idField) {
201
+        $this->options = function($resource) use ($model, $textField, $idField) {
202 202
             if (null == $resource) {
203 203
                 return [];
204 204
             }
205 205
 
206 206
             if (is_array($resource) && !empty($resource) && isset($resource[0]['id'])) {
207
-                $resource = array_map(function ($res) {
207
+                $resource = array_map(function($res) {
208 208
                     return $res['id'];
209 209
                 }, $resource);
210 210
             } elseif (is_array($resource) && !empty($resource) && isset($resource['id'])) {
@@ -379,7 +379,7 @@  discard block
 block discarded – undo
379 379
             'groups'  => $this->groups,
380 380
         ]);
381 381
 
382
-        $this->attribute('data-value', implode(',', (array)$this->value()));
382
+        $this->attribute('data-value', implode(',', (array) $this->value()));
383 383
 
384 384
         return parent::render();
385 385
     }
Please login to merge, or discard this patch.
src/Middleware/Permission.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
             return $next($request);
34 34
         }
35 35
 
36
-        if (!Admin::user()->allPermissions()->first(function ($permission) use ($request) {
36
+        if (!Admin::user()->allPermissions()->first(function($permission) use ($request) {
37 37
             return $permission->shouldPassThrough($request);
38 38
         })) {
39 39
             Checker::error();
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
      */
53 53
     public function checkRoutePermission(Request $request)
54 54
     {
55
-        if (!$middleware = collect($request->route()->middleware())->first(function ($middleware) {
55
+        if (!$middleware = collect($request->route()->middleware())->first(function($middleware) {
56 56
             return Str::startsWith($middleware, $this->middlewarePrefix);
57 57
         })) {
58 58
             return false;
Please login to merge, or discard this patch.
src/Auth/Database/Role.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@
 block discarded – undo
86 86
     {
87 87
         parent::boot();
88 88
 
89
-        static::deleting(function ($model) {
89
+        static::deleting(function($model) {
90 90
             $model->administrators()->detach();
91 91
 
92 92
             $model->permissions()->detach();
Please login to merge, or discard this patch.
src/Auth/Database/Permission.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
         $method = $this->http_method;
68 68
 
69
-        $matches = array_map(function ($path) use ($method) {
69
+        $matches = array_map(function($path) use ($method) {
70 70
             $path = trim(config('admin.route.prefix'), '/').$path;
71 71
 
72 72
             if (Str::contains($path, ':')) {
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
             return false;
101 101
         }
102 102
 
103
-        $method = collect($match['method'])->filter()->map(function ($method) {
103
+        $method = collect($match['method'])->filter()->map(function($method) {
104 104
             return strtoupper($method);
105 105
         });
106 106
 
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
     {
141 141
         parent::boot();
142 142
 
143
-        static::deleting(function ($model) {
143
+        static::deleting(function($model) {
144 144
             $model->roles()->detach();
145 145
         });
146 146
     }
Please login to merge, or discard this patch.
src/Auth/Database/Menu.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@
 block discarded – undo
78 78
     {
79 79
         static::treeBoot();
80 80
 
81
-        static::deleting(function ($model) {
81
+        static::deleting(function($model) {
82 82
             $model->roles()->detach();
83 83
         });
84 84
     }
Please login to merge, or discard this patch.
src/Grid/Model.php 2 patches
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -225,9 +225,9 @@  discard block
 block discarded – undo
225 225
 
226 226
         $this->setSort();
227 227
 
228
-        $this->queries->reject(function ($query) {
228
+        $this->queries->reject(function($query) {
229 229
             return $query['method'] == 'paginate';
230
-        })->each(function ($query) {
230
+        })->each(function($query) {
231 231
             $this->model = $this->model->{$query['method']}(...$query['arguments']);
232 232
         });
233 233
 
@@ -274,7 +274,7 @@  discard block
 block discarded – undo
274 274
         $this->setSort();
275 275
         $this->setPaginate();
276 276
 
277
-        $this->queries->unique()->each(function ($query) {
277
+        $this->queries->unique()->each(function($query) {
278 278
             $this->model = call_user_func_array([$this->model, $query['method']], $query['arguments']);
279 279
         });
280 280
 
@@ -318,7 +318,7 @@  discard block
 block discarded – undo
318 318
     {
319 319
         $paginate = $this->findQueryByMethod('paginate');
320 320
 
321
-        $this->queries = $this->queries->reject(function ($query) {
321
+        $this->queries = $this->queries->reject(function($query) {
322 322
             return $query['method'] == 'paginate';
323 323
         });
324 324
 
@@ -372,7 +372,7 @@  discard block
 block discarded – undo
372 372
      */
373 373
     protected function findQueryByMethod($method)
374 374
     {
375
-        return $this->queries->first(function ($query) use ($method) {
375
+        return $this->queries->first(function($query) use ($method) {
376 376
             return $query['method'] == $method;
377 377
         });
378 378
     }
@@ -416,7 +416,7 @@  discard block
 block discarded – undo
416 416
     {
417 417
         list($relationName, $relationColumn) = explode('.', $column);
418 418
 
419
-        if ($this->queries->contains(function ($query) use ($relationName) {
419
+        if ($this->queries->contains(function($query) use ($relationName) {
420 420
             return $query['method'] == 'with' && in_array($relationName, $query['arguments']);
421 421
         })) {
422 422
             $relation = $this->model->$relationName();
@@ -445,7 +445,7 @@  discard block
 block discarded – undo
445 445
      */
446 446
     public function resetOrderBy()
447 447
     {
448
-        $this->queries = $this->queries->reject(function ($query) {
448
+        $this->queries = $this->queries->reject(function($query) {
449 449
             return $query['method'] == 'orderBy' || $query['method'] == 'orderByDesc';
450 450
         });
451 451
     }
Please login to merge, or discard this patch.
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -411,7 +411,7 @@  discard block
 block discarded – undo
411 411
     /**
412 412
      * Resolve perPage for pagination.
413 413
      *
414
-     * @param array|null $paginate
414
+     * @param Model $paginate
415 415
      *
416 416
      * @return array
417 417
      */
@@ -441,7 +441,7 @@  discard block
 block discarded – undo
441 441
     /**
442 442
      * Find query by method name.
443 443
      *
444
-     * @param $method
444
+     * @param string $method
445 445
      *
446 446
      * @return static
447 447
      */
@@ -534,7 +534,7 @@  discard block
 block discarded – undo
534 534
      *
535 535
      * @throws \Exception
536 536
      *
537
-     * @return array
537
+     * @return string[]
538 538
      */
539 539
     protected function joinParameters(Relation $relation)
540 540
     {
Please login to merge, or discard this patch.
src/Form/Field.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
     /**
203 203
      * Field constructor.
204 204
      *
205
-     * @param       $column
205
+     * @param       string $column
206 206
      * @param array $arguments
207 207
      */
208 208
     public function __construct($column, $arguments = [])
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
     /**
402 402
      * Get or set rules.
403 403
      *
404
-     * @param null  $rules
404
+     * @param string  $rules
405 405
      * @param array $messages
406 406
      *
407 407
      * @return $this
@@ -494,7 +494,7 @@  discard block
 block discarded – undo
494 494
     /**
495 495
      * Set or get value of the field.
496 496
      *
497
-     * @param null $value
497
+     * @param string $value
498 498
      *
499 499
      * @return mixed
500 500
      */
@@ -647,7 +647,7 @@  discard block
 block discarded – undo
647 647
     /**
648 648
      * Add html attributes to elements.
649 649
      *
650
-     * @param array|string $attribute
650
+     * @param string $attribute
651 651
      * @param mixed        $value
652 652
      *
653 653
      * @return $this
Please login to merge, or discard this patch.
src/Grid/HasElementNames.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -107,6 +107,7 @@
 block discarded – undo
107 107
     }
108 108
 
109 109
     /**
110
+     * @param string $name
110 111
      * @return string
111 112
      */
112 113
     protected function elementNameWithPrefix($name)
Please login to merge, or discard this patch.