Completed
Pull Request — master (#2374)
by Limon
03:00
created
src/Auth/Database/HasPermissions.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     /**
56 56
      * Get all permissions of user.
57 57
      *
58
-     * @return mixed
58
+     * @return Collection
59 59
      */
60 60
     public function allPermissions() : Collection
61 61
     {
@@ -97,7 +97,7 @@  discard block
 block discarded – undo
97 97
     /**
98 98
      * Check if user is administrator.
99 99
      *
100
-     * @return mixed
100
+     * @return boolean
101 101
      */
102 102
     public function isAdministrator() : bool
103 103
     {
@@ -109,7 +109,7 @@  discard block
 block discarded – undo
109 109
      *
110 110
      * @param string $role
111 111
      *
112
-     * @return mixed
112
+     * @return boolean
113 113
      */
114 114
     public function isRole(string $role) : bool
115 115
     {
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      *
122 122
      * @param array $roles
123 123
      *
124
-     * @return mixed
124
+     * @return boolean
125 125
      */
126 126
     public function inRoles(array $roles = []) : bool
127 127
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -155,7 +155,7 @@
 block discarded – undo
155 155
     {
156 156
         parent::boot();
157 157
 
158
-        static::deleting(function ($model) {
158
+        static::deleting(function($model) {
159 159
             $model->roles()->detach();
160 160
 
161 161
             $model->permissions()->detach();
Please login to merge, or discard this patch.
src/Grid.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
      * Get or set option for grid.
229 229
      *
230 230
      * @param string $key
231
-     * @param mixed  $value
231
+     * @param boolean  $value
232 232
      *
233 233
      * @return $this|mixed
234 234
      */
@@ -358,7 +358,7 @@  discard block
 block discarded – undo
358 358
     /**
359 359
      * Get the grid paginator.
360 360
      *
361
-     * @return mixed
361
+     * @return Tools\Paginator
362 362
      */
363 363
     public function paginator()
364 364
     {
@@ -722,7 +722,7 @@  discard block
 block discarded – undo
722 722
      *
723 723
      * @param Closure|null $closure
724 724
      *
725
-     * @return $this|Tools\Footer
725
+     * @return callable
726 726
      */
727 727
     public function footer(Closure $closure = null)
728 728
     {
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
         $callback = $this->actionsCallback;
445 445
         $column = $this->addColumn('__actions__', trans('admin.action'));
446 446
 
447
-        $column->display(function ($value) use ($grid, $column, $callback) {
447
+        $column->display(function($value) use ($grid, $column, $callback) {
448 448
             $actions = new Displayers\Actions($value, $grid, $column, $this);
449 449
 
450 450
             return $actions->display($callback);
@@ -458,7 +458,7 @@  discard block
 block discarded – undo
458 458
      */
459 459
     public function disableRowSelector()
460 460
     {
461
-        $this->tools(function ($tools) {
461
+        $this->tools(function($tools) {
462 462
             /* @var Grid\Tools $tools */
463 463
             $tools->disableBatchActions();
464 464
         });
@@ -482,7 +482,7 @@  discard block
 block discarded – undo
482 482
         $column = new Column(Column::SELECT_COLUMN_NAME, ' ');
483 483
         $column->setGrid($this);
484 484
 
485
-        $column->display(function ($value) use ($grid, $column) {
485
+        $column->display(function($value) use ($grid, $column) {
486 486
             $actions = new Displayers\RowSelector($value, $grid, $column, $this);
487 487
 
488 488
             return $actions->display();
@@ -509,7 +509,7 @@  discard block
 block discarded – undo
509 509
 
510 510
         Column::setOriginalGridData($data);
511 511
 
512
-        $this->columns->map(function (Column $column) use (&$data) {
512
+        $this->columns->map(function(Column $column) use (&$data) {
513 513
             $data = $column->fill($data);
514 514
 
515 515
             $this->columnNames[] = $column->getName();
@@ -601,7 +601,7 @@  discard block
 block discarded – undo
601 601
      */
602 602
     protected function buildRows(array $data)
603 603
     {
604
-        $this->rows = collect($data)->map(function ($model, $number) {
604
+        $this->rows = collect($data)->map(function($model, $number) {
605 605
             return new Row($number, $model);
606 606
         });
607 607
 
Please login to merge, or discard this patch.
src/Form/Field/MultipleFile.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -134,7 +134,7 @@
 block discarded – undo
134 134
     {
135 135
         $this->name = $this->getStoreName($file);
136 136
 
137
-        return tap($this->upload($file), function () {
137
+        return tap($this->upload($file), function() {
138 138
             $this->name = null;
139 139
         });
140 140
     }
Please login to merge, or discard this patch.
src/Form/Field/MultipleImage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
 
34 34
         $this->callInterventionMethods($image->getRealPath());
35 35
 
36
-        return tap($this->upload($image), function () {
36
+        return tap($this->upload($image), function() {
37 37
             $this->name = null;
38 38
         });
39 39
     }
Please login to merge, or discard this patch.
src/Grid/Displayers/Image.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
             $this->value = $this->value->toArray();
14 14
         }
15 15
 
16
-        return collect((array) $this->value)->filter()->map(function ($path) use ($server, $width, $height) {
16
+        return collect((array) $this->value)->filter()->map(function($path) use ($server, $width, $height) {
17 17
             if (url()->isValidUrl($path)) {
18 18
                 $src = $path;
19 19
             } elseif ($server) {
Please login to merge, or discard this patch.
src/Middleware/Pjax.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
      */
48 48
     public static function respond(Response $response)
49 49
     {
50
-        $next = function () use ($response) {
50
+        $next = function() use ($response) {
51 51
             return $response;
52 52
         };
53 53
 
@@ -139,7 +139,7 @@  discard block
 block discarded – undo
139 139
      */
140 140
     protected function decodeUtf8HtmlEntities($html)
141 141
     {
142
-        return preg_replace_callback('/(&#[0-9]+;)/', function ($html) {
142
+        return preg_replace_callback('/(&#[0-9]+;)/', function($html) {
143 143
             return mb_convert_encoding($html[1], 'UTF-8', 'HTML-ENTITIES');
144 144
         }, $html);
145 145
     }
Please login to merge, or discard this patch.
src/Controllers/Dashboard.php 1 patch
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -20,20 +20,20 @@
 block discarded – undo
20 20
     public static function environment()
21 21
     {
22 22
         $envs = [
23
-            ['name' => 'PHP version',       'value' => 'PHP/'.PHP_VERSION],
24
-            ['name' => 'Laravel version',   'value' => app()->version()],
25
-            ['name' => 'CGI',               'value' => php_sapi_name()],
26
-            ['name' => 'Uname',             'value' => php_uname()],
27
-            ['name' => 'Server',            'value' => array_get($_SERVER, 'SERVER_SOFTWARE')],
23
+            ['name' => 'PHP version', 'value' => 'PHP/'.PHP_VERSION],
24
+            ['name' => 'Laravel version', 'value' => app()->version()],
25
+            ['name' => 'CGI', 'value' => php_sapi_name()],
26
+            ['name' => 'Uname', 'value' => php_uname()],
27
+            ['name' => 'Server', 'value' => array_get($_SERVER, 'SERVER_SOFTWARE')],
28 28
 
29
-            ['name' => 'Cache driver',      'value' => config('cache.default')],
30
-            ['name' => 'Session driver',    'value' => config('session.driver')],
31
-            ['name' => 'Queue driver',      'value' => config('queue.default')],
29
+            ['name' => 'Cache driver', 'value' => config('cache.default')],
30
+            ['name' => 'Session driver', 'value' => config('session.driver')],
31
+            ['name' => 'Queue driver', 'value' => config('queue.default')],
32 32
 
33
-            ['name' => 'Timezone',          'value' => config('app.timezone')],
34
-            ['name' => 'Locale',            'value' => config('app.locale')],
35
-            ['name' => 'Env',               'value' => config('app.env')],
36
-            ['name' => 'URL',               'value' => config('app.url')],
33
+            ['name' => 'Timezone', 'value' => config('app.timezone')],
34
+            ['name' => 'Locale', 'value' => config('app.locale')],
35
+            ['name' => 'Env', 'value' => config('app.env')],
36
+            ['name' => 'URL', 'value' => config('app.url')],
37 37
         ];
38 38
 
39 39
         return view('admin::dashboard.environment', compact('envs'));
Please login to merge, or discard this patch.
src/Grid/Filter/Presenter/Select.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -168,7 +168,7 @@
 block discarded – undo
168 168
      *
169 169
      * @param string $target
170 170
      *
171
-     * @return mixed
171
+     * @return string
172 172
      */
173 173
     protected function getClass($target) : string
174 174
     {
Please login to merge, or discard this patch.
src/Grid/Exporters/CsvExporter.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -21,12 +21,12 @@  discard block
 block discarded – undo
21 21
             'Content-Disposition' => "attachment; filename=\"$filename\"",
22 22
         ];
23 23
 
24
-        response()->stream(function () {
24
+        response()->stream(function() {
25 25
             $handle = fopen('php://output', 'w');
26 26
 
27 27
             $titles = [];
28 28
 
29
-            $this->chunk(function ($records) use ($handle, &$titles) {
29
+            $this->chunk(function($records) use ($handle, &$titles) {
30 30
                 if (empty($titles)) {
31 31
                     $titles = $this->getHeaderRowFromRecords($records);
32 32
 
@@ -54,7 +54,7 @@  discard block
 block discarded – undo
54 54
     public function getHeaderRowFromRecords(Collection $records): array
55 55
     {
56 56
         $titles = collect(array_dot($records->first()->toArray()))->keys()->map(
57
-            function ($key) {
57
+            function($key) {
58 58
                 $key = str_replace('.', ' ', $key);
59 59
 
60 60
                 return Str::ucfirst($key);
Please login to merge, or discard this patch.