Completed
Pull Request — master (#248)
by Edwin
02:44
created
src/Controllers/PermissionController.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@  discard block
 block discarded – undo
20 20
      */
21 21
     public function index()
22 22
     {
23
-        return Admin::content(function (Content $content) {
23
+        return Admin::content(function(Content $content) {
24 24
             $content->header(trans('admin::lang.permissions'));
25 25
             $content->description(trans('admin::lang.list'));
26 26
             $content->body($this->grid()->render());
@@ -36,7 +36,7 @@  discard block
 block discarded – undo
36 36
      */
37 37
     public function edit($id)
38 38
     {
39
-        return Admin::content(function (Content $content) use ($id) {
39
+        return Admin::content(function(Content $content) use ($id) {
40 40
             $content->header(trans('admin::lang.permissions'));
41 41
             $content->description(trans('admin::lang.edit'));
42 42
             $content->body($this->form()->edit($id));
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
      */
51 51
     public function create()
52 52
     {
53
-        return Admin::content(function (Content $content) {
53
+        return Admin::content(function(Content $content) {
54 54
             $content->header(trans('admin::lang.permissions'));
55 55
             $content->description(trans('admin::lang.create'));
56 56
             $content->body($this->form());
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
      */
65 65
     protected function grid()
66 66
     {
67
-        return Admin::grid(Permission::class, function (Grid $grid) {
67
+        return Admin::grid(Permission::class, function(Grid $grid) {
68 68
             $grid->id('ID')->sortable();
69 69
             $grid->slug(trans('admin::lang.slug'));
70 70
             $grid->name(trans('admin::lang.name'));
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
      */
82 82
     public function form()
83 83
     {
84
-        return Admin::form(Permission::class, function (Form $form) {
84
+        return Admin::form(Permission::class, function(Form $form) {
85 85
             $form->display('id', 'ID');
86 86
 
87 87
             $form->text('slug', trans('admin::lang.slug'));
Please login to merge, or discard this patch.
src/Widgets/Box.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
             return $this->style([$styles]);
65 65
         }
66 66
 
67
-        $styles = array_map(function ($style) {
67
+        $styles = array_map(function($style) {
68 68
             return 'box-'.$style;
69 69
         }, $styles);
70 70
 
Please login to merge, or discard this patch.
src/Widgets/Form.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -140,7 +140,7 @@
 block discarded – undo
140 140
      * @param Field $field
141 141
      * @return $this
142 142
      */
143
-    protected function pushField(Field &$field)
143
+    protected function pushField(Field & $field)
144 144
     {
145 145
         array_push($this->fields, $field);
146 146
 
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -117,7 +117,7 @@
 block discarded – undo
117 117
     /**
118 118
      * Add form attributes.
119 119
      *
120
-     * @param string|array $attr
120
+     * @param string $attr
121 121
      * @param string       $value
122 122
      *
123 123
      * @return $this
Please login to merge, or discard this patch.
src/Auth/Database/Menu.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@
 block discarded – undo
84 84
     {
85 85
         static::$branchOrder = array_flip(array_flatten($order));
86 86
 
87
-        static::$branchOrder = array_map(function ($item) {
87
+        static::$branchOrder = array_map(function($item) {
88 88
             return ++$item;
89 89
         }, static::$branchOrder);
90 90
     }
Please login to merge, or discard this patch.
src/Controllers/UserController.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
      */
22 22
     public function index()
23 23
     {
24
-        return Admin::content(function (Content $content) {
24
+        return Admin::content(function(Content $content) {
25 25
             $content->header(trans('admin::lang.administrator'));
26 26
             $content->description(trans('admin::lang.list'));
27 27
             $content->body($this->grid()->render());
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
      */
38 38
     public function edit($id)
39 39
     {
40
-        return Admin::content(function (Content $content) use ($id) {
40
+        return Admin::content(function(Content $content) use ($id) {
41 41
             $content->header(trans('admin::lang.administrator'));
42 42
             $content->description(trans('admin::lang.edit'));
43 43
             $content->body($this->form()->edit($id));
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
      */
52 52
     public function create()
53 53
     {
54
-        return Admin::content(function (Content $content) {
54
+        return Admin::content(function(Content $content) {
55 55
             $content->header(trans('admin::lang.administrator'));
56 56
             $content->description(trans('admin::lang.create'));
57 57
             $content->body($this->form());
@@ -65,13 +65,13 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function grid()
67 67
     {
68
-        return Admin::grid(Administrator::class, function (Grid $grid) {
68
+        return Admin::grid(Administrator::class, function(Grid $grid) {
69 69
             $grid->id('ID')->sortable();
70 70
             $grid->username(trans('admin::lang.username'));
71 71
             $grid->name(trans('admin::lang.name'));
72 72
 
73
-            $grid->roles(trans('admin::lang.roles'))->value(function ($roles) {
74
-                $roles = array_map(function ($role) {
73
+            $grid->roles(trans('admin::lang.roles'))->value(function($roles) {
74
+                $roles = array_map(function($role) {
75 75
                     return "<span class='label label-success'>{$role['name']}</span>";
76 76
                 }, $roles);
77 77
 
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
             $grid->created_at(trans('admin::lang.created_at'));
82 82
             $grid->updated_at(trans('admin::lang.updated_at'));
83 83
 
84
-            $grid->rows(function ($row) {
84
+            $grid->rows(function($row) {
85 85
                 if ($row->id == 1) {
86 86
                     $row->actions('edit');
87 87
                 }
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
      */
97 97
     public function form()
98 98
     {
99
-        return Admin::form(Administrator::class, function (Form $form) {
99
+        return Admin::form(Administrator::class, function(Form $form) {
100 100
             $form->display('id', 'ID');
101 101
 
102 102
             $form->text('username', trans('admin::lang.username'))->rules('required');
@@ -108,7 +108,7 @@  discard block
 block discarded – undo
108 108
             $form->display('created_at', trans('admin::lang.created_at'));
109 109
             $form->display('updated_at', trans('admin::lang.updated_at'));
110 110
 
111
-            $form->saving(function (Form $form) {
111
+            $form->saving(function(Form $form) {
112 112
                 if ($form->password && $form->model()->password != $form->password) {
113 113
                     $form->password = bcrypt($form->password);
114 114
                 }
Please login to merge, or discard this patch.
src/Controllers/RoleController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
      */
22 22
     public function index()
23 23
     {
24
-        return Admin::content(function (Content $content) {
24
+        return Admin::content(function(Content $content) {
25 25
             $content->header(trans('admin::lang.roles'));
26 26
             $content->description(trans('admin::lang.list'));
27 27
             $content->body($this->grid()->render());
@@ -37,7 +37,7 @@  discard block
 block discarded – undo
37 37
      */
38 38
     public function edit($id)
39 39
     {
40
-        return Admin::content(function (Content $content) use ($id) {
40
+        return Admin::content(function(Content $content) use ($id) {
41 41
             $content->header(trans('admin::lang.roles'));
42 42
             $content->description(trans('admin::lang.edit'));
43 43
             $content->body($this->form()->edit($id));
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
      */
52 52
     public function create()
53 53
     {
54
-        return Admin::content(function (Content $content) {
54
+        return Admin::content(function(Content $content) {
55 55
             $content->header(trans('admin::lang.roles'));
56 56
             $content->description(trans('admin::lang.create'));
57 57
             $content->body($this->form());
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
      */
66 66
     protected function grid()
67 67
     {
68
-        return Admin::grid(Role::class, function (Grid $grid) {
68
+        return Admin::grid(Role::class, function(Grid $grid) {
69 69
             $grid->id('ID')->sortable();
70 70
             $grid->slug(trans('admin::lang.slug'));
71 71
             $grid->name(trans('admin::lang.name'));
@@ -73,7 +73,7 @@  discard block
 block discarded – undo
73 73
             $grid->created_at(trans('admin::lang.created_at'));
74 74
             $grid->updated_at(trans('admin::lang.updated_at'));
75 75
 
76
-            $grid->rows(function ($row) {
76
+            $grid->rows(function($row) {
77 77
                 if ($row->slug == 'administrator') {
78 78
                     $row->actions('edit');
79 79
                 }
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
      */
89 89
     public function form()
90 90
     {
91
-        return Admin::form(Role::class, function (Form $form) {
91
+        return Admin::form(Role::class, function(Form $form) {
92 92
             $form->display('id', 'ID');
93 93
 
94 94
             $form->text('slug', trans('admin::lang.slug'))->rules('required');
Please login to merge, or discard this patch.
src/Form.php 2 patches
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -231,9 +231,9 @@  discard block
 block discarded – undo
231 231
         $data = $this->model->with($this->getRelations())
232 232
             ->findOrFail($id)->toArray();
233 233
 
234
-        $this->builder->fields()->filter(function ($field) {
234
+        $this->builder->fields()->filter(function($field) {
235 235
             return $field instanceof Field\File;
236
-        })->each(function (File $file) use ($data) {
236
+        })->each(function(File $file) use ($data) {
237 237
             $file->setOriginal($data);
238 238
 
239 239
             $file->destroy();
@@ -255,7 +255,7 @@  discard block
 block discarded – undo
255 255
 
256 256
         $this->prepare($data, $this->saving);
257 257
 
258
-        DB::transaction(function () {
258
+        DB::transaction(function() {
259 259
             $inserts = $this->prepareInsert($this->updates);
260 260
 
261 261
             foreach ($inserts as $column => $value) {
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
 
294 294
         $updates = array_except($this->inputs, array_keys($this->relations));
295 295
 
296
-        $this->updates = array_filter($updates, function ($val) {
296
+        $this->updates = array_filter($updates, function($val) {
297 297
             return !is_null($val);
298 298
         });
299 299
     }
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
 
391 391
         $this->prepare($data, $this->saving);
392 392
 
393
-        DB::transaction(function () {
393
+        DB::transaction(function() {
394 394
             $updates = $this->prepareUpdate($this->updates);
395 395
 
396 396
             foreach ($updates as $column => $value) {
@@ -590,7 +590,7 @@  discard block
 block discarded – undo
590 590
     protected function getFieldByColumn($column)
591 591
     {
592 592
         return $this->builder->fields()->first(
593
-            function ($index, Field $field) use ($column) {
593
+            function($index, Field $field) use ($column) {
594 594
                 if (is_array($field->column())) {
595 595
                     return in_array($column, $field->column());
596 596
                 }
@@ -609,7 +609,7 @@  discard block
 block discarded – undo
609 609
     {
610 610
         $values = $this->model->toArray();
611 611
 
612
-        $this->builder->fields()->each(function (Field $field) use ($values) {
612
+        $this->builder->fields()->each(function(Field $field) use ($values) {
613 613
             $field->setOriginal($values);
614 614
         });
615 615
     }
@@ -629,7 +629,7 @@  discard block
 block discarded – undo
629 629
 
630 630
         $data = $this->model->toArray();
631 631
 
632
-        $this->builder->fields()->each(function (Field $field) use ($data) {
632
+        $this->builder->fields()->each(function(Field $field) use ($data) {
633 633
             $field->fill($data);
634 634
         });
635 635
     }
Please login to merge, or discard this patch.
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -218,7 +218,7 @@  discard block
 block discarded – undo
218 218
      *
219 219
      * @param $id
220 220
      *
221
-     * @return mixed
221
+     * @return boolean
222 222
      */
223 223
     public function destroy($id)
224 224
     {
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
      * Prepare input data for insert or update.
294 294
      *
295 295
      * @param array    $data
296
-     * @param callable $callback
296
+     * @param Closure $callback
297 297
      */
298 298
     protected function prepare($data = [], Closure $callback = null)
299 299
     {
@@ -390,7 +390,7 @@  discard block
 block discarded – undo
390 390
      *
391 391
      * @param int $id
392 392
      *
393
-     * @return $this|\Illuminate\Http\RedirectResponse
393
+     * @return \Symfony\Component\HttpFoundation\Response
394 394
      */
395 395
     public function update($id)
396 396
     {
@@ -459,7 +459,7 @@  discard block
 block discarded – undo
459 459
      * @param int   $id
460 460
      * @param array $input
461 461
      *
462
-     * @return array
462
+     * @return boolean
463 463
      */
464 464
     protected function handleOrderable($id, array $input = [])
465 465
     {
@@ -599,7 +599,7 @@  discard block
 block discarded – undo
599 599
     /**
600 600
      * Set saving callback.
601 601
      *
602
-     * @param callable $callback
602
+     * @param Closure $callback
603 603
      *
604 604
      * @return void
605 605
      */
@@ -611,7 +611,7 @@  discard block
 block discarded – undo
611 611
     /**
612 612
      * Set saved callback.
613 613
      *
614
-     * @param callable $callback
614
+     * @param Closure $callback
615 615
      *
616 616
      * @return void
617 617
      */
Please login to merge, or discard this patch.
src/Controllers/LogController.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -18,23 +18,23 @@  discard block
 block discarded – undo
18 18
      */
19 19
     public function index()
20 20
     {
21
-        return Admin::content(function (Content $content) {
21
+        return Admin::content(function(Content $content) {
22 22
             $content->header(trans('admin::lang.operation_log'));
23 23
             $content->description(trans('admin::lang.list'));
24 24
 
25
-            $grid = Admin::grid(OperationLog::class, function (Grid $grid) {
25
+            $grid = Admin::grid(OperationLog::class, function(Grid $grid) {
26 26
                 $grid->model()->orderBy('id', 'DESC');
27 27
 
28 28
                 $grid->id('ID')->sortable();
29 29
                 $grid->user()->name();
30
-                $grid->method()->value(function ($method) {
30
+                $grid->method()->value(function($method) {
31 31
                     $color = array_get(OperationLog::$methodColors, $method, 'grey');
32 32
 
33 33
                     return "<span class=\"badge bg-$color\">$method</span>";
34 34
                 });
35 35
                 $grid->path()->label('info');
36 36
                 $grid->ip()->label('primary');
37
-                $grid->input()->value(function ($input) {
37
+                $grid->input()->value(function($input) {
38 38
                     $input = json_decode($input, true);
39 39
                     $input = array_except($input, '_pjax');
40 40
 
@@ -43,11 +43,11 @@  discard block
 block discarded – undo
43 43
 
44 44
                 $grid->created_at(trans('admin::lang.created_at'));
45 45
 
46
-                $grid->rows(function ($row) {
46
+                $grid->rows(function($row) {
47 47
                     $row->actions('delete');
48 48
                 });
49 49
 
50
-                $grid->filter(function ($filter) {
50
+                $grid->filter(function($filter) {
51 51
                     $filter->is('user_id', 'User')->select(Administrator::all()->pluck('name', 'id'));
52 52
                     $filter->is('method')->select(array_combine(OperationLog::$methods, OperationLog::$methods));
53 53
                     $filter->like('path');
Please login to merge, or discard this patch.
src/Controllers/MenuController.php 2 patches
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -23,12 +23,12 @@  discard block
 block discarded – undo
23 23
      */
24 24
     public function index()
25 25
     {
26
-        return Admin::content(function (Content $content) {
26
+        return Admin::content(function(Content $content) {
27 27
             $content->header(trans('admin::lang.menu'));
28 28
             $content->description(trans('admin::lang.list'));
29 29
 
30
-            $content->row(function (Row $row) {
31
-                $row->column(5, function (Column $column) {
30
+            $content->row(function(Row $row) {
31
+                $row->column(5, function(Column $column) {
32 32
                     $column->append($this->callout());
33 33
 
34 34
                     $form = new \Encore\Admin\Widgets\Form();
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
      */
63 63
     public function edit($id)
64 64
     {
65
-        return Admin::content(function (Content $content) use ($id) {
65
+        return Admin::content(function(Content $content) use ($id) {
66 66
             $content->header(trans('admin::lang.menu'));
67 67
             $content->description(trans('admin::lang.edit'));
68 68
 
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
      */
117 117
     public function form()
118 118
     {
119
-        return Admin::form(MenuModel::class, function (Form $form) {
119
+        return Admin::form(MenuModel::class, function(Form $form) {
120 120
             $form->display('id', 'ID');
121 121
 
122 122
             $options = [0 => 'Root'] + MenuModel::buildSelectOptions();
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
     /**
75 75
      * @param $id
76 76
      *
77
-     * @return $this|\Illuminate\Http\RedirectResponse
77
+     * @return \Symfony\Component\HttpFoundation\Response
78 78
      */
79 79
     public function update($id)
80 80
     {
Please login to merge, or discard this patch.