Completed
Pull Request — master (#2584)
by Song
04:39 queued 01:57
created
src/Grid/Column.php 2 patches
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
     /**
126 126
      * Extend column displayer.
127 127
      *
128
-     * @param $name
128
+     * @param string $name
129 129
      * @param $displayer
130 130
      */
131 131
     public static function extend($name, $displayer)
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
     /**
160 160
      * Set model for column.
161 161
      *
162
-     * @param $model
162
+     * @param Model $model
163 163
      */
164 164
     public function setModel($model)
165 165
     {
@@ -219,7 +219,7 @@  discard block
 block discarded – undo
219 219
     /**
220 220
      * Get name of this column.
221 221
      *
222
-     * @return mixed
222
+     * @return string
223 223
      */
224 224
     public function getName()
225 225
     {
@@ -229,7 +229,7 @@  discard block
 block discarded – undo
229 229
     /**
230 230
      * Format label.
231 231
      *
232
-     * @param $label
232
+     * @param string $label
233 233
      *
234 234
      * @return mixed
235 235
      */
@@ -243,7 +243,7 @@  discard block
 block discarded – undo
243 243
     /**
244 244
      * Get label of the column.
245 245
      *
246
-     * @return mixed
246
+     * @return string
247 247
      */
248 248
     public function getLabel()
249 249
     {
@@ -306,7 +306,7 @@  discard block
 block discarded – undo
306 306
      * Display using display abstract.
307 307
      *
308 308
      * @param string $abstract
309
-     * @param array  $arguments
309
+     * @param Closure[]  $arguments
310 310
      *
311 311
      * @return Column
312 312
      */
Please login to merge, or discard this patch.
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 
317 317
         $column = $this;
318 318
 
319
-        return $this->display(function ($value) use ($grid, $column, $abstract, $arguments) {
319
+        return $this->display(function($value) use ($grid, $column, $abstract, $arguments) {
320 320
             /** @var AbstractDisplayer $displayer */
321 321
             $displayer = new $abstract($value, $grid, $column, $this);
322 322
 
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
      */
335 335
     public function using(array $values, $default = null)
336 336
     {
337
-        return $this->display(function ($value) use ($values, $default) {
337
+        return $this->display(function($value) use ($values, $default) {
338 338
             if (is_null($value)) {
339 339
                 return $default;
340 340
             }
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
      */
353 353
     public function view($view)
354 354
     {
355
-        return $this->display(function ($value) use ($view) {
355
+        return $this->display(function($value) use ($view) {
356 356
             $model = $this;
357 357
 
358 358
             return view($view, compact('model', 'value'))->render();
@@ -475,7 +475,7 @@  discard block
 block discarded – undo
475 475
         $grid = $this->grid;
476 476
         $column = $this;
477 477
 
478
-        $this->display(function ($value) use ($grid, $column, $class) {
478
+        $this->display(function($value) use ($grid, $column, $class) {
479 479
             /** @var AbstractDisplayer $definition */
480 480
             $definition = new $class($value, $grid, $column, $this);
481 481
 
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
     protected function htmlEntityEncode($item)
494 494
     {
495 495
         if (is_array($item)) {
496
-            array_walk_recursive($item, function (&$value) {
496
+            array_walk_recursive($item, function(&$value) {
497 497
                 $value = htmlentities($value);
498 498
             });
499 499
         } else {
@@ -573,7 +573,7 @@  discard block
 block discarded – undo
573 573
      */
574 574
     protected function callSupportDisplayer($abstract, $arguments)
575 575
     {
576
-        return $this->display(function ($value) use ($abstract, $arguments) {
576
+        return $this->display(function($value) use ($abstract, $arguments) {
577 577
             if (is_array($value) || $value instanceof Arrayable) {
578 578
                 return call_user_func_array([collect($value), $abstract], $arguments);
579 579
             }
@@ -597,7 +597,7 @@  discard block
 block discarded – undo
597 597
     protected function callBuiltinDisplayer($abstract, $arguments)
598 598
     {
599 599
         if ($abstract instanceof Closure) {
600
-            return $this->display(function ($value) use ($abstract, $arguments) {
600
+            return $this->display(function($value) use ($abstract, $arguments) {
601 601
                 return $abstract->call($this, ...array_merge([$value], $arguments));
602 602
             });
603 603
         }
@@ -606,7 +606,7 @@  discard block
 block discarded – undo
606 606
             $grid = $this->grid;
607 607
             $column = $this;
608 608
 
609
-            return $this->display(function ($value) use ($abstract, $grid, $column, $arguments) {
609
+            return $this->display(function($value) use ($abstract, $grid, $column, $arguments) {
610 610
                 /** @var AbstractDisplayer $displayer */
611 611
                 $displayer = new $abstract($value, $grid, $column, $this);
612 612
 
Please login to merge, or discard this patch.
src/Form.php 1 patch
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -298,7 +298,7 @@  discard block
 block discarded – undo
298 298
      */
299 299
     public function destroy($id)
300 300
     {
301
-        collect(explode(',', $id))->filter()->each(function ($id) {
301
+        collect(explode(',', $id))->filter()->each(function($id) {
302 302
             $model = $this->model()->findOrFail($id);
303 303
 
304 304
             if ($model->trashed()) {
@@ -333,9 +333,9 @@  discard block
 block discarded – undo
333 333
             ->with($this->getRelations())
334 334
             ->findOrFail($id)->toArray();
335 335
 
336
-        $this->builder->fields()->filter(function ($field) {
336
+        $this->builder->fields()->filter(function($field) {
337 337
             return $field instanceof Field\File;
338
-        })->each(function (Field\File $file) use ($data) {
338
+        })->each(function(Field\File $file) use ($data) {
339 339
             $file->setOriginal($data);
340 340
 
341 341
             $file->destroy();
@@ -360,7 +360,7 @@  discard block
 block discarded – undo
360 360
             return $response;
361 361
         }
362 362
 
363
-        DB::transaction(function () {
363
+        DB::transaction(function() {
364 364
             $inserts = $this->prepareInsert($this->updates);
365 365
 
366 366
             foreach ($inserts as $column => $value) {
@@ -563,7 +563,7 @@  discard block
 block discarded – undo
563 563
             return $response;
564 564
         }
565 565
 
566
-        DB::transaction(function () {
566
+        DB::transaction(function() {
567 567
             $updates = $this->prepareUpdate($this->updates);
568 568
 
569 569
             foreach ($updates as $column => $value) {
@@ -1032,7 +1032,7 @@  discard block
 block discarded – undo
1032 1032
     protected function getFieldByColumn($column)
1033 1033
     {
1034 1034
         return $this->builder->fields()->first(
1035
-            function (Field $field) use ($column) {
1035
+            function(Field $field) use ($column) {
1036 1036
                 if (is_array($field->column())) {
1037 1037
                     return in_array($column, $field->column());
1038 1038
                 }
@@ -1053,7 +1053,7 @@  discard block
 block discarded – undo
1053 1053
 
1054 1054
         $values = $this->model->toArray();
1055 1055
 
1056
-        $this->builder->fields()->each(function (Field $field) use ($values) {
1056
+        $this->builder->fields()->each(function(Field $field) use ($values) {
1057 1057
             $field->setOriginal($values);
1058 1058
         });
1059 1059
     }
@@ -1077,7 +1077,7 @@  discard block
 block discarded – undo
1077 1077
 
1078 1078
         $data = $this->model->toArray();
1079 1079
 
1080
-        $this->builder->fields()->each(function (Field $field) use ($data) {
1080
+        $this->builder->fields()->each(function(Field $field) use ($data) {
1081 1081
             if (!in_array($field->column(), $this->ignored)) {
1082 1082
                 $field->fill($data);
1083 1083
             }
@@ -1200,7 +1200,7 @@  discard block
 block discarded – undo
1200 1200
      */
1201 1201
     public function setWidth($fieldWidth = 8, $labelWidth = 2)
1202 1202
     {
1203
-        $this->builder()->fields()->each(function ($field) use ($fieldWidth, $labelWidth) {
1203
+        $this->builder()->fields()->each(function($field) use ($fieldWidth, $labelWidth) {
1204 1204
             /* @var Field $field  */
1205 1205
             $field->setWidth($fieldWidth, $labelWidth);
1206 1206
         });
Please login to merge, or discard this patch.