Select::load() - Code Metrics - Inspection of "Upgrade And Some Fixes" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#4171)

by Muhlis

created 2019-11-22 22:37 UTC

Select::load() B

↳ Parent: Select

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	2
nop	5
dl	0
loc	57
rs	8.9381
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Encore\Admin\Form\Field;

use Encore\Admin\Facades\Admin;
use Encore\Admin\Form\Field;
use Illuminate\Contracts\Support\Arrayable;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Support\Arr;
use Illuminate\Support\Str;

class Select extends Field
{
    /**
     * @var array
     */
    protected static $css = [
        '/vendor/laravel-admin/AdminLTE/plugins/select2/select2.min.css',
    ];
    /**
     * @var array
     */
    protected static $js = [
        '/vendor/laravel-admin/AdminLTE/plugins/select2/select2.full.min.js',
    ];
    /**
     * @var array
     */
    protected $groups = [];
    /**
     * @var array
     */
    protected $config = [];

    /**
     * Set options.
     *
     * @param array|callable|string $options
     *
     * @return $this|mixed
     */
    public function options($options = [])
    {
        // remote options
        if (is_string($options)) {
            // reload selected
            if (class_exists($options) && in_array(Model::class, class_parents($options))) {
                return $this->model(...func_get_args());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            }

            return $this->loadRemoteOptions(...func_get_args());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
        if ($options instanceof Arrayable) {
            $options = $options->toArray();
        }
        if (is_callable($options)) {
            $this->options = $options;

        } else {
            $this->options = (array) $options;
        }

        return $this;
    }

    /**
     * @param array $groups
     */

    /**
     * Set option groups.
     *
     * eg: $group = [
     *        [
     *        'label' => 'xxxx',
     *        'options' => [
     *            1 => 'foo',
     *            2 => 'bar',
     *            ...
     *        ],
     *        ...
     *     ]
     *
     * @param array $groups
     *
     * @return $this
     */
    public function groups(array $groups)
    {
        $this->groups = $groups;

        return $this;
    }

    /**
     * Load options for other select on change.
     *
     * @param string $field
     * @param string $sourceUrl
     * @param string $idField
     * @param string $textField
     *
     * @return $this
     */
    public function load($field, $sourceUrl, $idField = 'id', $textField = 'text', bool $allowClear = true)
    {
        if (Str::contains($field, '.')) {
            $field = $this->formatName($field);
            $class = str_replace(['[', ']'], '_', $field);
        } else {
            $class = $field;
        }
        $placeholder = json_encode([
            'id'   => '',
            'text' => trans('admin.choose'),
        ]);
        $script = <<<JS
$(document).off('change', "{$this->getElementClassSelector()}");
$(document).on('change', "{$this->getElementClassSelector()}", function () {
    var target = $(this).closest('.fields-group').find(".$class");
    var targetValue = $(target).attr('data-value');
    var query=this.value;
    $.ajax({
        url:"$sourceUrl",
        dataType:'json',
        type:'GET',
        data:{
            q:query
        },
        success:function(data) {
          target.find("option").remove();
          target.append('<option value=""></option>');
          var select2 = $(target).select2({
                placeholder: $placeholder,
                allowClear: $allowClear,               
                data: $.map(data, function (d) {
                    d.id = d.{$idField};
                    d.text = d.{$textField};
                    return d;
                })
            })
        var isInDataList = data.filter(function(d) {
            return d.id == targetValue;
        }).length > 0;
        if(targetValue && isInDataList ) {
            select2.val(targetValue);
        }
        select2.trigger('change');
        }
    });
});
$("{$this->getElementClassSelector()}").each(function(){
     if ($(this).data('value')) {
         $(this).trigger('change');
     }
});
JS;
        Admin::script($script);

        return $this;
    }

    /**
     * Load options for other selects on change.
     *
     * @param array  $fields
     * @param array  $sourceUrls
     * @param string $idField
     * @param string $textField
     *
     * @return $this
     */
    public function loads($fields = [], $sourceUrls = [], $idField = 'id', $textField = 'text', bool $allowClear = true)
    {
        $fieldsStr = implode('.', $fields);
        $urlsStr = implode('^', $sourceUrls);
        $placeholder = json_encode([
            'id'   => '',
            'text' => trans('admin.choose'),
        ]);
        $script = <<<JS
var fields = '$fieldsStr'.split('.');
var urls = '$urlsStr'.split('^');
var refreshOptions = function(url, target) {
    $.ajax({
        url:url,
        dataType:'json',
        success:function(data) {
          target.find("option").remove();
          target.append('<option value=""></option>');
            $(target).select2({
                placeholder: $placeholder,
                allowClear: $allowClear,               
                data: $.map(data, function (d) {
                    d.id = d.{$idField};
                    d.text = d.{$textField};
                    return d;
                })
            }).trigger('change');
        }
    });
};
$(document).off('change', "{$this->getElementClassSelector()}");
$(document).on('change', "{$this->getElementClassSelector()}", function () {
    var _this = this;
    var promises = [];
    fields.forEach(function(field, index){
        var target = $(_this).closest('.fields-group').find('.' + fields[index]);
        promises.push(refreshOptions(urls[index] + "?q="+ _this.value, target));
    });
});
JS;
        Admin::script($script);

        return $this;
    }

    /**
     * Load options from current selected resource(s).
     *
     * @param string $model
     * @param string $idField
     * @param string $textField
     *
     * @return $this
     */
    public function model($model, $idField = 'id', $textField = 'name')

    {
        if (
            !class_exists($model)
            || !in_array(Model::class, class_parents($model))
        ) {
            throw new \InvalidArgumentException("[$model] must be a valid model class");
        }
        $this->options = function ($value) use ($model, $idField, $textField) {

            if (empty($value)) {
                return [];
            }
            $resources = [];
            if (is_array($value)) {
                if (Arr::isAssoc($value)) {
                    $resources[] = Arr::get($value, $idField);
                } else {
                    $resources = array_column($value, $idField);
                }
            } else {
                $resources[] = $value;
            }

            return $model::find($resources)->pluck($textField, $idField)->toArray();
        };

        return $this;
    }

    /**
     * Load options from remote.
     *
     * @param string $url
     * @param array  $parameters
     * @param array  $options
     *
     * @return $this
     */
    protected function loadRemoteOptions($url, $parameters = [], $options = [])
    {
        $ajaxOptions = [
            'url' => $url.'?'.http_build_query($parameters),
        ];
        $configs = array_merge([
            'allowClear'         => true,
            'placeholder'        => [
                'id'        => '',
                'text'      => trans('admin.choose'),
            ],
        ], $this->config);
        $configs = json_encode($configs);
        $configs = substr($configs, 1, strlen($configs) - 2);
        $ajaxOptions = json_encode(array_merge($ajaxOptions, $options));
        $this->script = <<<EOT
$.ajax($ajaxOptions).done(function(data) {
  $("{$this->getElementClassSelector()}").each(function(index, element) {
      $(element).select2({
        data: data,
        $configs
      });
      var value = $(element).data('value') + '';
      if (value) {
        value = value.split(',');
        $(element).select2('val', value);
      }
  });
});
EOT;

        return $this;
    }

    /**
     * Load options from ajax results.
     *
     * @param string $url
     * @param $idField
     * @param $textField
     *
     * @return $this
     */
    public function ajax($url, $idField = 'id', $textField = 'text')

    {
        $configs = array_merge([
            'allowClear'         => true,
            'placeholder'        => $this->label,
            'minimumInputLength' => 1,
        ], $this->config);
        $configs = json_encode($configs);
        $configs = substr($configs, 1, strlen($configs) - 2);
        $this->script = <<<EOT
$("{$this->getElementClassSelector()}").select2({
  ajax: {
    url: "$url",
    dataType: 'json',
    delay: 250,
    data: function (params) {
      return {
        q: params.term,
        page: params.page
      };
    },
    processResults: function (data, params) {
      params.page = params.page || 1;
      return {
        results: $.map(data.data, function (d) {
                   d.id = d.$idField;
                   d.text = d.$textField;
                   return d;
                }),
        pagination: {
          more: data.next_page_url
        }
      };
    },
    cache: true
  },
  $configs,
  escapeMarkup: function (markup) {
      return markup;
  }
});
EOT;

        return $this;
    }

    /**
     * Set config for select2.
     *
     * all configurations see https://select2.org/configuration/options-api
     *
     * @param string $key
     * @param mixed  $val
     *
     * @return $this
     */
    public function config($key, $val)
    {
        $this->config[$key] = $val;

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function readOnly()
    {
        //移除特定字段名称,增加MultipleSelect的修订
        //没有特定字段名可以使多个readonly的JS代码片段被Admin::script的array_unique精简代码
        $script = <<<'EOT'
$("form select").on("select2:opening", function (e) {
    if($(this).attr('readonly') || $(this).is(':hidden')){
    e.preventDefault();
    }
});
$(document).ready(function(){
    $('select').each(function(){
        if($(this).is('[readonly]')){
            $(this).closest('.form-group').find('span.select2-selection__choice__remove').first().remove();
            $(this).closest('.form-group').find('li.select2-search').first().remove();
            $(this).closest('.form-group').find('span.select2-selection__clear').first().remove();
        }
    });
});
EOT;
        Admin::script($script);

        return parent::readOnly();
    }

    /**
     * {@inheritdoc}
     */
    public function render()
    {
        $configs = array_merge([
            'allowClear'  => true,
            'placeholder' => [
                'id'   => '',
                'text' => $this->label,
            ],
        ], $this->config);
        $configs = json_encode($configs);
        if (empty($this->script)) {
            $this->script = "$(\"{$this->getElementClassSelector()}\").select2($configs);";
        }
        if ($this->options instanceof \Closure) {
            if ($this->form) {
                $this->options = $this->options->bindTo($this->form->model());
            }
            $this->options(call_user_func($this->options, $this->value, $this));
        }
        $this->options = array_filter($this->options, 'strlen');
        $this->addVariables([
            'options' => $this->options,
            'groups'  => $this->groups,
        ]);
        $this->attribute('data-value', implode(',', (array) $this->value()));

        return parent::render();

    }
}


1		<?php
2
3		namespace Encore\Admin\Form\Field;
4
5		use Encore\Admin\Facades\Admin;
6		use Encore\Admin\Form\Field;
7		use Illuminate\Contracts\Support\Arrayable;
8		use Illuminate\Database\Eloquent\Model;
9		use Illuminate\Support\Arr;
10		use Illuminate\Support\Str;
11
12		class Select extends Field
13		{
14		/**
15		* @var array
16		*/
17		protected static $css = [
18		'/vendor/laravel-admin/AdminLTE/plugins/select2/select2.min.css',
19		];
20		/**
21		* @var array
22		*/
23		protected static $js = [
24		'/vendor/laravel-admin/AdminLTE/plugins/select2/select2.full.min.js',
25		];
26		/**
27		* @var array
28		*/
29		protected $groups = [];
30		/**
31		* @var array
32		*/
33		protected $config = [];
34
35		/**
36		* Set options.
37		*
38		* @param array\|callable\|string $options
39		*
40		* @return $this\|mixed
41		*/
42		public function options($options = [])
43		{
44		// remote options
45		if (is_string($options)) {
46		// reload selected
47		if (class_exists($options) && in_array(Model::class, class_parents($options))) {
48		return $this->model(...func_get_args());
		0 ignored issues – show Documentation introduced 2018-08-29 04:54 UTC by Report Bug Copy Issue Report `func_get_args()` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
49		}
50
51		return $this->loadRemoteOptions(...func_get_args());
		0 ignored issues – show Documentation introduced 2017-12-12 02:16 UTC by Report Bug Copy Issue Report `func_get_args()` is of type `array`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52		}
53		if ($options instanceof Arrayable) {
54		$options = $options->toArray();
55		}
56		if (is_callable($options)) {
57		$this->options = $options;
		0 ignored issues – show Documentation Bug introduced 2016-10-27 10:11 UTC by Report Bug Copy Issue Report It seems like `$options` of type `callable` is incompatible with the declared type `array` of property `$options`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
58		} else {
59		$this->options = (array) $options;
60		}
61
62		return $this;
63		}
64
65		/**
66		* @param array $groups
67		*/
68
69		/**
70		* Set option groups.
71		*
72		* eg: $group = [
73		* [
74		* 'label' => 'xxxx',
75		* 'options' => [
76		* 1 => 'foo',
77		* 2 => 'bar',
78		* ...
79		* ],
80		* ...
81		* ]
82		*
83		* @param array $groups
84		*
85		* @return $this
86		*/
87		public function groups(array $groups)
88		{
89		$this->groups = $groups;
90
91		return $this;
92		}
93
94		/**
95		* Load options for other select on change.
96		*
97		* @param string $field
98		* @param string $sourceUrl
99		* @param string $idField
100		* @param string $textField
101		*
102		* @return $this
103		*/
104		public function load($field, $sourceUrl, $idField = 'id', $textField = 'text', bool $allowClear = true)
105		{
106		if (Str::contains($field, '.')) {
107		$field = $this->formatName($field);
108		$class = str_replace(['[', ']'], '_', $field);
109		} else {
110		$class = $field;
111		}
112		$placeholder = json_encode([
113		'id' => '',
114		'text' => trans('admin.choose'),
115		]);
116		$script = <<<JS
117		$(document).off('change', "{$this->getElementClassSelector()}");
118		$(document).on('change', "{$this->getElementClassSelector()}", function () {
119		var target = $(this).closest('.fields-group').find(".$class");
120		var targetValue = $(target).attr('data-value');
121		var query=this.value;
122		$.ajax({
123		url:"$sourceUrl",
124		dataType:'json',
125		type:'GET',
126		data:{
127		q:query
128		},
129		success:function(data) {
130		target.find("option").remove();
131		target.append('<option value=""></option>');
132		var select2 = $(target).select2({
133		placeholder: $placeholder,
134		allowClear: $allowClear,
135		data: $.map(data, function (d) {
136		d.id = d.{$idField};
137		d.text = d.{$textField};
138		return d;
139		})
140		})
141		var isInDataList = data.filter(function(d) {
142		return d.id == targetValue;
143		}).length > 0;
144		if(targetValue && isInDataList ) {
145		select2.val(targetValue);
146		}
147		select2.trigger('change');
148		}
149		});
150		});
151		$("{$this->getElementClassSelector()}").each(function(){
152		if ($(this).data('value')) {
153		$(this).trigger('change');
154		}
155		});
156		JS;
157		Admin::script($script);
158
159		return $this;
160		}
161
162		/**
163		* Load options for other selects on change.
164		*
165		* @param array $fields
166		* @param array $sourceUrls
167		* @param string $idField
168		* @param string $textField
169		*
170		* @return $this
171		*/
172		public function loads($fields = [], $sourceUrls = [], $idField = 'id', $textField = 'text', bool $allowClear = true)
173		{
174		$fieldsStr = implode('.', $fields);
175		$urlsStr = implode('^', $sourceUrls);
176		$placeholder = json_encode([
177		'id' => '',
178		'text' => trans('admin.choose'),
179		]);
180		$script = <<<JS
181		var fields = '$fieldsStr'.split('.');
182		var urls = '$urlsStr'.split('^');
183		var refreshOptions = function(url, target) {
184		$.ajax({
185		url:url,
186		dataType:'json',
187		success:function(data) {
188		target.find("option").remove();
189		target.append('<option value=""></option>');
190		$(target).select2({
191		placeholder: $placeholder,
192		allowClear: $allowClear,
193		data: $.map(data, function (d) {
194		d.id = d.{$idField};
195		d.text = d.{$textField};
196		return d;
197		})
198		}).trigger('change');
199		}
200		});
201		};
202		$(document).off('change', "{$this->getElementClassSelector()}");
203		$(document).on('change', "{$this->getElementClassSelector()}", function () {
204		var _this = this;
205		var promises = [];
206		fields.forEach(function(field, index){
207		var target = $(_this).closest('.fields-group').find('.' + fields[index]);
208		promises.push(refreshOptions(urls[index] + "?q="+ _this.value, target));
209		});
210		});
211		JS;
212		Admin::script($script);
213
214		return $this;
215		}
216
217		/**
218		* Load options from current selected resource(s).
219		*
220		* @param string $model
221		* @param string $idField
222		* @param string $textField
223		*
224		* @return $this
225		*/
226	View Code Duplication	public function model($model, $idField = 'id', $textField = 'name')
		0 ignored issues – show Duplication introduced 2018-08-28 22:33 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
227		{
228		if (
229		!class_exists($model)
230		\|\| !in_array(Model::class, class_parents($model))
231		) {
232		throw new \InvalidArgumentException("[$model] must be a valid model class");
233		}
234		$this->options = function ($value) use ($model, $idField, $textField) {
		0 ignored issues – show Documentation Bug introduced 2019-04-25 08:08 UTC by Report Bug Copy Issue Report It seems like `function ($value) use($m...$idField)->toArray(); }` of type `object<Closure>` is incompatible with the declared type `array` of property `$options`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
235		if (empty($value)) {
236		return [];
237		}
238		$resources = [];
239		if (is_array($value)) {
240		if (Arr::isAssoc($value)) {
241		$resources[] = Arr::get($value, $idField);
242		} else {
243		$resources = array_column($value, $idField);
244		}
245		} else {
246		$resources[] = $value;
247		}
248
249		return $model::find($resources)->pluck($textField, $idField)->toArray();
250		};
251
252		return $this;
253		}
254
255		/**
256		* Load options from remote.
257		*
258		* @param string $url
259		* @param array $parameters
260		* @param array $options
261		*
262		* @return $this
263		*/
264		protected function loadRemoteOptions($url, $parameters = [], $options = [])
265		{
266		$ajaxOptions = [
267		'url' => $url.'?'.http_build_query($parameters),
268		];
269		$configs = array_merge([
270		'allowClear' => true,
271		'placeholder' => [
272		'id' => '',
273		'text' => trans('admin.choose'),
274		],
275		], $this->config);
276		$configs = json_encode($configs);
277		$configs = substr($configs, 1, strlen($configs) - 2);
278		$ajaxOptions = json_encode(array_merge($ajaxOptions, $options));
279		$this->script = <<<EOT
280		$.ajax($ajaxOptions).done(function(data) {
281		$("{$this->getElementClassSelector()}").each(function(index, element) {
282		$(element).select2({
283		data: data,
284		$configs
285		});
286		var value = $(element).data('value') + '';
287		if (value) {
288		value = value.split(',');
289		$(element).select2('val', value);
290		}
291		});
292		});
293		EOT;
294
295		return $this;
296		}
297
298		/**
299		* Load options from ajax results.
300		*
301		* @param string $url
302		* @param $idField
303		* @param $textField
304		*
305		* @return $this
306		*/
307	View Code Duplication	public function ajax($url, $idField = 'id', $textField = 'text')
		0 ignored issues – show Duplication introduced 2017-10-24 15:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
308		{
309		$configs = array_merge([
310		'allowClear' => true,
311		'placeholder' => $this->label,
312		'minimumInputLength' => 1,
313		], $this->config);
314		$configs = json_encode($configs);
315		$configs = substr($configs, 1, strlen($configs) - 2);
316		$this->script = <<<EOT
317		$("{$this->getElementClassSelector()}").select2({
318		ajax: {
319		url: "$url",
320		dataType: 'json',
321		delay: 250,
322		data: function (params) {
323		return {
324		q: params.term,
325		page: params.page
326		};
327		},
328		processResults: function (data, params) {
329		params.page = params.page \|\| 1;
330		return {
331		results: $.map(data.data, function (d) {
332		d.id = d.$idField;
333		d.text = d.$textField;
334		return d;
335		}),
336		pagination: {
337		more: data.next_page_url
338		}
339		};
340		},
341		cache: true
342		},
343		$configs,
344		escapeMarkup: function (markup) {
345		return markup;
346		}
347		});
348		EOT;
349
350		return $this;
351		}
352
353		/**
354		* Set config for select2.
355		*
356		* all configurations see https://select2.org/configuration/options-api
357		*
358		* @param string $key
359		* @param mixed $val
360		*
361		* @return $this
362		*/
363		public function config($key, $val)
364		{
365		$this->config[$key] = $val;
366
367		return $this;
368		}
369
370		/**
371		* {@inheritdoc}
372		*/
373		public function readOnly()
374		{
375		//移除特定字段名称,增加MultipleSelect的修订
376		//没有特定字段名可以使多个readonly的JS代码片段被Admin::script的array_unique精简代码
377		$script = <<<'EOT'
378		$("form select").on("select2:opening", function (e) {
379		if($(this).attr('readonly') \|\| $(this).is(':hidden')){
380		e.preventDefault();
381		}
382		});
383		$(document).ready(function(){
384		$('select').each(function(){
385		if($(this).is('[readonly]')){
386		$(this).closest('.form-group').find('span.select2-selection__choice__remove').first().remove();
387		$(this).closest('.form-group').find('li.select2-search').first().remove();
388		$(this).closest('.form-group').find('span.select2-selection__clear').first().remove();
389		}
390		});
391		});
392		EOT;
393		Admin::script($script);
394
395		return parent::readOnly();
396		}
397
398		/**
399		* {@inheritdoc}
400		*/
401		public function render()
402		{
403		$configs = array_merge([
404		'allowClear' => true,
405		'placeholder' => [
406		'id' => '',
407		'text' => $this->label,
408		],
409		], $this->config);
410		$configs = json_encode($configs);
411		if (empty($this->script)) {
412		$this->script = "$(\"{$this->getElementClassSelector()}\").select2($configs);";
413		}
414		if ($this->options instanceof \Closure) {
415		if ($this->form) {
416		$this->options = $this->options->bindTo($this->form->model());
417		}
418		$this->options(call_user_func($this->options, $this->value, $this));
419		}
420		$this->options = array_filter($this->options, 'strlen');
421		$this->addVariables([
422		'options' => $this->options,
423		'groups' => $this->groups,
424		]);
425		$this->attribute('data-value', implode(',', (array) $this->value()));
426
427		return parent::render();
		0 ignored issues – show Bug Compatibility introduced 2018-08-23 10:05 UTC by Report Bug Copy Issue Report The expression `parent::render();` of type `string\|Illuminate\View\V...\Contracts\View\Factory` adds the type `Illuminate\Contracts\View\Factory` to the return on line 427 which is incompatible with the return type declared by the interface `Illuminate\Contracts\Support\Renderable::render` of type `string`. Loading history...
428		}
429		}
430

z-song / laravel-admin

Pull Request — master (#4171)

Select::load() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like