Editor::__construct() - Code Metrics - Inspection of "some useful future my Commits on Oct 24, 2017" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1350)

unknown

created 2018-03-06 18:25 UTC

Editor::__construct() A

↳ Parent: Editor

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	5
nc	1
nop	2
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0

<?php

namespace Encore\Admin\Form\Field;

use Encore\Admin\Form\Field;

/**
 * add class 'ckeditor' for each ckeditor if you want jquery validation
 * Class Editor
 * @package Encore\Admin\Form\Field
 */
class Editor extends Field
{
    protected static $js = [
        '/js/plugins/ckeditor/ckeditor.js',
//        '//cdn.ckeditor.com/4.5.10/standard/ckeditor.js',
    ];

    public function __construct($column, array $arguments = [])
    {
        parent::__construct($column, $arguments);

        $this->options(['contentsLangDirection' => 'ltr']);
        $this->options(['language' => config('app.locale', 'en')]);
        //for jquery validation
        $this->addElementClass(['validate','ckeditor']);

    }

    /**
     * set `direction` .
     * https://docs-old.ckeditor.com/ckeditor_api/symbols/CKEDITOR.config.html#.contentsLangDirection
     * 'ui' – indicates that content direction will be the same as the user interface language direction;
     * 'ltr' – for Left-To-Right language (like English);
     * 'rtl' – for Right-To-Left languages (like Arabic).
     * @param string $dir
     * @return $this
     */
    public function direction($dir ='ltr')
    {
         $this->options(['contentsLangDirection' => $dir]);
        $this->direction = $dir;

        return $this;    }

    /**
     * set language for editor
     * @param string $dir
     * @return $this
     */
    public function lang($dir)
    {
        return $this->options(['language' => $dir]);
    }

    public function render()

    {
        $options = json_encode($this->options);
        $this->script = "CKEDITOR.replace('{$this->column}', $options);";

        return parent::render();

    }
}


1		<?php
2
3		namespace Encore\Admin\Form\Field;
4
5		use Encore\Admin\Form\Field;
6
7		/**
8		* add class 'ckeditor' for each ckeditor if you want jquery validation
9		* Class Editor
10		* @package Encore\Admin\Form\Field
11		*/
12		class Editor extends Field
13		{
14		protected static $js = [
15		'/js/plugins/ckeditor/ckeditor.js',
16		// '//cdn.ckeditor.com/4.5.10/standard/ckeditor.js',
17		];
18
19		public function __construct($column, array $arguments = [])
20		{
21		parent::__construct($column, $arguments);
22
23		$this->options(['contentsLangDirection' => 'ltr']);
24		$this->options(['language' => config('app.locale', 'en')]);
25		//for jquery validation
26		$this->addElementClass(['validate','ckeditor']);
27
28		}
29
30		/**
31		* set `direction` .
32		* https://docs-old.ckeditor.com/ckeditor_api/symbols/CKEDITOR.config.html#.contentsLangDirection
33		* 'ui' – indicates that content direction will be the same as the user interface language direction;
34		* 'ltr' – for Left-To-Right language (like English);
35		* 'rtl' – for Right-To-Left languages (like Arabic).
36		* @param string $dir
37		* @return $this
38		*/
39		public function direction($dir ='ltr')
40		{
41		$this->options(['contentsLangDirection' => $dir]);
42		$this->direction = $dir;
43
44		return $this; }
45
46		/**
47		* set language for editor
48		* @param string $dir
49		* @return $this
50		*/
51		public function lang($dir)
52		{
53		return $this->options(['language' => $dir]);
54		}
55
56	View Code Duplication	public function render()
		0 ignored issues – show Duplication introduced 2017-10-24 15:02 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		{
58		$options = json_encode($this->options);
59		$this->script = "CKEDITOR.replace('{$this->column}', $options);";
60
61		return parent::render();
		0 ignored issues – show Bug Compatibility introduced 2017-09-01 02:27 UTC by Report Bug Copy Issue Report The expression `parent::render();` of type `Illuminate\View\View\|Ill...\Contracts\View\Factory` adds the type `Illuminate\Contracts\View\Factory` to the return on line 61 which is incompatible with the return type declared by the interface `Illuminate\Contracts\Support\Renderable::render` of type `string`. Loading history...
62		}
63		}
64

z-song / laravel-admin

Pull Request — master (#1350)

Editor::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like