AdminController - Code Metrics - Inspection of "wip" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fbfcb9...4fd533 )

by Song

created 2019-05-17 10:52 UTC

AdminController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
dl	0
loc	95
rs	10
c	0
b	0
f	0
wmc	5
lcom	1
cbo	3

5 Methods

Rating	Name	Size	Complexity
A	title()	4	1
A	index()	7	1
A	show()	7	1
A	edit()	7	1
A	create()	7	1

<?php

namespace Encore\Admin\Controllers;

use Encore\Admin\Layout\Content;
use Illuminate\Routing\Controller;

class AdminController extends Controller
{
    use HasResourceActions;

    /**
     * Title for current resource.
     *
     * @var string
     */
    protected $title = 'Title';

    /**
     * Set description for following 4 action pages.
     *
     * @var array
     */
    protected $description = [
//        'index'  => 'Index',
//        'show'   => 'Show',
//        'edit'   => 'Edit',
//        'create' => 'Create',
    ];

    /**
     * Get content title.
     *
     * @return string
     */
    protected function title()
    {
        return $this->title;
    }

    /**
     * Index interface.
     *
     * @param Content $content
     *
     * @return Content
     */
    public function index(Content $content)
    {
        return $content
            ->title($this->title())
            ->description($this->description['index'] ?? trans('admin.list'))
            ->body($this->grid());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * Show interface.
     *
     * @param mixed   $id
     * @param Content $content
     *
     * @return Content
     */
    public function show($id, Content $content)
    {
        return $content
            ->title($this->title())
            ->description($this->description['show'] ?? trans('admin.show'))
            ->body($this->detail($id));
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * Edit interface.
     *
     * @param mixed   $id
     * @param Content $content
     *
     * @return Content
     */
    public function edit($id, Content $content)
    {
        return $content
            ->title($this->title())
            ->description($this->description['edit'] ?? trans('admin.edit'))
            ->body($this->form()->edit($id));
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * Create interface.
     *
     * @param Content $content
     *
     * @return Content
     */
    public function create(Content $content)
    {
        return $content
            ->title($this->title())
            ->description($this->description['create'] ?? trans('admin.create'))
            ->body($this->form());
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }
}


1			<?php
2
3			namespace Encore\Admin\Controllers;
4
5			use Encore\Admin\Layout\Content;
6			use Illuminate\Routing\Controller;
7
8			class AdminController extends Controller
9			{
10			use HasResourceActions;
11
12			/**
13			* Title for current resource.
14			*
15			* @var string
16			*/
17			protected $title = 'Title';
18
19			/**
20			* Set description for following 4 action pages.
21			*
22			* @var array
23			*/
24			protected $description = [
25			// 'index' => 'Index',
26			// 'show' => 'Show',
27			// 'edit' => 'Edit',
28			// 'create' => 'Create',
29			];
30
31			/**
32			* Get content title.
33			*
34			* @return string
35			*/
36			protected function title()
37			{
38			return $this->title;
39			}
40
41			/**
42			* Index interface.
43			*
44			* @param Content $content
45			*
46			* @return Content
47			*/
48			public function index(Content $content)
49			{
50			return $content
51			->title($this->title())
52			->description($this->description['index'] ?? trans('admin.list'))
53			->body($this->grid());
			0 ignored issues – show Documentation Bug introduced 2019-05-16 13:00 UTC by Report Bug Copy Issue Report The method `grid` does not exist on `object<Encore\Admin\Controllers\AdminController>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
54			}
55
56			/**
57			* Show interface.
58			*
59			* @param mixed $id
60			* @param Content $content
61			*
62			* @return Content
63			*/
64			public function show($id, Content $content)
65			{
66			return $content
67			->title($this->title())
68			->description($this->description['show'] ?? trans('admin.show'))
69			->body($this->detail($id));
			0 ignored issues – show Documentation Bug introduced 2019-05-16 13:00 UTC by Report Bug Copy Issue Report The method `detail` does not exist on `object<Encore\Admin\Controllers\AdminController>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
70			}
71
72			/**
73			* Edit interface.
74			*
75			* @param mixed $id
76			* @param Content $content
77			*
78			* @return Content
79			*/
80			public function edit($id, Content $content)
81			{
82			return $content
83			->title($this->title())
84			->description($this->description['edit'] ?? trans('admin.edit'))
85			->body($this->form()->edit($id));
			0 ignored issues – show Documentation Bug introduced 2019-05-16 13:00 UTC by Report Bug Copy Issue Report The method `form` does not exist on `object<Encore\Admin\Controllers\AdminController>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
86			}
87
88			/**
89			* Create interface.
90			*
91			* @param Content $content
92			*
93			* @return Content
94			*/
95			public function create(Content $content)
96			{
97			return $content
98			->title($this->title())
99			->description($this->description['create'] ?? trans('admin.create'))
100			->body($this->form());
			0 ignored issues – show Documentation Bug introduced 2019-05-16 13:00 UTC by Report Bug Copy Issue Report The method `form` does not exist on `object<Encore\Admin\Controllers\AdminController>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
101			}
102			}
103

z-song / laravel-admin

Push — master ( fbfcb9...4fd533 )

AdminController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like