Completed
Pull Request — master (#2484)
by jxlwqq
21:55
created
src/Auth/Database/Role.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@
 block discarded – undo
86 86
     {
87 87
         parent::boot();
88 88
 
89
-        static::deleting(function ($model) {
89
+        static::deleting(function($model) {
90 90
             $model->administrators()->detach();
91 91
 
92 92
             $model->permissions()->detach();
Please login to merge, or discard this patch.
src/Auth/Database/Permission.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
         $method = $this->http_method;
68 68
 
69
-        $matches = array_map(function ($path) use ($method) {
69
+        $matches = array_map(function($path) use ($method) {
70 70
             $path = trim(config('admin.route.prefix'), '/').$path;
71 71
 
72 72
             if (Str::contains($path, ':')) {
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
             return false;
101 101
         }
102 102
 
103
-        $method = collect($match['method'])->filter()->map(function ($method) {
103
+        $method = collect($match['method'])->filter()->map(function($method) {
104 104
             return strtoupper($method);
105 105
         });
106 106
 
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
     {
141 141
         parent::boot();
142 142
 
143
-        static::deleting(function ($model) {
143
+        static::deleting(function($model) {
144 144
             $model->roles()->detach();
145 145
         });
146 146
     }
Please login to merge, or discard this patch.
src/Auth/Database/Menu.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@
 block discarded – undo
78 78
     {
79 79
         static::treeBoot();
80 80
 
81
-        static::deleting(function ($model) {
81
+        static::deleting(function($model) {
82 82
             $model->roles()->detach();
83 83
         });
84 84
     }
Please login to merge, or discard this patch.
src/Form/Field.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -202,7 +202,7 @@  discard block
 block discarded – undo
202 202
     /**
203 203
      * Field constructor.
204 204
      *
205
-     * @param       $column
205
+     * @param       string $column
206 206
      * @param array $arguments
207 207
      */
208 208
     public function __construct($column, $arguments = [])
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
     /**
402 402
      * Get or set rules.
403 403
      *
404
-     * @param null  $rules
404
+     * @param string  $rules
405 405
      * @param array $messages
406 406
      *
407 407
      * @return $this
@@ -494,7 +494,7 @@  discard block
 block discarded – undo
494 494
     /**
495 495
      * Set or get value of the field.
496 496
      *
497
-     * @param null $value
497
+     * @param string $value
498 498
      *
499 499
      * @return mixed
500 500
      */
@@ -647,7 +647,7 @@  discard block
 block discarded – undo
647 647
     /**
648 648
      * Add html attributes to elements.
649 649
      *
650
-     * @param array|string $attribute
650
+     * @param string $attribute
651 651
      * @param mixed        $value
652 652
      *
653 653
      * @return $this
Please login to merge, or discard this patch.
src/Grid/HasElementNames.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -107,6 +107,7 @@
 block discarded – undo
107 107
     }
108 108
 
109 109
     /**
110
+     * @param string $name
110 111
      * @return string
111 112
      */
112 113
     protected function elementNameWithPrefix($name)
Please login to merge, or discard this patch.
src/Show.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -317,7 +317,7 @@
 block discarded – undo
317 317
      * @param string $method
318 318
      * @param array  $arguments
319 319
      *
320
-     * @return bool|mixed
320
+     * @return Field
321 321
      */
322 322
     public function __call($method, $arguments = [])
323 323
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -183,7 +183,7 @@  discard block
 block discarded – undo
183 183
 
184 184
         $this->overwriteExistingField($name);
185 185
 
186
-        return tap($field, function ($field) {
186
+        return tap($field, function($field) {
187 187
             $this->fields->push($field);
188 188
         });
189 189
     }
@@ -205,7 +205,7 @@  discard block
 block discarded – undo
205 205
 
206 206
         $this->overwriteExistingRelation($name);
207 207
 
208
-        return tap($relation, function ($relation) {
208
+        return tap($relation, function($relation) {
209 209
             $this->relations->push($relation);
210 210
         });
211 211
     }
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
         }
223 223
 
224 224
         $this->fields = $this->fields->filter(
225
-            function (Field $field) use ($name) {
225
+            function(Field $field) use ($name) {
226 226
                 return $field->getName() != $name;
227 227
             }
228 228
         );
@@ -240,7 +240,7 @@  discard block
 block discarded – undo
240 240
         }
241 241
 
242 242
         $this->relations = $this->relations->filter(
243
-            function (Relation $relation) use ($name) {
243
+            function(Relation $relation) use ($name) {
244 244
                 return $relation->getName() != $name;
245 245
             }
246 246
         );
Please login to merge, or discard this patch.
src/Show/Field.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     /**
89 89
      * Get name of this column.
90 90
      *
91
-     * @return mixed
91
+     * @return string
92 92
      */
93 93
     public function getName()
94 94
     {
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     /**
113 113
      * Get label of the column.
114 114
      *
115
-     * @return mixed
115
+     * @return string
116 116
      */
117 117
     public function getLabel()
118 118
     {
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -172,7 +172,7 @@  discard block
 block discarded – undo
172 172
      */
173 173
     public function using(array $values, $default = null)
174 174
     {
175
-        return $this->as(function ($value) use ($values, $default) {
175
+        return $this->as(function($value) use ($values, $default) {
176 176
             if (is_null($value)) {
177 177
                 return $default;
178 178
             }
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
      */
193 193
     public function image($server = '', $width = 200, $height = 200)
194 194
     {
195
-        return $this->as(function ($path) use ($server, $width, $height) {
195
+        return $this->as(function($path) use ($server, $width, $height) {
196 196
             if (empty($path)) {
197 197
                 return '';
198 198
             }
@@ -227,7 +227,7 @@  discard block
 block discarded – undo
227 227
     {
228 228
         $field = $this;
229 229
 
230
-        return $this->as(function ($path) use ($server, $download, $field) {
230
+        return $this->as(function($path) use ($server, $download, $field) {
231 231
             $name = basename($path);
232 232
 
233 233
             $field->wrapped = false;
@@ -275,7 +275,7 @@  discard block
 block discarded – undo
275 275
      */
276 276
     public function link($href = '', $target = '_blank')
277 277
     {
278
-        return $this->as(function ($link) use ($href, $target) {
278
+        return $this->as(function($link) use ($href, $target) {
279 279
             $href = $href ?: $link;
280 280
 
281 281
             return "<a href='$href' target='{$target}'>{$link}</a>";
@@ -291,12 +291,12 @@  discard block
 block discarded – undo
291 291
      */
292 292
     public function label($style = 'success')
293 293
     {
294
-        return $this->as(function ($value) use ($style) {
294
+        return $this->as(function($value) use ($style) {
295 295
             if ($value instanceof Arrayable) {
296 296
                 $value = $value->toArray();
297 297
             }
298 298
 
299
-            return collect((array) $value)->map(function ($name) use ($style) {
299
+            return collect((array) $value)->map(function($name) use ($style) {
300 300
                 return "<span class='label label-{$style}'>$name</span>";
301 301
             })->implode('&nbsp;');
302 302
         });
@@ -311,12 +311,12 @@  discard block
 block discarded – undo
311 311
      */
312 312
     public function badge($style = 'blue')
313 313
     {
314
-        return $this->as(function ($value) use ($style) {
314
+        return $this->as(function($value) use ($style) {
315 315
             if ($value instanceof Arrayable) {
316 316
                 $value = $value->toArray();
317 317
             }
318 318
 
319
-            return collect((array) $value)->map(function ($name) use ($style) {
319
+            return collect((array) $value)->map(function($name) use ($style) {
320 320
                 return "<span class='badge bg-{$style}'>$name</span>";
321 321
             })->implode('&nbsp;');
322 322
         });
@@ -331,7 +331,7 @@  discard block
 block discarded – undo
331 331
     {
332 332
         $field = $this;
333 333
 
334
-        return $this->as(function ($value) use ($field) {
334
+        return $this->as(function($value) use ($field) {
335 335
             $content = json_decode($value, true);
336 336
 
337 337
             if (json_last_error() == 0) {
@@ -442,7 +442,7 @@  discard block
 block discarded – undo
442 442
     public function render()
443 443
     {
444 444
         if ($this->showAs->isNotEmpty()) {
445
-            $this->showAs->each(function ($callable) {
445
+            $this->showAs->each(function($callable) {
446 446
                 $this->value = $callable->call(
447 447
                     $this->parent->getModel(),
448 448
                     $this->value
Please login to merge, or discard this patch.
src/Show/Panel.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@
 block discarded – undo
138 138
     /**
139 139
      * Fill fields to panel.
140 140
      *
141
-     * @param []Field $fields
141
+     * @param Collection $fields
142 142
      *
143 143
      * @return $this
144 144
      */
Please login to merge, or discard this patch.
src/Grid/Tools/BatchActions.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
     /**
53 53
      * Add a batch action.
54 54
      *
55
-     * @param $title
55
+     * @param BatchDelete $title
56 56
      * @param BatchAction|null $action
57 57
      *
58 58
      * @return $this
Please login to merge, or discard this patch.