Select::addStyle() - Code Metrics - Inspection of "refactoring grid column select" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fe01b0...4ca583 )

by Song

created 2020-05-14 04:55 UTC

Select::addStyle() A

↳ Parent: Select

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	10
rs	9.9332
c	0
b	0
f	0

<?php

namespace Encore\Admin\Grid\Displayers;

use Encore\Admin\Admin;

class Select extends AbstractDisplayer
{
    protected function addScript()
    {
        $name = $this->column->getName();

        $class = "grid-select-{$name}";

        $script = <<<EOT

$('.$class .dropdown-menu li a').click(function () {
    var target = $(this);

    var text = target.text();
    var value = target.data('value');
    var key = target.parents('.$class').attr('key');

    $.ajax({
        url: "{$this->grid->resource()}/" + key,
        type: "POST",
        data: {
            $name: value,
            _token: LA.token,
            _method: 'PUT'
        },
        success: function (data) {
            target.parents('.$class').find('.select-text').text(text);

            target.parents('.dropdown-menu').find('li a').each(function () {
                if (value == $(this).data('value')) {
                    $(this).find('i').removeClass('invisible')
                } else {
                    $(this).find('i').addClass('invisible')
                }
            });

            toastr.success(data.message);
        }
    });
});

EOT;

        Admin::script($script);
    }

    protected function addStyle()
    {
        $style = <<<STYLE
.grid-select-{$this->column->getName()} .dropdown-menu {
    min-width: 0px;
}
STYLE;

        Admin::style($style);
    }

    public function display($options = [])
    {
        $this->addScript();
        $this->addStyle();

        $name = $this->column->getName();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if ($options instanceof \Closure) {
            $options = $options->call($this, $this->row);
        }

        $optionsHtml = '';

        foreach ($options as $option => $text) {
            $invisible = $option == $this->value ? '' : 'invisible';
            $optionsHtml .= "<li><a href='javascript:void(0);' data-value='{$option}'><i class=\"fa fa-check $invisible\"></i>{$text}</a></li>";
        }

        return <<<HTML
<div class="dropdown grid-select-{$this->column->getName()}" key="{$this->getKey()}">
  <a href="javascript:void(0);" class="dropdown-toggle" data-toggle="dropdown">
    <span class="select-text text-muted">{$options[$this->value]}</span>
    <span class="caret"></span>
  </a>
  <ul class="dropdown-menu">
    {$optionsHtml}
  </ul>
</div>
HTML;
EOT;
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
    }
}


1			<?php
2
3			namespace Encore\Admin\Grid\Displayers;
4
5			use Encore\Admin\Admin;
6
7			class Select extends AbstractDisplayer
8			{
9			protected function addScript()
10			{
11			$name = $this->column->getName();
12
13			$class = "grid-select-{$name}";
14
15			$script = <<<EOT
16
17			$('.$class .dropdown-menu li a').click(function () {
18			var target = $(this);
19
20			var text = target.text();
21			var value = target.data('value');
22			var key = target.parents('.$class').attr('key');
23
24			$.ajax({
25			url: "{$this->grid->resource()}/" + key,
26			type: "POST",
27			data: {
28			$name: value,
29			_token: LA.token,
30			_method: 'PUT'
31			},
32			success: function (data) {
33			target.parents('.$class').find('.select-text').text(text);
34
35			target.parents('.dropdown-menu').find('li a').each(function () {
36			if (value == $(this).data('value')) {
37			$(this).find('i').removeClass('invisible')
38			} else {
39			$(this).find('i').addClass('invisible')
40			}
41			});
42
43			toastr.success(data.message);
44			}
45			});
46			});
47
48			EOT;
49
50			Admin::script($script);
51			}
52
53			protected function addStyle()
54			{
55			$style = <<<STYLE
56			.grid-select-{$this->column->getName()} .dropdown-menu {
57			min-width: 0px;
58			}
59			STYLE;
60
61			Admin::style($style);
62			}
63
64			public function display($options = [])
65			{
66			$this->addScript();
67			$this->addStyle();
68
69			$name = $this->column->getName();
			0 ignored issues – show Unused Code introduced 2020-05-14 04:57 UTC by Report Bug Copy Issue Report `$name` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
70
71			if ($options instanceof \Closure) {
72			$options = $options->call($this, $this->row);
73			}
74
75			$optionsHtml = '';
76
77			foreach ($options as $option => $text) {
78			$invisible = $option == $this->value ? '' : 'invisible';
79			$optionsHtml .= "<li><a href='javascript:void(0);' data-value='{$option}'><i class=\"fa fa-check $invisible\"></i>{$text}</a></li>";
80			}
81
82			return <<<HTML
83			<div class="dropdown grid-select-{$this->column->getName()}" key="{$this->getKey()}">
84			<a href="javascript:void(0);" class="dropdown-toggle" data-toggle="dropdown">
85			<span class="select-text text-muted">{$options[$this->value]}</span>
86			<span class="caret"></span>
87			</a>
88			<ul class="dropdown-menu">
89			{$optionsHtml}
90			</ul>
91			</div>
92			HTML;
93			EOT;
			0 ignored issues – show Unused Code introduced 2020-05-14 04:57 UTC by Report Bug Copy Issue Report `EOT;` does not seem to be reachable. This check looks for unreachable code. It uses sophisticated control flow analysis techniques to find statements which will never be executed. Unreachable code is most often the result of `return`, `die` or `exit` statements that have been added for debug purposes. function fx() { try { doSomething(); return true; } catch (\Exception $e) { return false; } return false; } In the above example, the last `return false` will never be executed, because a return statement has already been met in every possible execution path. Loading history...
94			}
95			}
96

z-song / laravel-admin

Push — master ( fe01b0...4ca583 )

Select::addStyle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like