Actions::deleteAction() - Code Metrics - Inspection of "使用admin_url替换部分admin_base_path" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2254)

unknown

created 2018-09-07 16:09 UTC

Actions::deleteAction() B

↳ Parent: Actions

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	0
dl	0
loc	55
rs	8.9818
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Encore\Admin\Grid\Displayers;

use Encore\Admin\Admin;

class Actions extends AbstractDisplayer
{
    /**
     * @var array
     */
    protected $appends = [];

    /**
     * @var array
     */
    protected $prepends = [];

    /**
     * @var bool
     */
    protected $allowEdit = true;

    /**
     * @var bool
     */
    protected $allowDelete = true;

    /**
     * @var string
     */
    protected $resource;

    /**
     * @var
     */
    protected $key;

    /**
     * Append a action.
     *
     * @param $action
     *
     * @return $this
     */
    public function append($action)
    {
        array_push($this->appends, $action);

        return $this;
    }

    /**
     * Prepend a action.
     *
     * @param $action
     *
     * @return $this
     */
    public function prepend($action)
    {
        array_unshift($this->prepends, $action);

        return $this;
    }

    /**
     * Disable delete.
     *
     * @return void.

     */
    public function disableDelete()
    {
        $this->allowDelete = false;
    }

    /**
     * Disable edit.
     *
     * @return void.

     */
    public function disableEdit()
    {
        $this->allowEdit = false;
    }

    /**
     * Set resource of current resource.
     *
     * @param $resource
     *
     * @return void
     */
    public function setResource($resource)
    {
        $this->resource = $resource;
    }

    /**
     * Get resource of current resource.
     *
     * @return string
     */
    public function getResource()
    {
        return $this->resource ?: parent::getResource();
    }

    /**
     * Get url of current resource.
     * @return string
     */
    public function getResourceURL(){
        return url($this->getResource());
    }

    /**
     * {@inheritdoc}
     */
    public function display($callback = null)
    {
        if ($callback instanceof \Closure) {
            $callback->call($this, $this);
        }

        $actions = $this->prepends;
        if ($this->allowEdit) {
            array_push($actions, $this->editAction());
        }

        if ($this->allowDelete) {
            array_push($actions, $this->deleteAction());
        }

        $actions = array_merge($actions, $this->appends);

        return implode('', $actions);
    }

    public function setKey($key)
    {
        $this->key = $key;

        return $this;
    }

    public function getKey()
    {
        if ($this->key) {
            return $this->key;
        }

        return parent::getKey();
    }

    /**
     * Built edit action.
     *
     * @return string
     */
    protected function editAction()
    {
        $editText = trans("admin.edit");

        return <<<EOT
<a href="{$this->getResourceURL()}/{$this->getKey()}/edit">
    <i class="fa fa-edit btn btn-primary" title="{$editText}"></i>
</a>
EOT;
    }

    /**
     * Built delete action.
     *
     * @return string
     */
    protected function deleteAction()
    {
        $deleteConfirm = trans('admin.delete_confirm');
        $confirm = trans('admin.confirm');
        $cancel = trans('admin.cancel');

        $script = <<<SCRIPT

$('.grid-row-delete').unbind('click').click(function() {

    var id = $(this).data('id');

    swal({
      title: "$deleteConfirm",
      type: "warning",
      showCancelButton: true,
      confirmButtonColor: "#DD6B55",
      confirmButtonText: "$confirm",
      closeOnConfirm: false,
      cancelButtonText: "$cancel"
    },
    function(){
        $.ajax({
            method: 'post',
            url: '{$this->getResourceURL()}/' + id,
            data: {
                _method:'delete',
                _token:LA.token,
            },
            success: function (data) {
                $.pjax.reload('#pjax-container');

                if (typeof data === 'object') {
                    if (data.status) {
                        swal(data.message, '', 'success');
                    } else {
                        swal(data.message, '', 'error');
                    }
                }
            }
        });
    });
});

SCRIPT;

        Admin::script($script);

        $deleteText = trans("admin.delete");
        return <<<EOT
<a href="javascript:void(0);" data-id="{$this->getKey()}" class="grid-row-delete">
    <i class="fa fa-trash btn btn-danger" title="{$deleteText}"></i>
</a>
EOT;
    }
}


1			<?php
2
3			namespace Encore\Admin\Grid\Displayers;
4
5			use Encore\Admin\Admin;
6
7			class Actions extends AbstractDisplayer
8			{
9			/**
10			* @var array
11			*/
12			protected $appends = [];
13
14			/**
15			* @var array
16			*/
17			protected $prepends = [];
18
19			/**
20			* @var bool
21			*/
22			protected $allowEdit = true;
23
24			/**
25			* @var bool
26			*/
27			protected $allowDelete = true;
28
29			/**
30			* @var string
31			*/
32			protected $resource;
33
34			/**
35			* @var
36			*/
37			protected $key;
38
39			/**
40			* Append a action.
41			*
42			* @param $action
43			*
44			* @return $this
45			*/
46			public function append($action)
47			{
48			array_push($this->appends, $action);
49
50			return $this;
51			}
52
53			/**
54			* Prepend a action.
55			*
56			* @param $action
57			*
58			* @return $this
59			*/
60			public function prepend($action)
61			{
62			array_unshift($this->prepends, $action);
63
64			return $this;
65			}
66
67			/**
68			* Disable delete.
69			*
70			* @return void.
			0 ignored issues – show Documentation introduced 2017-09-01 02:27 UTC by Report Bug Copy Issue Report The doc-type `void.` could not be parsed: Unknown type name "void." at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
71			*/
72			public function disableDelete()
73			{
74			$this->allowDelete = false;
75			}
76
77			/**
78			* Disable edit.
79			*
80			* @return void.
			0 ignored issues – show Documentation introduced 2017-09-01 02:27 UTC by Report Bug Copy Issue Report The doc-type `void.` could not be parsed: Unknown type name "void." at position 0. (view supported doc-types) This check marks PHPDoc comments that could not be parsed by our parser. To see which comment annotations we can parse, please refer to our documentation on supported doc-types. Loading history...
81			*/
82			public function disableEdit()
83			{
84			$this->allowEdit = false;
85			}
86
87			/**
88			* Set resource of current resource.
89			*
90			* @param $resource
91			*
92			* @return void
93			*/
94			public function setResource($resource)
95			{
96			$this->resource = $resource;
97			}
98
99			/**
100			* Get resource of current resource.
101			*
102			* @return string
103			*/
104			public function getResource()
105			{
106			return $this->resource ?: parent::getResource();
107			}
108
109			/**
110			* Get url of current resource.
111			* @return string
112			*/
113			public function getResourceURL(){
114			return url($this->getResource());
115			}
116
117			/**
118			* {@inheritdoc}
119			*/
120			public function display($callback = null)
121			{
122			if ($callback instanceof \Closure) {
123			$callback->call($this, $this);
124			}
125
126			$actions = $this->prepends;
127			if ($this->allowEdit) {
128			array_push($actions, $this->editAction());
129			}
130
131			if ($this->allowDelete) {
132			array_push($actions, $this->deleteAction());
133			}
134
135			$actions = array_merge($actions, $this->appends);
136
137			return implode('', $actions);
138			}
139
140			public function setKey($key)
141			{
142			$this->key = $key;
143
144			return $this;
145			}
146
147			public function getKey()
148			{
149			if ($this->key) {
150			return $this->key;
151			}
152
153			return parent::getKey();
154			}
155
156			/**
157			* Built edit action.
158			*
159			* @return string
160			*/
161			protected function editAction()
162			{
163			$editText = trans("admin.edit");
164
165			return <<<EOT
166			<a href="{$this->getResourceURL()}/{$this->getKey()}/edit">
167			<i class="fa fa-edit btn btn-primary" title="{$editText}"></i>
168			</a>
169			EOT;
170			}
171
172			/**
173			* Built delete action.
174			*
175			* @return string
176			*/
177			protected function deleteAction()
178			{
179			$deleteConfirm = trans('admin.delete_confirm');
180			$confirm = trans('admin.confirm');
181			$cancel = trans('admin.cancel');
182
183			$script = <<<SCRIPT
184
185			$('.grid-row-delete').unbind('click').click(function() {
186
187			var id = $(this).data('id');
188
189			swal({
190			title: "$deleteConfirm",
191			type: "warning",
192			showCancelButton: true,
193			confirmButtonColor: "#DD6B55",
194			confirmButtonText: "$confirm",
195			closeOnConfirm: false,
196			cancelButtonText: "$cancel"
197			},
198			function(){
199			$.ajax({
200			method: 'post',
201			url: '{$this->getResourceURL()}/' + id,
202			data: {
203			_method:'delete',
204			_token:LA.token,
205			},
206			success: function (data) {
207			$.pjax.reload('#pjax-container');
208
209			if (typeof data === 'object') {
210			if (data.status) {
211			swal(data.message, '', 'success');
212			} else {
213			swal(data.message, '', 'error');
214			}
215			}
216			}
217			});
218			});
219			});
220
221			SCRIPT;
222
223			Admin::script($script);
224
225			$deleteText = trans("admin.delete");
226			return <<<EOT
227			<a href="javascript:void(0);" data-id="{$this->getKey()}" class="grid-row-delete">
228			<i class="fa fa-trash btn btn-danger" title="{$deleteText}"></i>
229			</a>
230			EOT;
231			}
232			}
233

z-song / laravel-admin

Pull Request — master (#2254)

Actions::deleteAction() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like