MultipleSelect::fill() - Code Metrics - Inspection of "使用admin_url替换部分admin_base_path" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2254)

unknown

created 2018-09-07 16:09 UTC

MultipleSelect::fill() A

↳ Parent: MultipleSelect

Complexity

Conditions	5
Paths	8

Size

Total Lines

Duplication

Lines	18
Ratio	100 %

Importance

Changes

Metric	Value
cc	5
nc	8
nop	1
dl	18
loc	18
rs	9.3554
c	0
b	0
f	0

<?php

namespace Encore\Admin\Form\Field;

use Illuminate\Database\Eloquent\Relations\BelongsToMany;

class MultipleSelect extends Select
{
    /**
     * Other key for many-to-many relation.
     *
     * @var string
     */
    protected $otherKey;

    /**
     * Get other key for this many-to-many relation.
     *
     * @throws \Exception
     *
     * @return string
     */
    protected function getOtherKey()
    {
        if ($this->otherKey) {
            return $this->otherKey;
        }

        if (is_callable([$this->form->model(), $this->column]) &&
            ($relation = $this->form->model()->{$this->column}()) instanceof BelongsToMany
        ) {
            /* @var BelongsToMany $relation */
            $fullKey = $relation->getQualifiedRelatedPivotKeyName();
            $fullKeyArray = explode('.', $fullKey);

            return $this->otherKey = end($fullKeyArray);
        }

        throw new \Exception('Column of this field must be a `BelongsToMany` relation.');
    }

    public function fill($data)

    {
        $relations = array_get($data, $this->column);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        if (is_string($relations)) {
            $this->value = explode(',', $relations);
        }

        if (is_array($relations)) {
            if (is_string(current($relations))) {
                $this->value = $relations;
            } else {
                foreach ($relations as $relation) {
                    $this->value[] = array_get($relation, "pivot.{$this->getOtherKey()}");
                }
            }
        }
    }

    public function setOriginal($data)

    {
        $relations = array_get($data, $this->column);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        if (is_string($relations)) {
            $this->original = explode(',', $relations);
        }

        if (is_array($relations)) {
            if (is_string(current($relations))) {
                $this->original = $relations;
            } else {
                foreach ($relations as $relation) {
                    $this->original[] = array_get($relation, "pivot.{$this->getOtherKey()}");
                }
            }
        }
    }

    public function prepare($value)
    {
        $value = (array) $value;

        return array_filter($value);
    }
}


1		<?php
2
3		namespace Encore\Admin\Form\Field;
4
5		use Illuminate\Database\Eloquent\Relations\BelongsToMany;
6
7		class MultipleSelect extends Select
8		{
9		/**
10		* Other key for many-to-many relation.
11		*
12		* @var string
13		*/
14		protected $otherKey;
15
16		/**
17		* Get other key for this many-to-many relation.
18		*
19		* @throws \Exception
20		*
21		* @return string
22		*/
23		protected function getOtherKey()
24		{
25		if ($this->otherKey) {
26		return $this->otherKey;
27		}
28
29		if (is_callable([$this->form->model(), $this->column]) &&
30		($relation = $this->form->model()->{$this->column}()) instanceof BelongsToMany
31		) {
32		/* @var BelongsToMany $relation */
33		$fullKey = $relation->getQualifiedRelatedPivotKeyName();
34		$fullKeyArray = explode('.', $fullKey);
35
36		return $this->otherKey = end($fullKeyArray);
37		}
38
39		throw new \Exception('Column of this field must be a `BelongsToMany` relation.');
40		}
41
42	View Code Duplication	public function fill($data)
		0 ignored issues – show Duplication introduced 2017-09-01 02:27 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		$relations = array_get($data, $this->column);
		0 ignored issues – show Bug introduced 2017-09-19 15:53 UTC by Report Bug Copy Issue Report It seems like `$this->column` can also be of type `array`; however, `array_get()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
45
46		if (is_string($relations)) {
47		$this->value = explode(',', $relations);
48		}
49
50		if (is_array($relations)) {
51		if (is_string(current($relations))) {
52		$this->value = $relations;
53		} else {
54		foreach ($relations as $relation) {
55		$this->value[] = array_get($relation, "pivot.{$this->getOtherKey()}");
56		}
57		}
58		}
59		}
60
61	View Code Duplication	public function setOriginal($data)
		0 ignored issues – show Duplication introduced 2016-08-05 10:29 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62		{
63		$relations = array_get($data, $this->column);
		0 ignored issues – show Bug introduced 2017-09-19 15:53 UTC by Report Bug Copy Issue Report It seems like `$this->column` can also be of type `array`; however, `array_get()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
64
65		if (is_string($relations)) {
66		$this->original = explode(',', $relations);
67		}
68
69		if (is_array($relations)) {
70		if (is_string(current($relations))) {
71		$this->original = $relations;
72		} else {
73		foreach ($relations as $relation) {
74		$this->original[] = array_get($relation, "pivot.{$this->getOtherKey()}");
75		}
76		}
77		}
78		}
79
80		public function prepare($value)
81		{
82		$value = (array) $value;
83
84		return array_filter($value);
85		}
86		}
87

z-song / laravel-admin

Pull Request — master (#2254)

MultipleSelect::fill() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like