Complex classes like Column often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Column, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
13 | class Column |
||
14 | { |
||
15 | /** |
||
16 | * @var Grid |
||
17 | */ |
||
18 | protected $grid; |
||
19 | |||
20 | /** |
||
21 | * Name of column. |
||
22 | * |
||
23 | * @var string |
||
24 | */ |
||
25 | protected $name; |
||
26 | |||
27 | /** |
||
28 | * Label of column. |
||
29 | * |
||
30 | * @var string |
||
31 | */ |
||
32 | protected $label; |
||
33 | |||
34 | /** |
||
35 | * Original value of column. |
||
36 | * |
||
37 | * @var mixed |
||
38 | */ |
||
39 | protected $original; |
||
40 | |||
41 | /** |
||
42 | * Is column sortable. |
||
43 | * |
||
44 | * @var bool |
||
45 | */ |
||
46 | protected $sortable = false; |
||
47 | |||
48 | /** |
||
49 | * Sort arguments. |
||
50 | * |
||
51 | * @var array |
||
52 | */ |
||
53 | protected $sort; |
||
54 | |||
55 | /** |
||
56 | * Attributes of column. |
||
57 | * |
||
58 | * @var array |
||
59 | */ |
||
60 | protected $attributes = []; |
||
61 | |||
62 | /** |
||
63 | * Relation name. |
||
64 | * |
||
65 | * @var bool |
||
66 | */ |
||
67 | protected $relation = false; |
||
68 | |||
69 | /** |
||
70 | * Relation column. |
||
71 | * |
||
72 | * @var string |
||
73 | */ |
||
74 | protected $relationColumn; |
||
75 | |||
76 | /** |
||
77 | * Original grid data. |
||
78 | * |
||
79 | * @var array |
||
80 | */ |
||
81 | protected static $originalGridData = []; |
||
82 | |||
83 | /** |
||
84 | * @var []Closure |
||
85 | */ |
||
86 | protected $displayCallbacks = []; |
||
87 | |||
88 | /** |
||
89 | * Displayers for grid column. |
||
90 | * |
||
91 | * @var array |
||
92 | */ |
||
93 | public static $displayers = []; |
||
94 | |||
95 | /** |
||
96 | * Defined columns. |
||
97 | * |
||
98 | * @var array |
||
99 | */ |
||
100 | public static $defined = []; |
||
101 | |||
102 | /** |
||
103 | * @var array |
||
104 | */ |
||
105 | protected static $htmlAttributes = []; |
||
106 | |||
107 | /** |
||
108 | * @var |
||
109 | */ |
||
110 | protected static $model; |
||
111 | |||
112 | const SELECT_COLUMN_NAME = '__row_selector__'; |
||
113 | |||
114 | /** |
||
115 | * @param string $name |
||
116 | * @param string $label |
||
117 | */ |
||
118 | public function __construct($name, $label) |
||
124 | |||
125 | /** |
||
126 | * Extend column displayer. |
||
127 | * |
||
128 | * @param $name |
||
129 | * @param $displayer |
||
130 | */ |
||
131 | public static function extend($name, $displayer) |
||
135 | |||
136 | /** |
||
137 | * Define a column globally. |
||
138 | * |
||
139 | * @param string $name |
||
140 | * @param mixed $definition |
||
141 | */ |
||
142 | public static function define($name, $definition) |
||
146 | |||
147 | /** |
||
148 | * Set grid instance for column. |
||
149 | * |
||
150 | * @param Grid $grid |
||
151 | */ |
||
152 | public function setGrid(Grid $grid) |
||
158 | |||
159 | /** |
||
160 | * Set model for column. |
||
161 | * |
||
162 | * @param $model |
||
163 | */ |
||
164 | public function setModel($model) |
||
170 | |||
171 | /** |
||
172 | * Set original data for column. |
||
173 | * |
||
174 | * @param array $input |
||
175 | */ |
||
176 | public static function setOriginalGridData(array $input) |
||
180 | |||
181 | /** |
||
182 | * Set column attributes. |
||
183 | * |
||
184 | * @param array $attributes |
||
185 | * |
||
186 | * @return $this |
||
187 | */ |
||
188 | public function setAttributes($attributes = []) |
||
194 | |||
195 | /** |
||
196 | * Get column attributes. |
||
197 | * |
||
198 | * @param string $name |
||
199 | * |
||
200 | * @return mixed |
||
201 | */ |
||
202 | public static function getAttributes($name) |
||
206 | |||
207 | /** |
||
208 | * Set style of this column. |
||
209 | * |
||
210 | * @param string $style |
||
211 | * |
||
212 | * @return Column |
||
213 | */ |
||
214 | public function style($style) |
||
218 | |||
219 | /** |
||
220 | * Get name of this column. |
||
221 | * |
||
222 | * @return mixed |
||
223 | */ |
||
224 | public function getName() |
||
228 | |||
229 | /** |
||
230 | * Format label. |
||
231 | * |
||
232 | * @param $label |
||
233 | * |
||
234 | * @return mixed |
||
235 | */ |
||
236 | protected function formatLabel($label) |
||
242 | |||
243 | /** |
||
244 | * Get label of the column. |
||
245 | * |
||
246 | * @return mixed |
||
247 | */ |
||
248 | public function getLabel() |
||
252 | |||
253 | /** |
||
254 | * Set relation. |
||
255 | * |
||
256 | * @param string $relation |
||
257 | * @param string $relationColumn |
||
258 | * |
||
259 | * @return $this |
||
260 | */ |
||
261 | public function setRelation($relation, $relationColumn = null) |
||
268 | |||
269 | /** |
||
270 | * If this column is relation column. |
||
271 | * |
||
272 | * @return bool |
||
273 | */ |
||
274 | protected function isRelation() |
||
278 | |||
279 | /** |
||
280 | * Mark this column as sortable. |
||
281 | * |
||
282 | * @return Column |
||
283 | */ |
||
284 | public function sortable() |
||
290 | |||
291 | /** |
||
292 | * Add a display callback. |
||
293 | * |
||
294 | * @param Closure $callback |
||
295 | * |
||
296 | * @return $this |
||
297 | */ |
||
298 | public function display(Closure $callback) |
||
304 | |||
305 | /** |
||
306 | * If has display callbacks. |
||
307 | * |
||
308 | * @return bool |
||
309 | */ |
||
310 | protected function hasDisplayCallbacks() |
||
314 | |||
315 | /** |
||
316 | * Call all of the "display" callbacks column. |
||
317 | * |
||
318 | * @param mixed $value |
||
319 | * @param int $key |
||
320 | * |
||
321 | * @return mixed |
||
322 | */ |
||
323 | protected function callDisplayCallbacks($value, $key) |
||
332 | |||
333 | /** |
||
334 | * Set original grid data to column. |
||
335 | * |
||
336 | * @param Closure $callback |
||
337 | * @param int $key |
||
338 | * |
||
339 | * @return Closure |
||
340 | */ |
||
341 | protected function bindOriginalRow(Closure $callback, $key) |
||
347 | |||
348 | /** |
||
349 | * Fill all data to every column. |
||
350 | * |
||
351 | * @param array $data |
||
352 | * |
||
353 | * @return mixed |
||
354 | */ |
||
355 | public function fill(array $data) |
||
376 | |||
377 | /** |
||
378 | * If current column is a defined column. |
||
379 | * |
||
380 | * @return bool |
||
381 | */ |
||
382 | protected function isDefinedColumn() |
||
386 | |||
387 | /** |
||
388 | * Use a defined column. |
||
389 | * |
||
390 | * @throws \Exception |
||
391 | */ |
||
392 | protected function useDefinedColumn() |
||
418 | |||
419 | /** |
||
420 | * Convert characters to HTML entities recursively. |
||
421 | * |
||
422 | * @param array|string $item |
||
423 | * |
||
424 | * @return mixed |
||
425 | */ |
||
426 | protected function htmlEntityEncode($item) |
||
438 | |||
439 | /** |
||
440 | * Create the column sorter. |
||
441 | * |
||
442 | * @return string|void |
||
443 | */ |
||
444 | public function sorter() |
||
465 | |||
466 | /** |
||
467 | * Determine if this column is currently sorted. |
||
468 | * |
||
469 | * @return bool |
||
470 | */ |
||
471 | protected function isSorted() |
||
481 | |||
482 | /** |
||
483 | * Find a displayer to display column. |
||
484 | * |
||
485 | * @param string $abstract |
||
486 | * @param array $arguments |
||
487 | * |
||
488 | * @return Column |
||
489 | */ |
||
490 | protected function resolveDisplayer($abstract, $arguments) |
||
498 | |||
499 | /** |
||
500 | * Call Illuminate/Support displayer. |
||
501 | * |
||
502 | * @param string $abstract |
||
503 | * @param array $arguments |
||
504 | * |
||
505 | * @return Column |
||
506 | */ |
||
507 | protected function callSupportDisplayer($abstract, $arguments) |
||
521 | |||
522 | /** |
||
523 | * Call Builtin displayer. |
||
524 | * |
||
525 | * @param string $abstract |
||
526 | * @param array $arguments |
||
527 | * |
||
528 | * @return Column |
||
529 | */ |
||
530 | protected function callBuiltinDisplayer($abstract, $arguments) |
||
551 | |||
552 | /** |
||
553 | * Passes through all unknown calls to builtin displayer or supported displayer. |
||
554 | * |
||
555 | * Allow fluent calls on the Column object. |
||
556 | * |
||
557 | * @param string $method |
||
558 | * @param array $arguments |
||
559 | * |
||
560 | * @return $this |
||
561 | */ |
||
562 | public function __call($method, $arguments) |
||
575 | } |
||
576 |
Let’s assume that you have a directory layout like this:
and let’s assume the following content of
Bar.php
:If both files
OtherDir/Foo.php
andSomeDir/Foo.php
are loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php
However, as
OtherDir/Foo.php
does not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php
, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: