Resizable::getThumbnail() - Code Metrics - Inspection of "refactoring" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8c64c3...017009 )

by Song

created 2019-06-13 14:32 UTC

Resizable::getThumbnail() A

↳ Parent: Resizable

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
nc	1
nop	2
dl	0
loc	11
rs	9.9
c	0
b	0
f	0

<?php

namespace Encore\Admin\Traits;

trait Resizable
{
    /**
     * Method for returning specific thumbnail for model.
     *
     * @param string $type
     * @param string $attribute
     *
     * @return string
     */
    public function thumbnail($type, $attribute = 'image')
    {
        // Return empty string if the field not found
        if (!isset($this->attributes[$attribute])) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            return '';
        }

        // We take image from posts field
        $image = $this->attributes[$attribute];

        $thumbnail = $this->getThumbnail($image, $type);

        return \Illuminate\Support\Facades\Storage::disk(config('admin.upload.disk'))->exists($thumbnail) ? $thumbnail : $image;
    }

    /**
     * Generate thumbnail URL.
     *
     * @param $image
     * @param $type
     *
     * @return string
     */
    public function getThumbnail($image, $type)
    {
        // We need to get extension type ( .jpeg , .png ...)
        $ext = pathinfo($image, PATHINFO_EXTENSION);

        // We remove extension from file name so we can append thumbnail type
        $name = str_replace_last('.'.$ext, '', $image);


        // We merge original name + type + extension
        return $name.'-'.$type.'.'.$ext;
    }
}


1			<?php
2
3			namespace Encore\Admin\Traits;
4
5			trait Resizable
6			{
7			/**
8			* Method for returning specific thumbnail for model.
9			*
10			* @param string $type
11			* @param string $attribute
12			*
13			* @return string
14			*/
15			public function thumbnail($type, $attribute = 'image')
16			{
17			// Return empty string if the field not found
18			if (!isset($this->attributes[$attribute])) {
			0 ignored issues – show Bug introduced 2019-06-03 04:48 UTC by Report Bug Copy Issue Report The property `attributes` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
19			return '';
20			}
21
22			// We take image from posts field
23			$image = $this->attributes[$attribute];
24
25			$thumbnail = $this->getThumbnail($image, $type);
26
27			return \Illuminate\Support\Facades\Storage::disk(config('admin.upload.disk'))->exists($thumbnail) ? $thumbnail : $image;
28			}
29
30			/**
31			* Generate thumbnail URL.
32			*
33			* @param $image
34			* @param $type
35			*
36			* @return string
37			*/
38			public function getThumbnail($image, $type)
39			{
40			// We need to get extension type ( .jpeg , .png ...)
41			$ext = pathinfo($image, PATHINFO_EXTENSION);
42
43			// We remove extension from file name so we can append thumbnail type
44			$name = str_replace_last('.'.$ext, '', $image);
			0 ignored issues – show Deprecated Code introduced 2019-06-03 04:48 UTC by Report Bug Copy Issue Report The function `str_replace_last()` has been deprecated with message: Str::replaceLast() should be used directly instead. Will be removed in Laravel 5.9. This function has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the function will be removed from the class and what other function to use instead. Loading history...
45
46			// We merge original name + type + extension
47			return $name.'-'.$type.'.'.$ext;
48			}
49			}
50

z-song / laravel-admin

Push — master ( 8c64c3...017009 )

Resizable::getThumbnail() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like