Embeds::formatValidationAttribute() - Code Metrics - Inspection of "Bug Fix for HasMany & Embed Field Customized Valid..." - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#3035)

unknown

created 2019-03-12 07:05 UTC

Embeds::formatValidationAttribute() B

↳ Parent: Embeds::getValidationRules()

Complexity

Conditions	8
Paths	9

Size

Total Lines

Duplication

Lines	26
Ratio	100 %

Importance

Changes

Metric	Value
cc	8
nc	9
nop	3
dl	26
loc	26
rs	8.4444
c	0
b	0
f	0

<?php

namespace Encore\Admin\Form\Field;

use Encore\Admin\Form\EmbeddedForm;
use Encore\Admin\Form\Field;
use Illuminate\Support\Facades\Validator;

if (!function_exists('array_key_attach_str')) {

    function array_key_attach_str(array $a, string $b, string $c = '.')
    {
        return call_user_func_array(
            'array_merge',
            array_map(function ($u, $v) use ($b, $c) {
                return ["{$b}{$c}{$u}" => $v];
            }, array_keys($a), array_values($a))
        );
    }
}

if (!function_exists('array_clean_merge')) {
    function array_clean_merge(array $a, $b)
    {
        return $b ? array_merge($a, call_user_func_array('array_merge', $b)) : $a;
    }
}

if (!function_exists('array_key_clean_undot')) {

    function array_key_clean_undot(array $a)
    {
        $keys = preg_grep('/[\.\:]/', array_keys($a));
        if ($keys) {

            foreach ($keys as $key) {
                array_set($a, str_replace(':', '', $key), $a[$key]);
                unset($a[$key]);
            }
        }

        return $a;
    }
}

if (!function_exists('array_key_clean')) {

    function array_key_clean(array $a)
    {
        $a = count($a) ? call_user_func_array('array_merge', array_map(function ($k, $v) {
            return [str_replace(':', '', $k) => $v];
        }, array_keys($a), array_values($a))) : $a;

        return $a;
    }
}

class Embeds extends Field
{
    /**
     * @var \Closure
     */
    protected $builder = null;

    /**
     * Create a new HasMany field instance.
     *
     * @param string $column
     * @param array  $arguments
     */
    public function __construct($column, $arguments = [])

    {
        $this->column = $column;

        if (count($arguments) == 1) {
            $this->label = $this->formatLabel();
            $this->builder = $arguments[0];
        }

        if (count($arguments) == 2) {
            list($this->label, $this->builder) = $arguments;
        }
    }

    /**
     * Prepare input data for insert or update.
     *
     * @param array $input
     *
     * @return array
     */
    public function prepare($input)
    {
        $form = $this->buildEmbeddedForm();

        return $form->setOriginal($this->original)->prepare($input);
    }

    /**
     * Prepare validation rules based on input data.
     *
     * @param array $input
     *
     * @return array
     */
    public function getValidationRules(array $input)
    {
        if (!array_key_exists($this->column, $input)) {
            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $input = array_only($input, $this->column);
        $rules = [];
        $rel = $this->column;
        $availInput = $input;

        /** @var Field $field */
        foreach ($this->buildEmbeddedForm()->fields() as $field) {
            if (!$fieldRules = $field->getRules()) {
                continue;
            }

            $column = $field->column();
            $columns = is_array($column) ? $column : [$column];
            if (

                $field instanceof Field\MultipleSelect
                || $field instanceof Field\Listbox
                || $field instanceof Field\Checkbox
                || $field instanceof Field\Tags
                || $field instanceof Field\MultipleImage
                || $field instanceof Field\MultipleFile
            ) {
                $availInput[$column] = array_filter($availInput[$column], 'strlen');
                $availInput[$column] = $availInput[$column] ?: null;
            }
            /*
             *
             * For single column field format rules to:
             * [
             *     'extra.name' => 'required'
             *     'extra.email' => 'required'
             * ]
             *
             * For multiple column field with rules like 'required':
             * 'extra' => [
             *     'start' => 'start_at'
             *     'end'   => 'end_at',
             * ]
             *
             * format rules to:
             * [
             *     'extra.start_atstart' => 'required'
             *     'extra.end_atend' => 'required'
             * ]
             *
             *
             * format attributes to:
             * [
             *      'extra.start_atstart' => "$label[start_at]"
             *      'extra.end_atend'     => "$label[end_at]"
             * ]
             */
            $newColumn = array_map(function ($k, $v) use ($rel) {
                //Fix ResetInput Function! A Headache Implementation!
                return !$k ? "{$rel}.{$v}" : "{$rel}.{$v}:{$k}";
            }, array_keys($columns), array_values($columns));

            $fieldRules = is_array($fieldRules) ? implode('|', $fieldRules) : $fieldRules;
            $newRules = array_map(function ($v) use ($fieldRules, $availInput) {

                list($k, $c) = explode('.', $v);
                //Fix ResetInput Function! A Headache Implementation!
                $col = explode(':', $c)[0];

                if (array_key_exists($col, $availInput[$k]) && is_array($availInput[$k][$col])) {
                    return array_key_attach_str(preg_replace('/./', $fieldRules, $availInput[$k][$col]), $v, ':');
                }

                //May Have Problem in Dealing with File Upload in Edit Mode
                return [$v => $fieldRules];
            }, $newColumn);
            $rules = array_clean_merge($rules, $newRules);
        }

        return $rules;
    }

    /**
     * Prepare validation attributes based on input data.
     *
     * @param array $input
     *
     * @return array
     */
    public function getValidationAttributes(array $input)
    {
        if (!array_key_exists($this->column, $input)) {
            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $input = array_only($input, $this->column);
        $attributes = [];
        $rel = $this->column;
        $availInput = $input;
        /** @var Field $field */
        foreach ($this->buildEmbeddedForm()->fields() as $field) {
            if (!$field->getRules()) {
                continue;
            }

            $column = $field->column();
            $columns = is_array($column) ? $column : [$column];
            if (

                $field instanceof Field\MultipleSelect
                || $field instanceof Field\Listbox
                || $field instanceof Field\Checkbox
                || $field instanceof Field\Tags
                || $field instanceof Field\MultipleImage
                || $field instanceof Field\MultipleFile
            ) {
                $availInput[$column] = array_filter($availInput[$column], 'strlen');
                $availInput[$column] = $availInput[$column] ?: null;
            }
            /*
             *
             * For single column field format rules to:
             * [
             *     'extra.name' => 'required'
             *     'extra.email' => 'required'
             * ]
             *
             * For multiple column field with rules like 'required':
             * 'extra' => [
             *     'start' => 'start_at'
             *     'end'   => 'end_at',
             * ]
             *
             * format rules to:
             * [
             *     'extra.start_atstart' => 'required'
             *     'extra.end_atend' => 'required'
             * ]
             *
             *
             * format attributes to:
             * [
             *      'extra.start_atstart' => "$label[start_at]"
             *      'extra.end_atend'     => "$label[end_at]"
             * ]
             */
            $newColumn = array_map(function ($k, $v) use ($rel) {
                //Fix ResetInput Function! A Headache Implementation!
                return !$k ? "{$rel}.{$v}" : "{$rel}.{$v}:{$k}";
            }, array_keys($columns), array_values($columns));

            $newAttributes = array_map(function ($v) use ($field, $availInput) {

                list($k, $c) = explode('.', $v);
                //Fix ResetInput Function! A Headache Implementation!
                $col = explode(':', $c)[0];
                if (array_key_exists($col, $availInput[$k]) && is_array($availInput[$k][$col])) {
                    return call_user_func_array('array_merge', array_map(function ($u) use ($v, $field) {
                        $w = $field->label();
                        //Fix ResetInput Function! A Headache Implementation!
                        $w .= is_array($field->column()) ? '['.explode(':', explode('.', $v)[2])[0].']' : '';

                        return ["{$v}:{$u}" => $w];
                    }, array_keys($availInput[$k][$col])));
                }

                //May Have Problem in Dealing with File Upload in Edit Mode
                $w = $field->label();
                //Fix ResetInput Function! A Headache Implementation!
                $w .= is_array($field->column()) ? '['.explode(':', explode('.', $v)[2])[0].']' : '';

                return [$v => $w];
            }, $newColumn);
            $attributes = array_clean_merge($attributes, $newAttributes);
        }

        return $attributes;
    }

    /**
     * Prepare input data for insert or update.
     *
     * @param array $input
     *
     * @return array
     */
    public function getValidationInput(array $input)
    {
        if (!array_key_exists($this->column, $input)) {
            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $input = array_only($input, $this->column);
        $newInputs = [];
        $rel = $this->column;
        $availInput = $input;

        /** @var Field $field */
        foreach ($this->buildEmbeddedForm()->fields() as $field) {
            if (!$field->getRules()) {
                continue;
            }

            $column = $field->column();
            $columns = is_array($column) ? $column : [$column];
            if (

                $field instanceof Field\MultipleSelect
                || $field instanceof Field\Listbox
                || $field instanceof Field\Checkbox
                || $field instanceof Field\Tags
                || $field instanceof Field\MultipleImage
                || $field instanceof Field\MultipleFile
            ) {
                $availInput[$column] = array_filter($availInput[$column], 'strlen');
                $availInput[$column] = $availInput[$column] ?: null;
            }
            /*
             *
             * For single column field format rules to:
             * [
             *     'extra.name' => $value
             *     'extra.email' => $value
             * ]
             *
             * For multiple column field with rules like 'required':
             * 'extra' => [
             *     'start' => 'start_at'
             *     'end'   => 'end_at',
             * ]
             *
             * format rules to:
             * [
             *     'extra.start_atstart' => $value
             *     'extra.end_atend' => $value
             * ]
             */
            $newColumn = array_map(function ($k, $v) use ($rel) {
                //Fix ResetInput Function! A Headache Implementation!
                return !$k ? "{$rel}.{$v}" : "{$rel}.{$v}:{$k}";
            }, array_keys($columns), array_values($columns));

            $newInput = array_map(function ($v) use ($availInput) {

                list($k, $c) = explode('.', $v);
                //Fix ResetInput Function! A Headache Implementation!
                $col = explode(':', $c)[0];
                if (!array_key_exists($col, $availInput[$k])) {
                    return [$v => null];
                }

                if (array_key_exists($col, $availInput[$k]) && is_array($availInput[$k][$col])) {
                    return array_key_attach_str($availInput[$k][$col], $v, ':');
                }

                return [$v => $availInput[$k][$col]];
            }, $newColumn);
            $newInputs = array_clean_merge($newInputs, $newInput);
        }

        return $newInputs;
    }

    /**
     * Prepare customer validation messages based on input data.
     *
     * @param array $input
     *
     * @return array
     */
    public function getValidationMessages(array $input)
    {
        if (!array_key_exists($this->column, $input)) {
            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $input = array_only($input, $this->column);
        $messages = [];
        $rel = $this->column;
        $availInput = $input;

        /** @var Field $field */
        foreach ($this->buildEmbeddedForm()->fields() as $field) {
            if (!$field->getRules()) {
                continue;
            }

            $column = $field->column();
            $columns = is_array($column) ? $column : [$column];
            if (

                $field instanceof Field\MultipleSelect
                || $field instanceof Field\Listbox
                || $field instanceof Field\Checkbox
                || $field instanceof Field\Tags
                || $field instanceof Field\MultipleImage
                || $field instanceof Field\MultipleFile
            ) {
                $availInput[$column] = array_filter($availInput[$column], 'strlen');
                $availInput[$column] = $availInput[$column] ?: null;
            }

            $newColumn = array_map(function ($k, $v) use ($rel) {
                //Fix ResetInput Function! A Headache Implementation!
                return !$k ? "{$rel}.{$v}" : "{$rel}.{$v}:{$k}";
            }, array_keys($columns), array_values($columns));

            if ($field->validationMessages) {

                $newMessages = array_map(function ($v) use ($field, $availInput) {
                    list($k, $c) = explode('.', $v);
                    //Fix ResetInput Function! A Headache Implementation!
                    $col = explode(':', $c)[0];
                    if (array_key_exists($col, $availInput[$k]) && is_array($availInput[$k][$col])) {
                        return call_user_func_array(
                            'array_merge',
                            array_map(function ($u) use (
                                $v,
                                $field
                            ) {
                                return array_key_attach_str($field->validationMessages, "{$v}:{$u}");
                            }, array_keys($availInput[$k][$col]))
                        );
                    }

                    //May Have Problem in Dealing with File Upload in Edit Mode
                    return array_key_attach_str($field->validationMessages, $v);
                }, $newColumn);
                $messages = array_clean_merge($messages, $newMessages);
            }
        }

        return $messages;
    }

    /**
     * {@inheritdoc}
     */
    public function getValidator(array $input)
    {
        if (!array_key_exists($this->column, $input)) {
            return false;
        }

        $rules = $this->getValidationRules($input);
        if (empty($rules)) {
            return false;
        }

        $attributes = $this->getValidationAttributes($input);
        $messages = $this->getValidationMessages($input);
        $newInputs = $this->getValidationInput($input);

        $input = array_key_clean_undot(array_filter($newInputs, 'strlen', ARRAY_FILTER_USE_KEY));
        $rules = array_key_clean($rules);
        $attributes = array_key_clean($attributes);
        $messages = array_key_clean($messages);

        return Validator::make($input, $rules, $messages, $attributes);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Get data for Embedded form.
     *
     * Normally, data is obtained from the database.
     *
     * When the data validation errors, data is obtained from session flash.
     *
     * @return array
     */
    protected function getEmbeddedData()
    {
        if ($old = old($this->column)) {
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            return $old;
        }

        if (empty($this->value)) {
            return [];
        }

        if (is_string($this->value)) {
            return json_decode($this->value, true);
        }

        return (array) $this->value;
    }

    /**
     * Build a Embedded Form and fill data.
     *
     * @return EmbeddedForm
     */
    protected function buildEmbeddedForm()
    {
        $form = new EmbeddedForm($this->elementName ?: $this->column);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        $form->setParent($this->form);

        call_user_func($this->builder, $form);

        //Fix the Bug of Embeds Fields Cannot be used within HasMany
        if ($this->elementName) {
            list($rel, $key, $col) = explode('.', $this->errorKey);
            $form->fields()->each(function (Field $field) use ($rel, $key, $col) {
                $column = $field->column();
                $elementName = $elementClass = $errorKey = [];
                if (is_array($column)) {
                    foreach ($column as $k => $name) {
                        $errorKey[$k] = sprintf('%s.%s.%s.%s', $rel, $key, $col, $name);
                        $elementName[$k] = sprintf('%s[%s][%s][%s]', $rel, $key, $col, $name);
                        $elementClass[$k] = [$rel, $col, $name];
                    }
                } else {
                    $errorKey = sprintf('%s.%s.%s.%s', $rel, $key, $col, $column);
                    $elementName = sprintf('%s[%s][%s][%s]', $rel, $key, $col, $column);
                    $elementClass = [$rel, $col, $column];
                }
                $field->setErrorKey($errorKey)
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    ->setElementName($elementName)
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                    ->setElementClass($elementClass);
            });
        }
        $form->fill($this->getEmbeddedData());

        return $form;
    }

    /**
     * Render the form.
     *
     * @return \Illuminate\View\View
     */
    public function render()
    {
        return parent::render()->with(['form' => $this->buildEmbeddedForm()]);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1		<?php
2
3		namespace Encore\Admin\Form\Field;
4
5		use Encore\Admin\Form\EmbeddedForm;
6		use Encore\Admin\Form\Field;
7		use Illuminate\Support\Facades\Validator;
8
9	View Code Duplication	if (!function_exists('array_key_attach_str')) {
		0 ignored issues – show Duplication introduced 2019-02-28 05:12 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10		function array_key_attach_str(array $a, string $b, string $c = '.')
11		{
12		return call_user_func_array(
13		'array_merge',
14		array_map(function ($u, $v) use ($b, $c) {
15		return ["{$b}{$c}{$u}" => $v];
16		}, array_keys($a), array_values($a))
17		);
18		}
19		}
20
21		if (!function_exists('array_clean_merge')) {
22		function array_clean_merge(array $a, $b)
23		{
24		return $b ? array_merge($a, call_user_func_array('array_merge', $b)) : $a;
25		}
26		}
27
28	View Code Duplication	if (!function_exists('array_key_clean_undot')) {
		0 ignored issues – show Duplication introduced 2019-02-28 05:12 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
29		function array_key_clean_undot(array $a)
30		{
31		$keys = preg_grep('/[\.\:]/', array_keys($a));
32		if ($keys) {
		0 ignored issues – show Bug Best Practice introduced 2018-12-29 05:04 UTC by Report Bug Copy Issue Report The expression `$keys` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
33		foreach ($keys as $key) {
34		array_set($a, str_replace(':', '', $key), $a[$key]);
35		unset($a[$key]);
36		}
37		}

z-song / laravel-admin

Pull Request — master (#3035)

Embeds::formatValidationAttribute() B

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like