Tools - Code Metrics - Inspection of "[refactor] Modify the style of filter button of gr..." - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 77fd36...f39186 )

by Song

created 2018-08-04 08:51 UTC

Tools A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	298
Duplicated Lines	27.85 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

Metric	Value
dl	83
loc	298
rs	10
c	0
b	0
f	0
wmc	19
lcom	1
cbo	7

15 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	append()	0	6	1
A	prepend()	0	6	1
A	getResource()	0	8	2
A	disableList()	0	6	1
A	disableDelete()	0	6	1
A	disableEdit()	0	6	1
A	getListPath()	0	4	1
A	getEditPath()	0	6	1
A	getDeletePath()	0	6	1
A	renderList()	0	12	1
A	renderEdit()	0	12	1
B	renderDelete()	58	58	1
A	renderCustomTools()	14	14	3
A	render()	11	11	2

How to fix Duplicated Code

<?php

namespace Encore\Admin\Show;

use Encore\Admin\Admin;
use Illuminate\Contracts\Support\Htmlable;
use Illuminate\Contracts\Support\Renderable;
use Illuminate\Support\Collection;

class Tools implements Renderable
{
    /**
     * The panel that holds this tool.
     *
     * @var Panel
     */
    protected $panel;

    /**
     * @var string
     */
    protected $resource;

    /**
     * Default tools.
     *
     * @var array
     */
    protected $tools = ['delete', 'edit', 'list'];

    /**
     * Tools should be appends to default tools.
     *
     * @var Collection
     */
    protected $appends;

    /**
     * Tools should be prepends to default tools.
     *
     * @var Collection
     */
    protected $prepends;

    /**
     * Tools constructor.
     *
     * @param Panel $panel
     */
    public function __construct(Panel $panel)
    {
        $this->panel = $panel;

        $this->appends = new Collection();
        $this->prepends = new Collection();
    }

    /**
     * Append a tools.
     *
     * @param mixed $tool
     *
     * @return $this
     */
    public function append($tool)
    {
        $this->appends->push($tool);

        return $this;
    }

    /**
     * Prepend a tool.
     *
     * @param mixed $tool
     *
     * @return $this
     */
    public function prepend($tool)
    {
        $this->prepends->push($tool);

        return $this;
    }

    /**
     * Get resource path.
     *
     * @return string
     */
    public function getResource()
    {
        if (is_null($this->resource)) {
            $this->resource = $this->panel->getParent()->getResourcePath();
        }

        return $this->resource;
    }

    /**
     * Disable `list` tool.
     *
     * @return $this
     */
    public function disableList()
    {
        array_delete($this->tools, 'list');

        return $this;
    }

    /**
     * Disable `delete` tool.
     *
     * @return $this
     */
    public function disableDelete()
    {
        array_delete($this->tools, 'delete');

        return $this;
    }

    /**
     * Disable `edit` tool.
     *
     * @return $this
     */
    public function disableEdit()
    {
        array_delete($this->tools, 'edit');

        return $this;
    }

    /**
     * Get request path for resource list.
     *
     * @return string
     */
    protected function getListPath()
    {
        return '/'.ltrim($this->getResource(), '/');
    }

    /**
     * Get request path for edit.
     *
     * @return string
     */
    protected function getEditPath()
    {
        $key = $this->panel->getParent()->getModel()->getKey();

        return $this->getListPath().'/'.$key.'/edit';
    }

    /**
     * Get request path for delete.
     *
     * @return string
     */
    protected function getDeletePath()
    {
        $key = $this->panel->getParent()->getModel()->getKey();

        return $this->getListPath().'/'.$key;
    }

    /**
     * Render `list` tool.
     *
     * @return string
     */
    protected function renderList()
    {
        $list = trans('admin.list');

        return <<<HTML
<div class="btn-group pull-right" style="margin-right: 5px">
    <a href="{$this->getListPath()}" class="btn btn-sm btn-default">
        <i class="fa fa-list"></i> {$list}
    </a>
</div>
HTML;
    }

    /**
     * Render `edit` tool.
     *
     * @return string
     */
    protected function renderEdit()
    {
        $edit = trans('admin.edit');

        return <<<HTML
<div class="btn-group pull-right" style="margin-right: 5px">
    <a href="{$this->getEditPath()}" class="btn btn-sm btn-primary">
        <i class="fa fa-edit"></i> {$edit}
    </a>
</div>
HTML;
    }

    /**
     * Render `delete` tool.
     *
     * @return string
     */
    protected function renderDelete()

    {
        $deleteConfirm = trans('admin.delete_confirm');
        $confirm = trans('admin.confirm');
        $cancel = trans('admin.cancel');

        $class = uniqid();

        $script = <<<SCRIPT

$('.{$class}-delete').unbind('click').click(function() {

    swal({
      title: "$deleteConfirm",
      type: "warning",
      showCancelButton: true,
      confirmButtonColor: "#DD6B55",
      confirmButtonText: "$confirm",
      closeOnConfirm: false,
      cancelButtonText: "$cancel"
    },
    function(){
        $.ajax({
            method: 'post',
            url: '{$this->getDeletePath()}',
            data: {
                _method:'delete',
                _token:LA.token,
            },
            success: function (data) {
                $.pjax({container:'#pjax-container', url: '{$this->getListPath()}' });

                if (typeof data === 'object') {
                    if (data.status) {
                        swal(data.message, '', 'success');
                    } else {
                        swal(data.message, '', 'error');
                    }
                }
            }
        });
    });
});

SCRIPT;

        $delete = trans('admin.delete');

        Admin::script($script);

        return <<<HTML
<div class="btn-group pull-right" style="margin-right: 5px">
    <a href="javascript:void(0);" class="btn btn-sm btn-danger {$class}-delete">
        <i class="fa fa-trash"></i>  {$delete}
    </a>
</div>
HTML;
    }

    /**
     * Render custom tools.
     *
     * @param Collection $tools
     * @return mixed
     */
    protected function renderCustomTools($tools)

    {
        return $tools->map(function ($tool) {
            if ($tool instanceof Renderable) {
                return $tool->render();
            }

            if ($tool instanceof Htmlable) {
                return $tool->toHtml();
            }

            return (string) $tool;
        })->implode(' ');
    }

    /**
     * Render tools.
     *
     * @return string
     */
    public function render()

    {
        $output = $this->renderCustomTools($this->prepends);

        foreach ($this->tools as $tool) {
            $renderMethod = 'render'.ucfirst($tool);
            $output .= $this->$renderMethod();
        }

        return $output.$this->renderCustomTools($this->appends);
    }
}


1		<?php
2
3		namespace Encore\Admin\Show;
4
5		use Encore\Admin\Admin;
6		use Illuminate\Contracts\Support\Htmlable;
7		use Illuminate\Contracts\Support\Renderable;
8		use Illuminate\Support\Collection;
9
10		class Tools implements Renderable
11		{
12		/**
13		* The panel that holds this tool.
14		*
15		* @var Panel
16		*/
17		protected $panel;
18
19		/**
20		* @var string
21		*/
22		protected $resource;
23
24		/**
25		* Default tools.
26		*
27		* @var array
28		*/
29		protected $tools = ['delete', 'edit', 'list'];
30
31		/**
32		* Tools should be appends to default tools.
33		*
34		* @var Collection
35		*/
36		protected $appends;
37
38		/**
39		* Tools should be prepends to default tools.
40		*
41		* @var Collection
42		*/
43		protected $prepends;
44
45		/**
46		* Tools constructor.
47		*
48		* @param Panel $panel
49		*/
50		public function __construct(Panel $panel)
51		{
52		$this->panel = $panel;
53
54		$this->appends = new Collection();
55		$this->prepends = new Collection();
56		}
57
58		/**
59		* Append a tools.
60		*
61		* @param mixed $tool
62		*
63		* @return $this
64		*/
65		public function append($tool)
66		{
67		$this->appends->push($tool);
68
69		return $this;
70		}
71
72		/**
73		* Prepend a tool.
74		*
75		* @param mixed $tool
76		*
77		* @return $this
78		*/
79		public function prepend($tool)
80		{
81		$this->prepends->push($tool);
82
83		return $this;
84		}
85
86		/**
87		* Get resource path.
88		*
89		* @return string
90		*/
91		public function getResource()
92		{
93		if (is_null($this->resource)) {
94		$this->resource = $this->panel->getParent()->getResourcePath();
95		}
96
97		return $this->resource;
98		}
99
100		/**
101		* Disable `list` tool.
102		*
103		* @return $this
104		*/
105		public function disableList()
106		{
107		array_delete($this->tools, 'list');
108
109		return $this;
110		}
111
112		/**
113		* Disable `delete` tool.
114		*
115		* @return $this
116		*/
117		public function disableDelete()
118		{
119		array_delete($this->tools, 'delete');
120
121		return $this;
122		}
123
124		/**
125		* Disable `edit` tool.
126		*
127		* @return $this
128		*/
129		public function disableEdit()
130		{
131		array_delete($this->tools, 'edit');
132
133		return $this;
134		}
135
136		/**
137		* Get request path for resource list.
138		*
139		* @return string
140		*/
141		protected function getListPath()
142		{
143		return '/'.ltrim($this->getResource(), '/');
144		}
145
146		/**
147		* Get request path for edit.
148		*
149		* @return string
150		*/
151		protected function getEditPath()
152		{
153		$key = $this->panel->getParent()->getModel()->getKey();
154
155		return $this->getListPath().'/'.$key.'/edit';
156		}
157
158		/**
159		* Get request path for delete.
160		*
161		* @return string
162		*/
163		protected function getDeletePath()
164		{
165		$key = $this->panel->getParent()->getModel()->getKey();
166
167		return $this->getListPath().'/'.$key;
168		}
169
170		/**
171		* Render `list` tool.
172		*
173		* @return string
174		*/
175		protected function renderList()
176		{
177		$list = trans('admin.list');
178
179		return <<<HTML
180		<div class="btn-group pull-right" style="margin-right: 5px">
181		<a href="{$this->getListPath()}" class="btn btn-sm btn-default">
182		<i class="fa fa-list"></i> {$list}
183		</a>
184		</div>
185		HTML;
186		}
187
188		/**
189		* Render `edit` tool.
190		*
191		* @return string
192		*/
193		protected function renderEdit()
194		{
195		$edit = trans('admin.edit');
196
197		return <<<HTML
198		<div class="btn-group pull-right" style="margin-right: 5px">
199		<a href="{$this->getEditPath()}" class="btn btn-sm btn-primary">
200		<i class="fa fa-edit"></i> {$edit}
201		</a>
202		</div>
203		HTML;
204		}
205
206		/**
207		* Render `delete` tool.
208		*
209		* @return string
210		*/
211	View Code Duplication	protected function renderDelete()
		0 ignored issues – show Duplication introduced 2018-08-04 08:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
212		{
213		$deleteConfirm = trans('admin.delete_confirm');
214		$confirm = trans('admin.confirm');
215		$cancel = trans('admin.cancel');
216
217		$class = uniqid();
218
219		$script = <<<SCRIPT
220
221		$('.{$class}-delete').unbind('click').click(function() {
222
223		swal({
224		title: "$deleteConfirm",
225		type: "warning",
226		showCancelButton: true,
227		confirmButtonColor: "#DD6B55",
228		confirmButtonText: "$confirm",
229		closeOnConfirm: false,
230		cancelButtonText: "$cancel"
231		},
232		function(){
233		$.ajax({
234		method: 'post',
235		url: '{$this->getDeletePath()}',
236		data: {
237		_method:'delete',
238		_token:LA.token,
239		},
240		success: function (data) {
241		$.pjax({container:'#pjax-container', url: '{$this->getListPath()}' });
242
243		if (typeof data === 'object') {
244		if (data.status) {
245		swal(data.message, '', 'success');
246		} else {
247		swal(data.message, '', 'error');
248		}
249		}
250		}
251		});
252		});
253		});
254
255		SCRIPT;
256
257		$delete = trans('admin.delete');
258
259		Admin::script($script);
260
261		return <<<HTML
262		<div class="btn-group pull-right" style="margin-right: 5px">
263		<a href="javascript:void(0);" class="btn btn-sm btn-danger {$class}-delete">
264		<i class="fa fa-trash"></i> {$delete}
265		</a>
266		</div>
267		HTML;
268		}
269
270		/**
271		* Render custom tools.
272		*
273		* @param Collection $tools
274		* @return mixed
275		*/
276	View Code Duplication	protected function renderCustomTools($tools)
		0 ignored issues – show Duplication introduced 2018-08-04 08:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
277		{
278		return $tools->map(function ($tool) {
279		if ($tool instanceof Renderable) {
280		return $tool->render();
281		}
282
283		if ($tool instanceof Htmlable) {
284		return $tool->toHtml();
285		}
286
287		return (string) $tool;
288		})->implode(' ');
289		}
290
291		/**
292		* Render tools.
293		*
294		* @return string
295		*/
296	View Code Duplication	public function render()
		0 ignored issues – show Duplication introduced 2018-08-04 08:54 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
297		{
298		$output = $this->renderCustomTools($this->prepends);
299
300		foreach ($this->tools as $tool) {
301		$renderMethod = 'render'.ucfirst($tool);
302		$output .= $this->$renderMethod();
303		}
304
305		return $output.$this->renderCustomTools($this->appends);
306		}
307		}
308

z-song / laravel-admin

Push — master ( 77fd36...f39186 )

Tools A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

15 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like