Completed
Pull Request — master (#4037)
by Muhlis
02:38
created
src/Actions/Action.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     /**
123 123
      * @param string $prefix
124 124
      *
125
-     * @return mixed|string
125
+     * @return string
126 126
      */
127 127
     public function selector($prefix)
128 128
     {
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
     }
213 213
 
214 214
     /**
215
-     * @return mixed
215
+     * @return string
216 216
      */
217 217
     public function getCalledClass()
218 218
     {
@@ -403,7 +403,7 @@  discard block
 block discarded – undo
403 403
     }
404 404
 
405 405
     /**
406
-     * @return mixed
406
+     * @return string
407 407
      */
408 408
     public function render()
409 409
     {
Please login to merge, or discard this patch.
src/Grid/Tools/QuickCreate.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -34,6 +34,9 @@
 block discarded – undo
34 34
         $this->fields = Collection::make();
35 35
     }
36 36
 
37
+    /**
38
+     * @param string $placeholder
39
+     */
37 40
     protected function formatPlaceholder($placeholder)
38 41
     {
39 42
         return array_filter((array) $placeholder);
Please login to merge, or discard this patch.
src/Grid/Concerns/HasActions.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
     /**
25 25
      * Set grid action callback.
26 26
      *
27
-     * @param Closure|string $actions
27
+     * @param Closure $actions
28 28
      *
29 29
      * @return $this
30 30
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@
 block discarded – undo
88 88
      */
89 89
     public function batchActions(Closure $closure)
90 90
     {
91
-        $this->tools(function (Grid\Tools $tools) use ($closure) {
91
+        $this->tools(function(Grid\Tools $tools) use ($closure) {
92 92
             $tools->batch($closure);
93 93
         });
94 94
 
Please login to merge, or discard this patch.
src/Grid.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -357,7 +357,7 @@  discard block
 block discarded – undo
357 357
         $column = new Column($column, $label);
358 358
         $column->setGrid($this);
359 359
 
360
-        return tap($column, function ($value) {
360
+        return tap($column, function($value) {
361 361
             $this->columns->push($value);
362 362
         });
363 363
     }
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
421 421
         $column = new Column($column, $label);
422 422
         $column->setGrid($this);
423 423
 
424
-        return tap($column, function ($value) {
424
+        return tap($column, function($value) {
425 425
             $this->columns->prepend($value);
426 426
         });
427 427
     }
@@ -554,7 +554,7 @@  discard block
 block discarded – undo
554 554
 
555 555
         $data = $collection->toArray();
556 556
 
557
-        $this->columns->map(function (Column $column) use (&$data) {
557
+        $this->columns->map(function(Column $column) use (&$data) {
558 558
             $data = $column->fill($data);
559 559
 
560 560
             $this->columnNames[] = $column->getName();
@@ -574,7 +574,7 @@  discard block
 block discarded – undo
574 574
      */
575 575
     protected function buildRows(array $data)
576 576
     {
577
-        $this->rows = collect($data)->map(function ($model, $number) {
577
+        $this->rows = collect($data)->map(function($model, $number) {
578 578
             return new Row($number, $model, $this->keyName);
579 579
         });
580 580
 
Please login to merge, or discard this patch.
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
      * Get or set option for grid.
270 270
      *
271 271
      * @param string $key
272
-     * @param mixed  $value
272
+     * @param boolean  $value
273 273
      *
274 274
      * @return $this|mixed
275 275
      */
@@ -454,7 +454,7 @@  discard block
 block discarded – undo
454 454
     /**
455 455
      * Get the grid paginator.
456 456
      *
457
-     * @return mixed
457
+     * @return Tools\Paginator
458 458
      */
459 459
     public function paginator()
460 460
     {
@@ -532,7 +532,7 @@  discard block
 block discarded – undo
532 532
     }
533 533
 
534 534
     /**
535
-     * @return array|Collection|mixed
535
+     * @return Collection
536 536
      */
537 537
     protected function applyQuery()
538 538
     {
@@ -829,7 +829,7 @@  discard block
 block discarded – undo
829 829
     /**
830 830
      * Dynamically add columns to the grid view.
831 831
      *
832
-     * @param $method
832
+     * @param string $method
833 833
      * @param $arguments
834 834
      *
835 835
      * @return Column
Please login to merge, or discard this patch.
src/Grid/Tools/PerPageSelector.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -67,7 +67,7 @@
 block discarded – undo
67 67
     {
68 68
         Admin::script($this->script());
69 69
 
70
-        $options = $this->getOptions()->map(function ($option) {
70
+        $options = $this->getOptions()->map(function($option) {
71 71
             $selected = ($option == $this->perPage) ? 'selected' : '';
72 72
             $url = \request()->fullUrlWithQuery([$this->perPageName => $option]);
73 73
 
Please login to merge, or discard this patch.
src/Grid/Tools/Selector.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
             return [];
107 107
         }
108 108
 
109
-        $selected = array_filter($selected, function ($value) {
109
+        $selected = array_filter($selected, function($value) {
110 110
             return !is_null($value);
111 111
         });
112 112
 
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -57,7 +57,7 @@
 block discarded – undo
57 57
      * @param string $column
58 58
      * @param string $label
59 59
      * @param array  $options
60
-     * @param null   $query
60
+     * @param null|\Closure   $query
61 61
      * @param string $type
62 62
      *
63 63
      * @return $this
Please login to merge, or discard this patch.
src/Grid/Concerns/HasSelector.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 
27 27
         call_user_func($closure, $this->selector);
28 28
 
29
-        $this->header(function () {
29
+        $this->header(function() {
30 30
             return $this->renderSelector();
31 31
         });
32 32
 
@@ -46,7 +46,7 @@  discard block
 block discarded – undo
46 46
 
47 47
         $active = Selector::parseSelected();
48 48
 
49
-        $this->selector->getSelectors()->each(function ($selector, $column) use ($active) {
49
+        $this->selector->getSelectors()->each(function($selector, $column) use ($active) {
50 50
             if (!array_key_exists($column, $active)) {
51 51
                 return;
52 52
             }
Please login to merge, or discard this patch.
src/Controllers/MenuController.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,10 +26,10 @@  discard block
 block discarded – undo
26 26
         return $content
27 27
             ->title(trans('admin.menu'))
28 28
             ->description(trans('admin.list'))
29
-            ->row(function (Row $row) {
29
+            ->row(function(Row $row) {
30 30
                 $row->column(6, $this->treeView()->render());
31 31
 
32
-                $row->column(6, function (Column $column) {
32
+                $row->column(6, function(Column $column) {
33 33
                     $form = new \Encore\Admin\Widgets\Form();
34 34
                     $form->action(admin_url('auth/menu'));
35 35
 
@@ -71,10 +71,10 @@  discard block
 block discarded – undo
71 71
     {
72 72
         $menuModel = config('admin.database.menu_model');
73 73
 
74
-        return $menuModel::tree(function (Tree $tree) {
74
+        return $menuModel::tree(function(Tree $tree) {
75 75
             $tree->disableCreate();
76 76
 
77
-            $tree->branch(function ($branch) {
77
+            $tree->branch(function($branch) {
78 78
                 $payload = "<i class='fa {$branch['icon']}'></i>&nbsp;<strong>{$branch['title']}</strong>";
79 79
 
80 80
                 if (!isset($branch['children'])) {
Please login to merge, or discard this patch.
src/Grid/Displayers/Label.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
             $this->value = $this->value->toArray();
14 14
         }
15 15
 
16
-        return collect((array) $this->value)->map(function ($item) use ($style) {
16
+        return collect((array) $this->value)->map(function($item) use ($style) {
17 17
             if (is_array($style)) {
18 18
                 if (is_string($this->getColumn()->getOriginal()) || is_int($this->getColumn()->getOriginal())) {
19 19
                     $style = Arr::get($style, $this->getColumn()->getOriginal(), 'success');
Please login to merge, or discard this patch.