Number::min() - Code Metrics - Inspection of "1.5" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#1893)

unknown

created 2018-04-10 16:41 UTC

Number::min() A

↳ Parent: Number

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	3
nc	1
nop	1
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0

<?php

namespace Encore\Admin\Form\Field;

class Number extends Text
{
    protected static $js = [
        '/vendor/laravel-admin/number-input/bootstrap-number-input.js',
    ];

    public function render()
    {
        $this->default((int) $this->default);

        $this->script = <<<EOT

$('{$this->getElementClassSelector()}:not(.initialized)')
    .addClass('initialized')
    .bootstrapNumber({
        upClass: 'success',
        downClass: 'primary',
        center: true
    });

EOT;

        $this->prepend('')->defaultAttribute('style', 'width: 100px');

        return parent::render();

    }

    /**
     * Set min value of number field.
     *
     * @param integer $value
     * @return $this
     */
    public function min($value)
    {
        $this->attribute('min', $value);

        return $this;
    }

    /**
     * Set max value of number field.
     *
     * @param integer $value
     * @return $this
     */
    public function max($value)
    {
        $this->attribute('max', $value);

        return $this;
    }
}


1			<?php
2
3			namespace Encore\Admin\Form\Field;
4
5			class Number extends Text
6			{
7			protected static $js = [
8			'/vendor/laravel-admin/number-input/bootstrap-number-input.js',
9			];
10
11			public function render()
12			{
13			$this->default((int) $this->default);
14
15			$this->script = <<<EOT
16
17			$('{$this->getElementClassSelector()}:not(.initialized)')
18			.addClass('initialized')
19			.bootstrapNumber({
20			upClass: 'success',
21			downClass: 'primary',
22			center: true
23			});
24
25			EOT;
26
27			$this->prepend('')->defaultAttribute('style', 'width: 100px');
28
29			return parent::render();
			0 ignored issues – show Bug Compatibility introduced 2017-09-01 02:27 UTC by Report Bug Copy Issue Report The expression `parent::render();` of type `Illuminate\Contracts\Vie...ry\|Illuminate\View\View` adds the type `Illuminate\Contracts\View\Factory` to the return on line 29 which is incompatible with the return type declared by the interface `Illuminate\Contracts\Support\Renderable::render` of type `string`. Loading history...
30			}
31
32			/**
33			* Set min value of number field.
34			*
35			* @param integer $value
36			* @return $this
37			*/
38			public function min($value)
39			{
40			$this->attribute('min', $value);
41
42			return $this;
43			}
44
45			/**
46			* Set max value of number field.
47			*
48			* @param integer $value
49			* @return $this
50			*/
51			public function max($value)
52			{
53			$this->attribute('max', $value);
54
55			return $this;
56			}
57			}
58

z-song / laravel-admin

Pull Request — master (#1893)

Number::min() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like