Completed
Pull Request — master (#2381)
by leo
03:33
created
src/Show/Panel.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@
 block discarded – undo
138 138
     /**
139 139
      * Fill fields to panel.
140 140
      *
141
-     * @param []Field $fields
141
+     * @param Collection $fields
142 142
      *
143 143
      * @return $this
144 144
      */
Please login to merge, or discard this patch.
src/Grid/Tools/BatchActions.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
     /**
53 53
      * Add a batch action.
54 54
      *
55
-     * @param $title
55
+     * @param BatchDelete $title
56 56
      * @param BatchAction|null $action
57 57
      *
58 58
      * @return $this
Please login to merge, or discard this patch.
src/Grid/Filter/Scope.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
      */
56 56
     public function condition()
57 57
     {
58
-        return $this->queries->map(function ($query) {
58
+        return $this->queries->map(function($query) {
59 59
             return [$query['method'] => $query['arguments']];
60 60
         })->toArray();
61 61
     }
Please login to merge, or discard this patch.
src/Form/Tools.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -288,7 +288,7 @@
 block discarded – undo
288 288
             return '';
289 289
         }
290 290
 
291
-        return $tools->map(function ($tool) {
291
+        return $tools->map(function($tool) {
292 292
             if ($tool instanceof Renderable) {
293 293
                 return $tool->render();
294 294
             }
Please login to merge, or discard this patch.
src/Show/Tools.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -275,7 +275,7 @@
 block discarded – undo
275 275
      */
276 276
     protected function renderCustomTools($tools)
277 277
     {
278
-        return $tools->map(function ($tool) {
278
+        return $tools->map(function($tool) {
279 279
             if ($tool instanceof Renderable) {
280 280
                 return $tool->render();
281 281
             }
Please login to merge, or discard this patch.
src/Grid/Displayers/Table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
             $columns = $titles;
24 24
         }
25 25
 
26
-        $data = array_map(function ($item) use ($columns) {
26
+        $data = array_map(function($item) use ($columns) {
27 27
             $sorted = [];
28 28
 
29 29
             $arr = array_only($item, $columns);
Please login to merge, or discard this patch.
src/Form.php 2 patches
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -292,9 +292,9 @@  discard block
 block discarded – undo
292 292
         $data = $this->model->with($this->getRelations())
293 293
             ->findOrFail($id)->toArray();
294 294
 
295
-        $this->builder->fields()->filter(function ($field) {
295
+        $this->builder->fields()->filter(function($field) {
296 296
             return $field instanceof Field\File;
297
-        })->each(function (Field\File $file) use ($data) {
297
+        })->each(function(Field\File $file) use ($data) {
298 298
             $file->setOriginal($data);
299 299
 
300 300
             $file->destroy();
@@ -319,7 +319,7 @@  discard block
 block discarded – undo
319 319
             return $response;
320 320
         }
321 321
 
322
-        DB::transaction(function () {
322
+        DB::transaction(function() {
323 323
             $inserts = $this->prepareInsert($this->updates);
324 324
 
325 325
             foreach ($inserts as $column => $value) {
@@ -506,7 +506,7 @@  discard block
 block discarded – undo
506 506
             return $response;
507 507
         }
508 508
 
509
-        DB::transaction(function () {
509
+        DB::transaction(function() {
510 510
             $updates = $this->prepareUpdate($this->updates);
511 511
 
512 512
             foreach ($updates as $column => $value) {
@@ -939,7 +939,7 @@  discard block
 block discarded – undo
939 939
     protected function getFieldByColumn($column)
940 940
     {
941 941
         return $this->builder->fields()->first(
942
-            function (Field $field) use ($column) {
942
+            function(Field $field) use ($column) {
943 943
                 if (is_array($field->column())) {
944 944
                     return in_array($column, $field->column());
945 945
                 }
@@ -960,7 +960,7 @@  discard block
 block discarded – undo
960 960
 
961 961
         $values = $this->model->toArray();
962 962
 
963
-        $this->builder->fields()->each(function (Field $field) use ($values) {
963
+        $this->builder->fields()->each(function(Field $field) use ($values) {
964 964
             $field->setOriginal($values);
965 965
         });
966 966
     }
@@ -982,7 +982,7 @@  discard block
 block discarded – undo
982 982
 
983 983
         $data = $this->model->toArray();
984 984
 
985
-        $this->builder->fields()->each(function (Field $field) use ($data) {
985
+        $this->builder->fields()->each(function(Field $field) use ($data) {
986 986
             if (!in_array($field->column(), $this->ignored)) {
987 987
                 $field->fill($data);
988 988
             }
@@ -1105,7 +1105,7 @@  discard block
 block discarded – undo
1105 1105
      */
1106 1106
     public function setWidth($fieldWidth = 8, $labelWidth = 2)
1107 1107
     {
1108
-        $this->builder()->fields()->each(function ($field) use ($fieldWidth, $labelWidth) {
1108
+        $this->builder()->fields()->each(function($field) use ($fieldWidth, $labelWidth) {
1109 1109
             /* @var Field $field  */
1110 1110
             $field->setWidth($fieldWidth, $labelWidth);
1111 1111
         });
Please login to merge, or discard this patch.
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
      *
266 266
      * @param $id
267 267
      *
268
-     * @return mixed
268
+     * @return boolean
269 269
      */
270 270
     public function destroy($id)
271 271
     {
@@ -369,7 +369,7 @@  discard block
 block discarded – undo
369 369
      *
370 370
      * @param array $data
371 371
      *
372
-     * @return mixed
372
+     * @return Response|null
373 373
      */
374 374
     protected function prepare($data = [])
375 375
     {
@@ -429,7 +429,7 @@  discard block
 block discarded – undo
429 429
     /**
430 430
      * Call submitted callback.
431 431
      *
432
-     * @return mixed
432
+     * @return Response|null
433 433
      */
434 434
     protected function callSubmitted()
435 435
     {
@@ -443,7 +443,7 @@  discard block
 block discarded – undo
443 443
     /**
444 444
      * Call saving callback.
445 445
      *
446
-     * @return mixed
446
+     * @return Response|null
447 447
      */
448 448
     protected function callSaving()
449 449
     {
@@ -457,7 +457,7 @@  discard block
 block discarded – undo
457 457
     /**
458 458
      * Callback after saving a Model.
459 459
      *
460
-     * @return mixed|null
460
+     * @return Response|null
461 461
      */
462 462
     protected function callSaved()
463 463
     {
@@ -551,7 +551,7 @@  discard block
 block discarded – undo
551 551
     /**
552 552
      * Get RedirectResponse after update.
553 553
      *
554
-     * @param mixed $key
554
+     * @param integer $key
555 555
      *
556 556
      * @return \Illuminate\Http\RedirectResponse
557 557
      */
Please login to merge, or discard this patch.
src/Controllers/AuthController.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      *
35 35
      * @param Request $request
36 36
      *
37
-     * @return mixed
37
+     * @return \Illuminate\Http\RedirectResponse
38 38
      */
39 39
     public function postLogin(Request $request)
40 40
     {
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     /**
63 63
      * User logout.
64 64
      *
65
-     * @return Redirect
65
+     * @return \Illuminate\Http\RedirectResponse
66 66
      */
67 67
     public function getLogout(Request $request)
68 68
     {
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
      *
171 171
      * @param \Illuminate\Http\Request $request
172 172
      *
173
-     * @return \Illuminate\Http\Response
173
+     * @return \Illuminate\Http\RedirectResponse
174 174
      */
175 175
     protected function sendLoginResponse(Request $request)
176 176
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     {
84 84
         $form = $this->settingForm();
85 85
         $form->tools(
86
-            function (Form\Tools $tools) {
86
+            function(Form\Tools $tools) {
87 87
                 $tools->disableList();
88 88
             }
89 89
         );
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
         $form->image('avatar', trans('admin.avatar'));
119 119
         $form->password('password', trans('admin.password'))->rules('confirmed|required');
120 120
         $form->password('password_confirmation', trans('admin.password_confirmation'))->rules('required')
121
-            ->default(function ($form) {
121
+            ->default(function($form) {
122 122
                 return $form->model()->password;
123 123
             });
124 124
 
@@ -126,13 +126,13 @@  discard block
 block discarded – undo
126 126
 
127 127
         $form->ignore(['password_confirmation']);
128 128
 
129
-        $form->saving(function (Form $form) {
129
+        $form->saving(function(Form $form) {
130 130
             if ($form->password && $form->model()->password != $form->password) {
131 131
                 $form->password = bcrypt($form->password);
132 132
             }
133 133
         });
134 134
 
135
-        $form->saved(function () {
135
+        $form->saved(function() {
136 136
             admin_toastr(trans('admin.update_succeeded'));
137 137
 
138 138
             return redirect(admin_base_path('auth/setting'));
Please login to merge, or discard this patch.
src/Controllers/UserController.php 1 patch
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -87,14 +87,14 @@  discard block
 block discarded – undo
87 87
         $grid->created_at(trans('admin.created_at'));
88 88
         $grid->updated_at(trans('admin.updated_at'));
89 89
 
90
-        $grid->actions(function (Grid\Displayers\Actions $actions) {
90
+        $grid->actions(function(Grid\Displayers\Actions $actions) {
91 91
             if ($actions->getKey() == 1) {
92 92
                 $actions->disableDelete();
93 93
             }
94 94
         });
95 95
 
96
-        $grid->tools(function (Grid\Tools $tools) {
97
-            $tools->batch(function (Grid\Tools\BatchActions $actions) {
96
+        $grid->tools(function(Grid\Tools $tools) {
97
+            $tools->batch(function(Grid\Tools\BatchActions $actions) {
98 98
                 $actions->disableDelete();
99 99
             });
100 100
         });
@@ -115,10 +115,10 @@  discard block
 block discarded – undo
115 115
         $show->id('ID');
116 116
         $show->username(trans('admin.username'));
117 117
         $show->name(trans('admin.name'));
118
-        $show->roles(trans('admin.roles'))->as(function ($roles) {
118
+        $show->roles(trans('admin.roles'))->as(function($roles) {
119 119
             return $roles->pluck('name');
120 120
         })->label();
121
-        $show->permissions(trans('admin.permissions'))->as(function ($permission) {
121
+        $show->permissions(trans('admin.permissions'))->as(function($permission) {
122 122
             return $permission->pluck('name');
123 123
         })->label();
124 124
         $show->created_at(trans('admin.created_at'));
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
         $form->image('avatar', trans('admin.avatar'));
144 144
         $form->password('password', trans('admin.password'))->rules('required|confirmed');
145 145
         $form->password('password_confirmation', trans('admin.password_confirmation'))->rules('required')
146
-            ->default(function ($form) {
146
+            ->default(function($form) {
147 147
                 return $form->model()->password;
148 148
             });
149 149
 
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
         $form->display('created_at', trans('admin.created_at'));
156 156
         $form->display('updated_at', trans('admin.updated_at'));
157 157
 
158
-        $form->saving(function (Form $form) {
158
+        $form->saving(function(Form $form) {
159 159
             if ($form->password && $form->model()->password != $form->password) {
160 160
                 $form->password = bcrypt($form->password);
161 161
             }
Please login to merge, or discard this patch.