Text::render() - Code Metrics - Inspection of "Add icon to text input on Form" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2953)

unknown

created 2019-01-19 13:47 UTC

Text::render() A

↳ Parent: Text

Complexity

Conditions	2
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
nc	1
nop	0
dl	0
loc	19
rs	9.6333
c	0
b	0
f	0

<?php

namespace Encore\Admin\Form\Field;

use Encore\Admin\Form\Field;

class Text extends Field
{
    use PlainInput;

    /**
     * @var string
     */
    protected $icon = 'fa-pencil';

    /**
     * Add custom fa-icon.
     *
     * @param string $icon
     *
     * @return $this
     */
    public function addIcon($icon)
    {
        $this->icon = $icon;

        return $this;
    }

    /**
     * Render this filed.
     *
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function render()
    {
        $this->initPlainInput();

        $this->prepend('<i class="fa ' . $this->icon . ' fa-fw"></i>')
            ->defaultAttribute('type', 'text')
            ->defaultAttribute('id', $this->id)
            ->defaultAttribute('name', $this->elementName ?: $this->formatName($this->column))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            ->defaultAttribute('value', old($this->column, $this->value()))
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
            ->defaultAttribute('class', 'form-control '.$this->getElementClassString())
            ->defaultAttribute('placeholder', $this->getPlaceholder());

        $this->addVariables([
            'prepend' => $this->prepend,
            'append'  => $this->append,
        ]);

        return parent::render();

    }
}


1			<?php
2
3			namespace Encore\Admin\Form\Field;
4
5			use Encore\Admin\Form\Field;
6
7			class Text extends Field
8			{
9			use PlainInput;
10
11			/**
12			* @var string
13			*/
14			protected $icon = 'fa-pencil';
15
16			/**
17			* Add custom fa-icon.
18			*
19			* @param string $icon
20			*
21			* @return $this
22			*/
23			public function addIcon($icon)
24			{
25			$this->icon = $icon;
26
27			return $this;
28			}
29
30			/**
31			* Render this filed.
32			*
33			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
34			*/
35			public function render()
36			{
37			$this->initPlainInput();
38
39			$this->prepend('<i class="fa ' . $this->icon . ' fa-fw"></i>')
40			->defaultAttribute('type', 'text')
41			->defaultAttribute('id', $this->id)
42			->defaultAttribute('name', $this->elementName ?: $this->formatName($this->column))
			0 ignored issues – show Bug introduced 2017-09-19 15:53 UTC by Report Bug Copy Issue Report It seems like `$this->column` can also be of type `array`; however, `Encore\Admin\Form\Field::formatName()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
43			->defaultAttribute('value', old($this->column, $this->value()))
			0 ignored issues – show Bug introduced 2017-09-19 15:53 UTC by Report Bug Copy Issue Report It seems like `$this->column` can also be of type `array`; however, `old()` does only seem to accept `string\|null`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
44			->defaultAttribute('class', 'form-control '.$this->getElementClassString())
45			->defaultAttribute('placeholder', $this->getPlaceholder());
46
47			$this->addVariables([
48			'prepend' => $this->prepend,
49			'append' => $this->append,
50			]);
51
52			return parent::render();
			0 ignored issues – show Bug Compatibility introduced 2018-06-06 13:22 UTC by Report Bug Copy Issue Report The expression `parent::render();` of type `string\|Illuminate\View\V...\Contracts\View\Factory` adds the type `Illuminate\Contracts\View\Factory` to the return on line 52 which is incompatible with the return type declared by the interface `Illuminate\Contracts\Support\Renderable::render` of type `string`. Loading history...
53			}
54			}
55

z-song / laravel-admin

Pull Request — master (#2953)

Text::render() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like