Completed
Pull Request — master (#4435)
by Muhlis
07:58
created
src/Widgets/Carousel.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@
 block discarded – undo
24 24
     /**
25 25
      * Carousel constructor.
26 26
      *
27
-     * @param array $items
27
+     * @param \Illuminate\Support\Collection $items
28 28
      */
29 29
     public function __construct($items = [])
30 30
     {
Please login to merge, or discard this patch.
src/Grid/Displayers/Carousel.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -20,7 +20,7 @@
 block discarded – undo
20 20
             return '';
21 21
         }
22 22
 
23
-        $images = collect((array) $this->value)->filter()->map(function ($path) use ($server) {
23
+        $images = collect((array) $this->value)->filter()->map(function($path) use ($server) {
24 24
             if (url()->isValidUrl($path) || strpos($path, 'data:image') === 0) {
25 25
                 $image = $path;
26 26
             } elseif ($server) {
Please login to merge, or discard this patch.
src/Grid/Concerns/CanHidesColumns.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -46,7 +46,7 @@
 block discarded – undo
46 46
     /**
47 47
      * Setting default shown columns on grid.
48 48
      *
49
-     * @param array|string $columns
49
+     * @param string $columns
50 50
      *
51 51
      * @return $this
52 52
      */
Please login to merge, or discard this patch.
Spacing   +4 added lines, -5 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
      */
25 25
     public function disableColumnSelector(bool $disable = true)
26 26
     {
27
-        return $this->option('show_column_selector', ! $disable);
27
+        return $this->option('show_column_selector', !$disable);
28 28
     }
29 29
 
30 30
     /**
@@ -72,8 +72,7 @@  discard block
 block discarded – undo
72 72
     {
73 73
         $columns = explode(',', request(ColumnSelector::SELECT_COLUMN_NAME));
74 74
 
75
-        return array_filter($columns) ?:
76
-            array_values(array_diff($this->columnNames, $this->hiddenColumns));
75
+        return array_filter($columns) ?: array_values(array_diff($this->columnNames, $this->hiddenColumns));
77 76
     }
78 77
 
79 78
     /**
@@ -91,7 +90,7 @@  discard block
 block discarded – undo
91 90
 
92 91
         array_push($visible, Grid\Column::SELECT_COLUMN_NAME, Grid\Column::ACTION_COLUMN_NAME);
93 92
 
94
-        return $this->columns->filter(function (Grid\Column $column) use ($visible) {
93
+        return $this->columns->filter(function(Grid\Column $column) use ($visible) {
95 94
             return in_array($column->getName(), $visible);
96 95
         });
97 96
     }
@@ -111,7 +110,7 @@  discard block
 block discarded – undo
111 110
 
112 111
         array_push($visible, Grid\Column::SELECT_COLUMN_NAME, Grid\Column::ACTION_COLUMN_NAME);
113 112
 
114
-        return collect($this->columnNames)->filter(function ($column) use ($visible) {
113
+        return collect($this->columnNames)->filter(function($column) use ($visible) {
115 114
             return in_array($column, $visible);
116 115
         })->toArray();
117 116
     }
Please login to merge, or discard this patch.
src/Traits/Resizable.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
      * Generate thumbnail URL.
32 32
      *
33 33
      * @param $image
34
-     * @param $type
34
+     * @param string $type
35 35
      *
36 36
      * @return string
37 37
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     public function thumbnail($type, $attribute = 'image')
18 18
     {
19 19
         // Return empty string if the field not found
20
-        if (! isset($this->attributes[$attribute])) {
20
+        if (!isset($this->attributes[$attribute])) {
21 21
             return '';
22 22
         }
23 23
 
Please login to merge, or discard this patch.
src/Grid/Displayers/Badge.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
             $this->value = $this->value->toArray();
14 14
         }
15 15
 
16
-        return collect((array) $this->value)->map(function ($name) use ($style) {
16
+        return collect((array) $this->value)->map(function($name) use ($style) {
17 17
             if (is_array($style)) {
18 18
                 $style = Arr::get($style, $this->getColumn()->getOriginal(), 'red');
19 19
             }
Please login to merge, or discard this patch.
src/Grid/Column/HasHeader.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
      *
44 44
      * @param string $cast
45 45
      *
46
-     * @return Column|string
46
+     * @return HasHeader
47 47
      */
48 48
     protected function addSorter($cast = null)
49 49
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@
 block discarded – undo
115 115
      */
116 116
     public function renderHeader()
117 117
     {
118
-        return collect($this->headers)->map(function ($item) {
118
+        return collect($this->headers)->map(function($item) {
119 119
             if ($item instanceof Renderable) {
120 120
                 return $item->render();
121 121
             }
Please login to merge, or discard this patch.
src/Grid/Column/Help.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
             'title'     => $this->message,
38 38
         ];
39 39
 
40
-        $data = collect($data)->map(function ($val, $key) {
40
+        $data = collect($data)->map(function($val, $key) {
41 41
             return "data-{$key}=\"{$val}\"";
42 42
         })->implode(' ');
43 43
 
Please login to merge, or discard this patch.
src/Grid/Column/CheckFilter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -77,7 +77,7 @@
 block discarded – undo
77 77
     {
78 78
         $value = $this->getFilterValue([]);
79 79
 
80
-        $lists = collect($this->options)->map(function ($label, $key) use ($value) {
80
+        $lists = collect($this->options)->map(function($label, $key) use ($value) {
81 81
             $checked = in_array($key, $value) ? 'checked' : '';
82 82
 
83 83
             return <<<HTML
Please login to merge, or discard this patch.
src/Console/PermissionCommand.php 2 patches
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -112,6 +112,9 @@  discard block
 block discarded – undo
112 112
         ];
113 113
     }
114 114
 
115
+    /**
116
+     * @param string $permission
117
+     */
115 118
     private function generateHttpMethod($permission)
116 119
     {
117 120
         switch ($permission) {
@@ -134,6 +137,9 @@  discard block
 block discarded – undo
134 137
         return $http_method;
135 138
     }
136 139
 
140
+    /**
141
+     * @param string $permission
142
+     */
137 143
     private function generateHttpPath($table, $permission)
138 144
     {
139 145
         $resource = Str::kebab(Str::camel($table));
@@ -160,6 +166,9 @@  discard block
 block discarded – undo
160 166
         return $http_path;
161 167
     }
162 168
 
169
+    /**
170
+     * @param string $permission
171
+     */
163 172
     private function generateSlug($table, $permission)
164 173
     {
165 174
         return Str::kebab(Str::camel($table)).'.'.$permission;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
                 $slug = $this->generateSlug($table, $permission);
65 65
                 $name = $this->generateName($table, $permission_lang);
66 66
                 $exists = Permission::where('slug', $slug)->exists();
67
-                if (! $exists) {
67
+                if (!$exists) {
68 68
                     Permission::create([
69 69
                         'name'        => $name,
70 70
                         'slug'        => $slug,
Please login to merge, or discard this patch.