Completed
Pull Request — master (#4435)
by Muhlis
07:58
created
src/Controllers/AuthController.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      *
35 35
      * @param Request $request
36 36
      *
37
-     * @return mixed
37
+     * @return \Illuminate\Http\RedirectResponse
38 38
      */
39 39
     public function postLogin(Request $request)
40 40
     {
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     /**
63 63
      * User logout.
64 64
      *
65
-     * @return Redirect
65
+     * @return \Illuminate\Http\RedirectResponse
66 66
      */
67 67
     public function getLogout(Request $request)
68 68
     {
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
      *
171 171
      * @param \Illuminate\Http\Request $request
172 172
      *
173
-     * @return \Illuminate\Http\Response
173
+     * @return \Illuminate\Http\RedirectResponse
174 174
      */
175 175
     protected function sendLoginResponse(Request $request)
176 176
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
     {
96 96
         $form = $this->settingForm();
97 97
         $form->tools(
98
-            function (Form\Tools $tools) {
98
+            function(Form\Tools $tools) {
99 99
                 $tools->disableList();
100 100
                 $tools->disableDelete();
101 101
                 $tools->disableView();
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
         $form->image('avatar', trans('admin.avatar'));
134 134
         $form->password('password', trans('admin.password'))->rules('confirmed|required');
135 135
         $form->password('password_confirmation', trans('admin.password_confirmation'))->rules('required')
136
-            ->default(function ($form) {
136
+            ->default(function($form) {
137 137
                 return $form->model()->password;
138 138
             });
139 139
 
@@ -141,13 +141,13 @@  discard block
 block discarded – undo
141 141
 
142 142
         $form->ignore(['password_confirmation']);
143 143
 
144
-        $form->saving(function (Form $form) {
144
+        $form->saving(function(Form $form) {
145 145
             if ($form->password && $form->model()->password != $form->password) {
146 146
                 $form->password = bcrypt($form->password);
147 147
             }
148 148
         });
149 149
 
150
-        $form->saved(function () {
150
+        $form->saved(function() {
151 151
             admin_toastr(trans('admin.update_succeeded'));
152 152
 
153 153
             return redirect(admin_url('auth/setting'));
Please login to merge, or discard this patch.
src/Console/ResetPasswordCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,7 +31,7 @@
 block discarded – undo
31 31
         askForUserName:
32 32
         $username = $this->askWithCompletion('Please enter a username who needs to reset his password', $users->pluck('username')->toArray());
33 33
 
34
-        $user = $users->first(function ($user) use ($username) {
34
+        $user = $users->first(function($user) use ($username) {
35 35
             return $user->username == $username;
36 36
         });
37 37
 
Please login to merge, or discard this patch.
src/Console/AdminCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@
 block discarded – undo
56 56
      */
57 57
     protected function listAdminCommands()
58 58
     {
59
-        $commands = collect(Artisan::all())->mapWithKeys(function ($command, $key) {
59
+        $commands = collect(Artisan::all())->mapWithKeys(function($command, $key) {
60 60
             if (Str::startsWith($key, 'admin:')) {
61 61
                 return [$key => $command];
62 62
             }
Please login to merge, or discard this patch.
src/Grid/Filter/Layout/Column.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
      */
74 74
     public function removeFilterByID($id)
75 75
     {
76
-        $this->filters = $this->filters->reject(function (AbstractFilter $filter) use ($id) {
76
+        $this->filters = $this->filters->reject(function(AbstractFilter $filter) use ($id) {
77 77
             return $filter->getId() == $id;
78 78
         });
79 79
     }
Please login to merge, or discard this patch.
src/Grid/Displayers/SwitchDisplay.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
         if ($keys->isEmpty()) {
31 31
             $key = $name;
32 32
         } else {
33
-            $key = $keys->shift().$keys->reduce(function ($carry, $val) {
33
+            $key = $keys->shift().$keys->reduce(function($carry, $val) {
34 34
                 return $carry."[$val]";
35 35
             });
36 36
         }
Please login to merge, or discard this patch.
src/Grid/Displayers/Image.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
             $this->value = $this->value->toArray();
14 14
         }
15 15
 
16
-        return collect((array) $this->value)->filter()->map(function ($path) use ($server, $width, $height) {
16
+        return collect((array) $this->value)->filter()->map(function($path) use ($server, $width, $height) {
17 17
             if (url()->isValidUrl($path) || strpos($path, 'data:image') === 0) {
18 18
                 $src = $path;
19 19
             } elseif ($server) {
Please login to merge, or discard this patch.
src/Console/ExportSeedCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@
 block discarded – undo
89 89
         $fields = \DB::getSchemaBuilder()->getColumnListing($table);
90 90
         $fields = array_diff($fields, $exceptFields);
91 91
 
92
-        $array = \DB::table($table)->get($fields)->map(function ($item) {
92
+        $array = \DB::table($table)->get($fields)->map(function($item) {
93 93
             return (array) $item;
94 94
         })->all();
95 95
 
Please login to merge, or discard this patch.
src/Auth/Database/Permission.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
      *
92 92
      * @param string $path
93 93
      *
94
-     * @return mixed
94
+     * @return string
95 95
      */
96 96
     public function getHttpPathAttribute($path)
97 97
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 
70 70
         $method = $this->http_method;
71 71
 
72
-        $matches = array_map(function ($path) use ($method) {
72
+        $matches = array_map(function($path) use ($method) {
73 73
             $path = trim(config('admin.route.prefix'), '/').$path;
74 74
 
75 75
             if (Str::contains($path, ':')) {
@@ -117,11 +117,11 @@  discard block
 block discarded – undo
117 117
             $path = trim($match['path'], '/');
118 118
         }
119 119
 
120
-        if (! $request->is($path)) {
120
+        if (!$request->is($path)) {
121 121
             return false;
122 122
         }
123 123
 
124
-        $method = collect($match['method'])->filter()->map(function ($method) {
124
+        $method = collect($match['method'])->filter()->map(function($method) {
125 125
             return strtoupper($method);
126 126
         });
127 127
 
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
     {
162 162
         parent::boot();
163 163
 
164
-        static::deleting(function ($model) {
164
+        static::deleting(function($model) {
165 165
             $model->roles()->detach();
166 166
         });
167 167
     }
Please login to merge, or discard this patch.
resources/views/partials/exception.blade.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 @if($errors->hasBag('exception') && config('app.debug') == true)
2
-    <?php $error = $errors->getBag('exception');?>
2
+    <?php $error = $errors->getBag('exception'); ?>
3 3
     <div class="alert alert-warning alert-dismissable">
4 4
         <button type="button" class="close" data-dismiss="alert" aria-hidden="true">×</button>
5 5
         <h4>
Please login to merge, or discard this patch.