Completed
Pull Request — master (#3798)
by
unknown
02:44
created
src/Grid/Filter/Presenter/Select.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -168,7 +168,7 @@
 block discarded – undo
168 168
      *
169 169
      * @param string $target
170 170
      *
171
-     * @return mixed
171
+     * @return string
172 172
      */
173 173
     protected function getClass($target) : string
174 174
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
             throw new \InvalidArgumentException("[$model] must be a valid model class");
106 106
         }
107 107
 
108
-        $this->options = function ($value) use ($model, $idField, $textField) {
108
+        $this->options = function($value) use ($model, $idField, $textField) {
109 109
             if (empty($value)) {
110 110
                 return [];
111 111
             }
Please login to merge, or discard this patch.
src/Widgets/Navbar.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
             return '';
71 71
         }
72 72
 
73
-        return $this->elements[$part]->map(function ($element) {
73
+        return $this->elements[$part]->map(function($element) {
74 74
             if ($element instanceof Htmlable) {
75 75
                 return $element->toHtml();
76 76
             }
Please login to merge, or discard this patch.
src/Form/Field/Select.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
      *
39 39
      * @param array|callable|string $options
40 40
      *
41
-     * @return $this|mixed
41
+     * @return Select
42 42
      */
43 43
     public function options($options = [])
44 44
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -105,7 +105,7 @@
 block discarded – undo
105 105
             throw new \InvalidArgumentException("[$model] must be a valid model class");
106 106
         }
107 107
 
108
-        $this->options = function ($value) use ($model, $idField, $textField) {
108
+        $this->options = function($value) use ($model, $idField, $textField) {
109 109
             if (empty($value)) {
110 110
                 return [];
111 111
             }
Please login to merge, or discard this patch.
src/Auth/Database/Role.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -86,7 +86,7 @@
 block discarded – undo
86 86
     {
87 87
         parent::boot();
88 88
 
89
-        static::deleting(function ($model) {
89
+        static::deleting(function($model) {
90 90
             $model->administrators()->detach();
91 91
 
92 92
             $model->permissions()->detach();
Please login to merge, or discard this patch.
src/Auth/Database/Permission.php 2 patches
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
 
67 67
         $method = $this->http_method;
68 68
 
69
-        $matches = array_map(function ($path) use ($method) {
69
+        $matches = array_map(function($path) use ($method) {
70 70
             $path = trim(config('admin.route.prefix'), '/').$path;
71 71
 
72 72
             if (Str::contains($path, ':')) {
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
             return false;
101 101
         }
102 102
 
103
-        $method = collect($match['method'])->filter()->map(function ($method) {
103
+        $method = collect($match['method'])->filter()->map(function($method) {
104 104
             return strtoupper($method);
105 105
         });
106 106
 
@@ -140,7 +140,7 @@  discard block
 block discarded – undo
140 140
     {
141 141
         parent::boot();
142 142
 
143
-        static::deleting(function ($model) {
143
+        static::deleting(function($model) {
144 144
             $model->roles()->detach();
145 145
         });
146 146
     }
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@
 block discarded – undo
91 91
      *
92 92
      * @param string $path
93 93
      *
94
-     * @return mixed
94
+     * @return string
95 95
      */
96 96
     public function getHttpPathAttribute($path)
97 97
     {
Please login to merge, or discard this patch.
src/Auth/Database/HasPermissions.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -155,7 +155,7 @@
 block discarded – undo
155 155
     {
156 156
         parent::boot();
157 157
 
158
-        static::deleting(function ($model) {
158
+        static::deleting(function($model) {
159 159
             $model->roles()->detach();
160 160
 
161 161
             $model->permissions()->detach();
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
     /**
10 10
      * Get all permissions of user.
11 11
      *
12
-     * @return mixed
12
+     * @return Collection
13 13
      */
14 14
     public function allPermissions() : Collection
15 15
     {
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
     /**
20 20
      * Check if user has permission.
21 21
      *
22
-     * @param $ability
22
+     * @param string $ability
23 23
      * @param array $arguments
24 24
      *
25 25
      * @return bool
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
     /**
53 53
      * Check if user is administrator.
54 54
      *
55
-     * @return mixed
55
+     * @return boolean
56 56
      */
57 57
     public function isAdministrator() : bool
58 58
     {
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
      *
65 65
      * @param string $role
66 66
      *
67
-     * @return mixed
67
+     * @return boolean
68 68
      */
69 69
     public function isRole(string $role) : bool
70 70
     {
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
      *
77 77
      * @param array $roles
78 78
      *
79
-     * @return mixed
79
+     * @return boolean
80 80
      */
81 81
     public function inRoles(array $roles = []) : bool
82 82
     {
Please login to merge, or discard this patch.
src/Auth/Database/Menu.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@
 block discarded – undo
78 78
     {
79 79
         static::treeBoot();
80 80
 
81
-        static::deleting(function ($model) {
81
+        static::deleting(function($model) {
82 82
             $model->roles()->detach();
83 83
         });
84 84
     }
Please login to merge, or discard this patch.
src/Show.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -317,7 +317,7 @@
 block discarded – undo
317 317
      * @param string $method
318 318
      * @param array  $arguments
319 319
      *
320
-     * @return bool|mixed
320
+     * @return Field
321 321
      */
322 322
     public function __call($method, $arguments = [])
323 323
     {
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 
223 223
         $this->overwriteExistingField($name);
224 224
 
225
-        return tap($field, function ($field) {
225
+        return tap($field, function($field) {
226 226
             $this->fields->push($field);
227 227
         });
228 228
     }
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
 
245 245
         $this->overwriteExistingRelation($name);
246 246
 
247
-        return tap($relation, function ($relation) {
247
+        return tap($relation, function($relation) {
248 248
             $this->relations->push($relation);
249 249
         });
250 250
     }
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
         }
262 262
 
263 263
         $this->fields = $this->fields->filter(
264
-            function (Field $field) use ($name) {
264
+            function(Field $field) use ($name) {
265 265
                 return $field->getName() != $name;
266 266
             }
267 267
         );
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
         }
280 280
 
281 281
         $this->relations = $this->relations->filter(
282
-            function (Relation $relation) use ($name) {
282
+            function(Relation $relation) use ($name) {
283 283
                 return $relation->getName() != $name;
284 284
             }
285 285
         );
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
      */
337 337
     public function setWidth($fieldWidth = 8, $labelWidth = 2)
338 338
     {
339
-        collect($this->fields)->each(function ($field) use ($fieldWidth, $labelWidth) {
339
+        collect($this->fields)->each(function($field) use ($fieldWidth, $labelWidth) {
340 340
             $field->each->setWidth($fieldWidth, $labelWidth);
341 341
         });
342 342
 
Please login to merge, or discard this patch.
src/Show/Field.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     /**
89 89
      * Get name of this column.
90 90
      *
91
-     * @return mixed
91
+     * @return string
92 92
      */
93 93
     public function getName()
94 94
     {
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     /**
113 113
      * Get label of the column.
114 114
      *
115
-     * @return mixed
115
+     * @return string
116 116
      */
117 117
     public function getLabel()
118 118
     {
Please login to merge, or discard this patch.
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -192,7 +192,7 @@  discard block
 block discarded – undo
192 192
      */
193 193
     public function using(array $values, $default = null)
194 194
     {
195
-        return $this->as(function ($value) use ($values, $default) {
195
+        return $this->as(function($value) use ($values, $default) {
196 196
             if (is_null($value)) {
197 197
                 return $default;
198 198
             }
@@ -212,12 +212,12 @@  discard block
 block discarded – undo
212 212
      */
213 213
     public function image($server = '', $width = 200, $height = 200, $is_zoom = false)
214 214
     {
215
-        if ($is_zoom){
215
+        if ($is_zoom) {
216 216
             Admin::css('/vendor/laravel-admin/image-zoom/zoom.css');
217 217
             Admin::js('/vendor/laravel-admin/image-zoom/zoom.js');
218 218
         }
219
-        return $this->unescape()->as(function ($images) use ($server, $width, $height, $is_zoom) {
220
-            return collect($images)->map(function ($path) use ($server, $width, $height, $is_zoom) {
219
+        return $this->unescape()->as(function($images) use ($server, $width, $height, $is_zoom) {
220
+            return collect($images)->map(function($path) use ($server, $width, $height, $is_zoom) {
221 221
                 if (empty($path)) {
222 222
                     return '';
223 223
                 }
@@ -252,8 +252,8 @@  discard block
 block discarded – undo
252 252
      */
253 253
     public function carousel($width = 300, $height = 200, $server = '')
254 254
     {
255
-        return $this->unescape()->as(function ($images) use ($server, $width, $height) {
256
-            $items = collect($images)->map(function ($path) use ($server, $width, $height) {
255
+        return $this->unescape()->as(function($images) use ($server, $width, $height) {
256
+            $items = collect($images)->map(function($path) use ($server, $width, $height) {
257 257
                 if (empty($path)) {
258 258
                     return '';
259 259
                 }
@@ -293,7 +293,7 @@  discard block
 block discarded – undo
293 293
     {
294 294
         $field = $this;
295 295
 
296
-        return $this->unescape()->as(function ($path) use ($server, $download, $field) {
296
+        return $this->unescape()->as(function($path) use ($server, $download, $field) {
297 297
             $name = basename($path);
298 298
 
299 299
             $field->border = false;
@@ -347,7 +347,7 @@  discard block
 block discarded – undo
347 347
      */
348 348
     public function link($href = '', $target = '_blank')
349 349
     {
350
-        return $this->unescape()->as(function ($link) use ($href, $target) {
350
+        return $this->unescape()->as(function($link) use ($href, $target) {
351 351
             $href = $href ?: $link;
352 352
 
353 353
             return "<a href='$href' target='{$target}'>{$link}</a>";
@@ -363,12 +363,12 @@  discard block
 block discarded – undo
363 363
      */
364 364
     public function label($style = 'success')
365 365
     {
366
-        return $this->unescape()->as(function ($value) use ($style) {
366
+        return $this->unescape()->as(function($value) use ($style) {
367 367
             if ($value instanceof Arrayable) {
368 368
                 $value = $value->toArray();
369 369
             }
370 370
 
371
-            return collect((array) $value)->map(function ($name) use ($style) {
371
+            return collect((array) $value)->map(function($name) use ($style) {
372 372
                 return "<span class='label label-{$style}'>$name</span>";
373 373
             })->implode('&nbsp;');
374 374
         });
@@ -383,12 +383,12 @@  discard block
 block discarded – undo
383 383
      */
384 384
     public function badge($style = 'blue')
385 385
     {
386
-        return $this->unescape()->as(function ($value) use ($style) {
386
+        return $this->unescape()->as(function($value) use ($style) {
387 387
             if ($value instanceof Arrayable) {
388 388
                 $value = $value->toArray();
389 389
             }
390 390
 
391
-            return collect((array) $value)->map(function ($name) use ($style) {
391
+            return collect((array) $value)->map(function($name) use ($style) {
392 392
                 return "<span class='badge bg-{$style}'>$name</span>";
393 393
             })->implode('&nbsp;');
394 394
         });
@@ -403,7 +403,7 @@  discard block
 block discarded – undo
403 403
     {
404 404
         $field = $this;
405 405
 
406
-        return $this->unescape()->as(function ($value) use ($field) {
406
+        return $this->unescape()->as(function($value) use ($field) {
407 407
             $content = json_decode($value, true);
408 408
 
409 409
             if (json_last_error() == 0) {
@@ -423,7 +423,7 @@  discard block
 block discarded – undo
423 423
      */
424 424
     public function filesize()
425 425
     {
426
-        return $this->as(function ($value) {
426
+        return $this->as(function($value) {
427 427
             return file_size($value);
428 428
         });
429 429
     }
@@ -562,7 +562,7 @@  discard block
 block discarded – undo
562 562
 
563 563
         $field = $this;
564 564
 
565
-        return $this->as(function ($value) use ($extend, $field, $arguments) {
565
+        return $this->as(function($value) use ($extend, $field, $arguments) {
566 566
             if (!$extend->border) {
567 567
                 $field->border = false;
568 568
             }
@@ -621,7 +621,7 @@  discard block
 block discarded – undo
621 621
     public function render()
622 622
     {
623 623
         if ($this->showAs->isNotEmpty()) {
624
-            $this->showAs->each(function ($callable) {
624
+            $this->showAs->each(function($callable) {
625 625
                 $this->value = $callable->call(
626 626
                     $this->parent->getModel(),
627 627
                     $this->value
Please login to merge, or discard this patch.