Completed
Pull Request — master (#3324)
by bobo
02:23
created
src/Auth/Database/HasPermissions.php 2 patches
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -155,7 +155,7 @@
 block discarded – undo
155 155
     {
156 156
         parent::boot();
157 157
 
158
-        static::deleting(function ($model) {
158
+        static::deleting(function($model) {
159 159
             $model->roles()->detach();
160 160
 
161 161
             $model->permissions()->detach();
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -9,7 +9,7 @@  discard block
 block discarded – undo
9 9
     /**
10 10
      * Get all permissions of user.
11 11
      *
12
-     * @return mixed
12
+     * @return Collection
13 13
      */
14 14
     public function allPermissions() : Collection
15 15
     {
@@ -19,7 +19,7 @@  discard block
 block discarded – undo
19 19
     /**
20 20
      * Check if user has permission.
21 21
      *
22
-     * @param $ability
22
+     * @param string $ability
23 23
      * @param array $arguments
24 24
      *
25 25
      * @return bool
@@ -52,7 +52,7 @@  discard block
 block discarded – undo
52 52
     /**
53 53
      * Check if user is administrator.
54 54
      *
55
-     * @return mixed
55
+     * @return boolean
56 56
      */
57 57
     public function isAdministrator() : bool
58 58
     {
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
64 64
      *
65 65
      * @param string $role
66 66
      *
67
-     * @return mixed
67
+     * @return boolean
68 68
      */
69 69
     public function isRole(string $role) : bool
70 70
     {
@@ -76,7 +76,7 @@  discard block
 block discarded – undo
76 76
      *
77 77
      * @param array $roles
78 78
      *
79
-     * @return mixed
79
+     * @return boolean
80 80
      */
81 81
     public function inRoles(array $roles = []) : bool
82 82
     {
Please login to merge, or discard this patch.
src/Auth/Database/Menu.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -78,7 +78,7 @@
 block discarded – undo
78 78
     {
79 79
         static::treeBoot();
80 80
 
81
-        static::deleting(function ($model) {
81
+        static::deleting(function($model) {
82 82
             $model->roles()->detach();
83 83
         });
84 84
     }
Please login to merge, or discard this patch.
src/Show.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -317,7 +317,7 @@
 block discarded – undo
317 317
      * @param string $method
318 318
      * @param array  $arguments
319 319
      *
320
-     * @return bool|mixed
320
+     * @return Field
321 321
      */
322 322
     public function __call($method, $arguments = [])
323 323
     {
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -222,7 +222,7 @@  discard block
 block discarded – undo
222 222
 
223 223
         $this->overwriteExistingField($name);
224 224
 
225
-        return tap($field, function ($field) {
225
+        return tap($field, function($field) {
226 226
             $this->fields->push($field);
227 227
         });
228 228
     }
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
 
245 245
         $this->overwriteExistingRelation($name);
246 246
 
247
-        return tap($relation, function ($relation) {
247
+        return tap($relation, function($relation) {
248 248
             $this->relations->push($relation);
249 249
         });
250 250
     }
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
         }
262 262
 
263 263
         $this->fields = $this->fields->filter(
264
-            function (Field $field) use ($name) {
264
+            function(Field $field) use ($name) {
265 265
                 return $field->getName() != $name;
266 266
             }
267 267
         );
@@ -279,7 +279,7 @@  discard block
 block discarded – undo
279 279
         }
280 280
 
281 281
         $this->relations = $this->relations->filter(
282
-            function (Relation $relation) use ($name) {
282
+            function(Relation $relation) use ($name) {
283 283
                 return $relation->getName() != $name;
284 284
             }
285 285
         );
@@ -336,7 +336,7 @@  discard block
 block discarded – undo
336 336
      */
337 337
     public function setWidth($fieldWidth = 8, $labelWidth = 2)
338 338
     {
339
-        collect($this->fields)->each(function ($field) use ($fieldWidth, $labelWidth) {
339
+        collect($this->fields)->each(function($field) use ($fieldWidth, $labelWidth) {
340 340
             $field->each->setWidth($fieldWidth, $labelWidth);
341 341
         });
342 342
 
Please login to merge, or discard this patch.
src/Show/Field.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     /**
89 89
      * Get name of this column.
90 90
      *
91
-     * @return mixed
91
+     * @return string
92 92
      */
93 93
     public function getName()
94 94
     {
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     /**
113 113
      * Get label of the column.
114 114
      *
115
-     * @return mixed
115
+     * @return string
116 116
      */
117 117
     public function getLabel()
118 118
     {
Please login to merge, or discard this patch.
Spacing   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
      */
180 180
     public function using(array $values, $default = null)
181 181
     {
182
-        return $this->as(function ($value) use ($values, $default) {
182
+        return $this->as(function($value) use ($values, $default) {
183 183
             if (is_null($value)) {
184 184
                 return $default;
185 185
             }
@@ -199,8 +199,8 @@  discard block
 block discarded – undo
199 199
      */
200 200
     public function image($server = '', $width = 200, $height = 200)
201 201
     {
202
-        return $this->unescape()->as(function ($images) use ($server, $width, $height) {
203
-            return collect($images)->map(function ($path) use ($server, $width, $height) {
202
+        return $this->unescape()->as(function($images) use ($server, $width, $height) {
203
+            return collect($images)->map(function($path) use ($server, $width, $height) {
204 204
                 if (empty($path)) {
205 205
                     return '';
206 206
                 }
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
     {
237 237
         $field = $this;
238 238
 
239
-        return $this->unescape()->as(function ($path) use ($server, $download, $field) {
239
+        return $this->unescape()->as(function($path) use ($server, $download, $field) {
240 240
             $name = basename($path);
241 241
 
242 242
             $field->border = false;
@@ -288,7 +288,7 @@  discard block
 block discarded – undo
288 288
      */
289 289
     public function link($href = '', $target = '_blank')
290 290
     {
291
-        return $this->unescape()->as(function ($link) use ($href, $target) {
291
+        return $this->unescape()->as(function($link) use ($href, $target) {
292 292
             $href = $href ?: $link;
293 293
 
294 294
             return "<a href='$href' target='{$target}'>{$link}</a>";
@@ -304,12 +304,12 @@  discard block
 block discarded – undo
304 304
      */
305 305
     public function label($style = 'success')
306 306
     {
307
-        return $this->unescape()->as(function ($value) use ($style) {
307
+        return $this->unescape()->as(function($value) use ($style) {
308 308
             if ($value instanceof Arrayable) {
309 309
                 $value = $value->toArray();
310 310
             }
311 311
 
312
-            return collect((array) $value)->map(function ($name) use ($style) {
312
+            return collect((array) $value)->map(function($name) use ($style) {
313 313
                 return "<span class='label label-{$style}'>$name</span>";
314 314
             })->implode('&nbsp;');
315 315
         });
@@ -324,12 +324,12 @@  discard block
 block discarded – undo
324 324
      */
325 325
     public function badge($style = 'blue')
326 326
     {
327
-        return $this->unescape()->as(function ($value) use ($style) {
327
+        return $this->unescape()->as(function($value) use ($style) {
328 328
             if ($value instanceof Arrayable) {
329 329
                 $value = $value->toArray();
330 330
             }
331 331
 
332
-            return collect((array) $value)->map(function ($name) use ($style) {
332
+            return collect((array) $value)->map(function($name) use ($style) {
333 333
                 return "<span class='badge bg-{$style}'>$name</span>";
334 334
             })->implode('&nbsp;');
335 335
         });
@@ -344,7 +344,7 @@  discard block
 block discarded – undo
344 344
     {
345 345
         $field = $this;
346 346
 
347
-        return $this->unescape()->as(function ($value) use ($field) {
347
+        return $this->unescape()->as(function($value) use ($field) {
348 348
             $content = json_decode($value, true);
349 349
 
350 350
             if (json_last_error() == 0) {
@@ -473,7 +473,7 @@  discard block
 block discarded – undo
473 473
 
474 474
         $field = $this;
475 475
 
476
-        return $this->as(function ($value) use ($extend, $field, $arguments) {
476
+        return $this->as(function($value) use ($extend, $field, $arguments) {
477 477
             if (!$extend->border) {
478 478
                 $field->border = false;
479 479
             }
@@ -531,7 +531,7 @@  discard block
 block discarded – undo
531 531
     public function render()
532 532
     {
533 533
         if ($this->showAs->isNotEmpty()) {
534
-            $this->showAs->each(function ($callable) {
534
+            $this->showAs->each(function($callable) {
535 535
                 $this->value = $callable->call(
536 536
                     $this->parent->getModel(),
537 537
                     $this->value
Please login to merge, or discard this patch.
src/Show/Panel.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@
 block discarded – undo
138 138
     /**
139 139
      * Fill fields to panel.
140 140
      *
141
-     * @param []Field $fields
141
+     * @param Collection $fields
142 142
      *
143 143
      * @return $this
144 144
      */
Please login to merge, or discard this patch.
src/Grid/Tools/BatchActions.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
     /**
53 53
      * Add a batch action.
54 54
      *
55
-     * @param $title
55
+     * @param BatchDelete $title
56 56
      * @param BatchAction|null $action
57 57
      *
58 58
      * @return $this
Please login to merge, or discard this patch.
src/Grid/Filter/Scope.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
      */
56 56
     public function condition()
57 57
     {
58
-        return $this->queries->map(function ($query) {
58
+        return $this->queries->map(function($query) {
59 59
             return [$query['method'] => $query['arguments']];
60 60
         })->toArray();
61 61
     }
Please login to merge, or discard this patch.
src/Form/Tools.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -288,7 +288,7 @@
 block discarded – undo
288 288
             return '';
289 289
         }
290 290
 
291
-        return $tools->map(function ($tool) {
291
+        return $tools->map(function($tool) {
292 292
             if ($tool instanceof Renderable) {
293 293
                 return $tool->render();
294 294
             }
Please login to merge, or discard this patch.
src/Show/Tools.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -275,7 +275,7 @@
 block discarded – undo
275 275
      */
276 276
     protected function renderCustomTools($tools)
277 277
     {
278
-        return $tools->map(function ($tool) {
278
+        return $tools->map(function($tool) {
279 279
             if ($tool instanceof Renderable) {
280 280
                 return $tool->render();
281 281
             }
Please login to merge, or discard this patch.