Encore\Admin\Form\Field\ListField

Complexity

Total Complexity

13

Size/Duplication

Total Lines	145
Duplicated Lines	9.66 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	max()	0	6	1
A	min()	0	6	1
A	fill()	8	8	1
B	getValidator()	6	37	7
A	setupScript()	0	15	1
A	prepare()	0	4	1
A	render()	0	8	1

<?php

namespace Encore\Admin\Form\Field;

use Encore\Admin\Admin;
use Encore\Admin\Form\Field;
use Illuminate\Support\Arr;

class ListField extends Field
{
    /**
     * Max list size.
     *
     * @var int
     */
    protected $max;

    /**
     * Minimum list size.
     *
     * @var int
     */
    protected $min = 0;

    /**
     * @var array
     */
    protected $value = [''];

    /**
     * Set Max list size.
     *
     * @param int $size
     *
     * @return $this
     */
    public function max(int $size)
    {
        $this->max = $size;

        return $this;
    }

    /**
     * Set Minimum list size.
     *
     * @param int $size
     *
     * @return $this
     */
    public function min(int $size)
    {
        $this->min = $size;

        return $this;
    }

    /**
     * Fill data to the field.
     *
     * @param array $data
     *
     * @return void
     */
    public function fill($data)

This method seems to be duplicated in your project.

    {
        $this->data = $data;

        $this->value = Arr::get($data, $this->column, $this->value);

It seems like $this->column can also be of type array; however, Illuminate\Support\Arr::get() does only seem to accept string, maybe add an additional type check?

It seems like \Illuminate\Support\Arr::get($data, $this->column, $this->value) of type * is incompatible with the declared type array of property $value.

        $this->formatValue();
    }

    /**
     * {@inheritdoc}
     */
    public function getValidator(array $input)
    {
        if ($this->validator) {
            return $this->validator->call($this, $input);
        }

        if (!is_string($this->column)) {
            return false;
        }

        $rules = $attributes = [];

        if (!$fieldRules = $this->getRules()) {
            return false;
        }

        if (!Arr::has($input, $this->column)) {
            return false;
        }

        $rules["{$this->column}.values.*"] = $fieldRules;
        $attributes["{$this->column}.values.*"] = __('Value');

        $rules["{$this->column}.values"][] = 'array';

        if (!is_null($this->max)) {

This code seems to be duplicated across your project.

            $rules["{$this->column}.values"][] = "max:$this->max";
        }

        if (!is_null($this->min)) {

This code seems to be duplicated across your project.

            $rules["{$this->column}.values"][] = "min:$this->min";
        }

        $attributes["{$this->column}.values"] = $this->label;

        return validator($input, $rules, $this->getValidationMessages(), $attributes);
    }

    /**
     * {@inheritdoc}
     */
    protected function setupScript()
    {
        $this->script = <<<SCRIPT

$('.{$this->column}-add').on('click', function () {
    var tpl = $('template.{$this->column}-tpl').html();
    $('tbody.list-{$this->column}-table').append(tpl);
});

$('tbody').on('click', '.{$this->column}-remove', function () {
    $(this).closest('tr').remove();
});

SCRIPT;
    }

    /**
     * {@inheritdoc}
     */
    public function prepare($value)
    {
        return array_values($value['values']);
    }

    /**
     * {@inheritdoc}
     */
    public function render()
    {
        $this->setupScript();

        Admin::style('td .form-group {margin-bottom: 0 !important;}');

        return parent::render();

The expression parent::render(); of type string|Illuminate\View\View|Illuminate\Contracts\View\Factory adds the type Illuminate\Contracts\View\Factory to the return on line 151 which is incompatible with the return type declared by the interface Illuminate\Contracts\Support\Renderable::render of type string.

    }
}