Completed
Pull Request — master (#2868)
by milkmeowo
03:00 queued 33s
created
src/Show/Field.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     /**
89 89
      * Get name of this column.
90 90
      *
91
-     * @return mixed
91
+     * @return string
92 92
      */
93 93
     public function getName()
94 94
     {
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     /**
113 113
      * Get label of the column.
114 114
      *
115
-     * @return mixed
115
+     * @return string
116 116
      */
117 117
     public function getLabel()
118 118
     {
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -179,7 +179,7 @@  discard block
 block discarded – undo
179 179
      */
180 180
     public function using(array $values, $default = null)
181 181
     {
182
-        return $this->as(function ($value) use ($values, $default) {
182
+        return $this->as(function($value) use ($values, $default) {
183 183
             if (is_null($value)) {
184 184
                 return $default;
185 185
             }
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
      */
200 200
     public function image($server = '', $width = 200, $height = 200)
201 201
     {
202
-        return $this->unescape()->as(function ($path) use ($server, $width, $height) {
202
+        return $this->unescape()->as(function($path) use ($server, $width, $height) {
203 203
             if (empty($path)) {
204 204
                 return '';
205 205
             }
@@ -234,7 +234,7 @@  discard block
 block discarded – undo
234 234
     {
235 235
         $field = $this;
236 236
 
237
-        return $this->unescape()->as(function ($path) use ($server, $download, $field) {
237
+        return $this->unescape()->as(function($path) use ($server, $download, $field) {
238 238
             $name = basename($path);
239 239
 
240 240
             $field->wrapped = false;
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
      */
283 283
     public function link($href = '', $target = '_blank')
284 284
     {
285
-        return $this->unescape()->as(function ($link) use ($href, $target) {
285
+        return $this->unescape()->as(function($link) use ($href, $target) {
286 286
             $href = $href ?: $link;
287 287
 
288 288
             return "<a href='$href' target='{$target}'>{$link}</a>";
@@ -298,12 +298,12 @@  discard block
 block discarded – undo
298 298
      */
299 299
     public function label($style = 'success')
300 300
     {
301
-        return $this->unescape()->as(function ($value) use ($style) {
301
+        return $this->unescape()->as(function($value) use ($style) {
302 302
             if ($value instanceof Arrayable) {
303 303
                 $value = $value->toArray();
304 304
             }
305 305
 
306
-            return collect((array) $value)->map(function ($name) use ($style) {
306
+            return collect((array) $value)->map(function($name) use ($style) {
307 307
                 return "<span class='label label-{$style}'>$name</span>";
308 308
             })->implode('&nbsp;');
309 309
         });
@@ -318,12 +318,12 @@  discard block
 block discarded – undo
318 318
      */
319 319
     public function badge($style = 'blue')
320 320
     {
321
-        return $this->unescape()->as(function ($value) use ($style) {
321
+        return $this->unescape()->as(function($value) use ($style) {
322 322
             if ($value instanceof Arrayable) {
323 323
                 $value = $value->toArray();
324 324
             }
325 325
 
326
-            return collect((array) $value)->map(function ($name) use ($style) {
326
+            return collect((array) $value)->map(function($name) use ($style) {
327 327
                 return "<span class='badge bg-{$style}'>$name</span>";
328 328
             })->implode('&nbsp;');
329 329
         });
@@ -338,7 +338,7 @@  discard block
 block discarded – undo
338 338
     {
339 339
         $field = $this;
340 340
 
341
-        return $this->unescape()->as(function ($value) use ($field) {
341
+        return $this->unescape()->as(function($value) use ($field) {
342 342
             $content = json_decode($value, true);
343 343
 
344 344
             if (json_last_error() == 0) {
@@ -474,7 +474,7 @@  discard block
 block discarded – undo
474 474
     public function render()
475 475
     {
476 476
         if ($this->showAs->isNotEmpty()) {
477
-            $this->showAs->each(function ($callable) {
477
+            $this->showAs->each(function($callable) {
478 478
                 $this->value = $callable->call(
479 479
                     $this->parent->getModel(),
480 480
                     $this->value
Please login to merge, or discard this patch.
src/Show/Panel.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -138,7 +138,7 @@
 block discarded – undo
138 138
     /**
139 139
      * Fill fields to panel.
140 140
      *
141
-     * @param []Field $fields
141
+     * @param Collection $fields
142 142
      *
143 143
      * @return $this
144 144
      */
Please login to merge, or discard this patch.
src/Grid/Tools/BatchActions.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
     /**
53 53
      * Add a batch action.
54 54
      *
55
-     * @param $title
55
+     * @param BatchDelete $title
56 56
      * @param BatchAction|null $action
57 57
      *
58 58
      * @return $this
Please login to merge, or discard this patch.
src/Grid/Filter/Scope.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
      */
56 56
     public function condition()
57 57
     {
58
-        return $this->queries->map(function ($query) {
58
+        return $this->queries->map(function($query) {
59 59
             return [$query['method'] => $query['arguments']];
60 60
         })->toArray();
61 61
     }
Please login to merge, or discard this patch.
src/Form/Tools.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -288,7 +288,7 @@
 block discarded – undo
288 288
             return '';
289 289
         }
290 290
 
291
-        return $tools->map(function ($tool) {
291
+        return $tools->map(function($tool) {
292 292
             if ($tool instanceof Renderable) {
293 293
                 return $tool->render();
294 294
             }
Please login to merge, or discard this patch.
src/Show/Tools.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -275,7 +275,7 @@
 block discarded – undo
275 275
      */
276 276
     protected function renderCustomTools($tools)
277 277
     {
278
-        return $tools->map(function ($tool) {
278
+        return $tools->map(function($tool) {
279 279
             if ($tool instanceof Renderable) {
280 280
                 return $tool->render();
281 281
             }
Please login to merge, or discard this patch.
src/Grid/Model.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -411,7 +411,7 @@  discard block
 block discarded – undo
411 411
     /**
412 412
      * Resolve perPage for pagination.
413 413
      *
414
-     * @param array|null $paginate
414
+     * @param Model $paginate
415 415
      *
416 416
      * @return array
417 417
      */
@@ -441,7 +441,7 @@  discard block
 block discarded – undo
441 441
     /**
442 442
      * Find query by method name.
443 443
      *
444
-     * @param $method
444
+     * @param string $method
445 445
      *
446 446
      * @return static
447 447
      */
@@ -534,7 +534,7 @@  discard block
 block discarded – undo
534 534
      *
535 535
      * @throws \Exception
536 536
      *
537
-     * @return array
537
+     * @return string[]
538 538
      */
539 539
     protected function joinParameters(Relation $relation)
540 540
     {
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -311,9 +311,9 @@  discard block
 block discarded – undo
311 311
 
312 312
         $this->setSort();
313 313
 
314
-        $this->queries->reject(function ($query) {
314
+        $this->queries->reject(function($query) {
315 315
             return $query['method'] == 'paginate';
316
-        })->each(function ($query) {
316
+        })->each(function($query) {
317 317
             $this->model = $this->model->{$query['method']}(...$query['arguments']);
318 318
         });
319 319
 
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
         $this->setSort();
365 365
         $this->setPaginate();
366 366
 
367
-        $this->queries->unique()->each(function ($query) {
367
+        $this->queries->unique()->each(function($query) {
368 368
             $this->model = call_user_func_array([$this->model, $query['method']], $query['arguments']);
369 369
         });
370 370
 
@@ -394,9 +394,9 @@  discard block
 block discarded – undo
394 394
 
395 395
         $queryBuilder = $this->originalModel;
396 396
 
397
-        $this->queries->reject(function ($query) {
397
+        $this->queries->reject(function($query) {
398 398
             return in_array($query['method'], ['get', 'paginate']);
399
-        })->each(function ($query) use (&$queryBuilder) {
399
+        })->each(function($query) use (&$queryBuilder) {
400 400
             $queryBuilder = $queryBuilder->{$query['method']}(...$query['arguments']);
401 401
         });
402 402
 
@@ -430,7 +430,7 @@  discard block
 block discarded – undo
430 430
     {
431 431
         $paginate = $this->findQueryByMethod('paginate');
432 432
 
433
-        $this->queries = $this->queries->reject(function ($query) {
433
+        $this->queries = $this->queries->reject(function($query) {
434 434
             return $query['method'] == 'paginate';
435 435
         });
436 436
 
@@ -488,7 +488,7 @@  discard block
 block discarded – undo
488 488
      */
489 489
     protected function findQueryByMethod($method)
490 490
     {
491
-        return $this->queries->first(function ($query) use ($method) {
491
+        return $this->queries->first(function($query) use ($method) {
492 492
             return $query['method'] == $method;
493 493
         });
494 494
     }
@@ -532,7 +532,7 @@  discard block
 block discarded – undo
532 532
     {
533 533
         list($relationName, $relationColumn) = explode('.', $column);
534 534
 
535
-        if ($this->queries->contains(function ($query) use ($relationName) {
535
+        if ($this->queries->contains(function($query) use ($relationName) {
536 536
             return $query['method'] == 'with' && in_array($relationName, $query['arguments']);
537 537
         })) {
538 538
             $relation = $this->model->$relationName();
@@ -561,7 +561,7 @@  discard block
 block discarded – undo
561 561
      */
562 562
     public function resetOrderBy()
563 563
     {
564
-        $this->queries = $this->queries->reject(function ($query) {
564
+        $this->queries = $this->queries->reject(function($query) {
565 565
             return $query['method'] == 'orderBy' || $query['method'] == 'orderByDesc';
566 566
         });
567 567
     }
Please login to merge, or discard this patch.
src/Grid/Displayers/Table.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@
 block discarded – undo
23 23
             $columns = $titles;
24 24
         }
25 25
 
26
-        $data = array_map(function ($item) use ($columns) {
26
+        $data = array_map(function($item) use ($columns) {
27 27
             $sorted = [];
28 28
 
29 29
             $arr = array_only($item, $columns);
Please login to merge, or discard this patch.
src/Controllers/AuthController.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -34,7 +34,7 @@  discard block
 block discarded – undo
34 34
      *
35 35
      * @param Request $request
36 36
      *
37
-     * @return mixed
37
+     * @return \Illuminate\Http\RedirectResponse
38 38
      */
39 39
     public function postLogin(Request $request)
40 40
     {
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
     /**
63 63
      * User logout.
64 64
      *
65
-     * @return Redirect
65
+     * @return \Illuminate\Http\RedirectResponse
66 66
      */
67 67
     public function getLogout(Request $request)
68 68
     {
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
      *
171 171
      * @param \Illuminate\Http\Request $request
172 172
      *
173
-     * @return \Illuminate\Http\Response
173
+     * @return \Illuminate\Http\RedirectResponse
174 174
      */
175 175
     protected function sendLoginResponse(Request $request)
176 176
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     {
84 84
         $form = $this->settingForm();
85 85
         $form->tools(
86
-            function (Form\Tools $tools) {
86
+            function(Form\Tools $tools) {
87 87
                 $tools->disableList();
88 88
             }
89 89
         );
@@ -118,7 +118,7 @@  discard block
 block discarded – undo
118 118
         $form->image('avatar', trans('admin.avatar'));
119 119
         $form->password('password', trans('admin.password'))->rules('confirmed|required');
120 120
         $form->password('password_confirmation', trans('admin.password_confirmation'))->rules('required')
121
-            ->default(function ($form) {
121
+            ->default(function($form) {
122 122
                 return $form->model()->password;
123 123
             });
124 124
 
@@ -126,13 +126,13 @@  discard block
 block discarded – undo
126 126
 
127 127
         $form->ignore(['password_confirmation']);
128 128
 
129
-        $form->saving(function (Form $form) {
129
+        $form->saving(function(Form $form) {
130 130
             if ($form->password && $form->model()->password != $form->password) {
131 131
                 $form->password = bcrypt($form->password);
132 132
             }
133 133
         });
134 134
 
135
-        $form->saved(function () {
135
+        $form->saved(function() {
136 136
             admin_toastr(trans('admin.update_succeeded'));
137 137
 
138 138
             return redirect(admin_base_path('auth/setting'));
Please login to merge, or discard this patch.