HasElementNames - Code Metrics - Inspection of "[fix] Add `show` interface." - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 024746...0b49f1 )

by Song

created 2018-08-01 15:33 UTC

HasElementNames A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	118
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
dl	0
loc	118
rs	10
c	0
b	0
f	0
wmc	11
lcom	1
cbo	0

9 Methods

Rating	Name	Size	Complexity
A	setName()	10	1
A	getName()	4	1
A	getGridRowName()	4	1
A	getSelectAllName()	4	1
A	getPerPageName()	4	1
A	getGridBatchName()	4	1
A	getExportSelectedName()	4	1
A	getSelectedRowsName()	10	2
A	elementNameWithPrefix()	10	2

<?php

namespace Encore\Admin\Grid;

trait HasElementNames
{
    /**
     * Grid name.
     *
     * @var string
     */
    protected $name;

    /**
     * HTML element names.
     *
     * @var array
     */
    protected $elementNames = [
        'grid_row'        => 'grid-row',
        'grid_select_all' => 'grid-select-all',
        'grid_per_page'   => 'grid-per-pager',
        'grid_batch'      => 'grid-batch',
        'export_selected' => 'export-selected',
        'selected_rows'   => 'selectedRows',
    ];

    /**
     * Set name to grid.
     *
     * @param string $name
     * @return $this
     */
    public function setName($name)
    {
        $this->name = $name;

        $this->model()->setPerPageName("{$name}_{$this->model()->getPerPageName()}");
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        $this->getFilter()->setName($name);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this;
    }

    /**
     * Get name of grid.
     *
     * @return string
     */
    public function getName()
    {
        return $this->name;
    }

    /**
     * @return string
     */
    public function getGridRowName()
    {
        return $this->elementNameWithPrefix('grid_row');
    }

    /**
     * @return string
     */
    public function getSelectAllName()
    {
        return $this->elementNameWithPrefix('grid_select_all');
    }

    /**
     * @return string
     */
    public function getPerPageName()
    {
        return $this->elementNameWithPrefix('grid_per_page');
    }

    /**
     * @return string
     */
    public function getGridBatchName()
    {
        return $this->elementNameWithPrefix('grid_batch');
    }

    /**
     * @return string
     */
    public function getExportSelectedName()
    {
        return $this->elementNameWithPrefix('export_selected');
    }

    /**
     * @return string
     */
    public function getSelectedRowsName()
    {
        $elementName = $this->elementNames['selected_rows'];

        if ($this->name) {
            return sprintf("%s%s", $this->name, ucfirst($elementName));
        }

        return $elementName;
    }

    /**
     * @return string
     */
    protected function elementNameWithPrefix($name)
    {
        $elementName = $this->elementNames[$name];

        if ($this->name) {
            return sprintf("%s-%s", $this->name, $elementName);
        }

        return $elementName;
    }
}


1			<?php
2
3			namespace Encore\Admin\Grid;
4
5			trait HasElementNames
6			{
7			/**
8			* Grid name.
9			*
10			* @var string
11			*/
12			protected $name;
13
14			/**
15			* HTML element names.
16			*
17			* @var array
18			*/
19			protected $elementNames = [
20			'grid_row' => 'grid-row',
21			'grid_select_all' => 'grid-select-all',
22			'grid_per_page' => 'grid-per-pager',
23			'grid_batch' => 'grid-batch',
24			'export_selected' => 'export-selected',
25			'selected_rows' => 'selectedRows',
26			];
27
28			/**
29			* Set name to grid.
30			*
31			* @param string $name
32			* @return $this
33			*/
34			public function setName($name)
35			{
36			$this->name = $name;
37
38			$this->model()->setPerPageName("{$name}_{$this->model()->getPerPageName()}");
			0 ignored issues – show Bug introduced 2018-08-01 15:37 UTC by Report Bug Copy Issue Report It seems like `model()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
39
40			$this->getFilter()->setName($name);
			0 ignored issues – show Bug introduced 2018-08-01 15:37 UTC by Report Bug Copy Issue Report It seems like `getFilter()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
41
42			return $this;
43			}
44
45			/**
46			* Get name of grid.
47			*
48			* @return string
49			*/
50			public function getName()
51			{
52			return $this->name;
53			}
54
55			/**
56			* @return string
57			*/
58			public function getGridRowName()
59			{
60			return $this->elementNameWithPrefix('grid_row');
61			}
62
63			/**
64			* @return string
65			*/
66			public function getSelectAllName()
67			{
68			return $this->elementNameWithPrefix('grid_select_all');
69			}
70
71			/**
72			* @return string
73			*/
74			public function getPerPageName()
75			{
76			return $this->elementNameWithPrefix('grid_per_page');
77			}
78
79			/**
80			* @return string
81			*/
82			public function getGridBatchName()
83			{
84			return $this->elementNameWithPrefix('grid_batch');
85			}
86
87			/**
88			* @return string
89			*/
90			public function getExportSelectedName()
91			{
92			return $this->elementNameWithPrefix('export_selected');
93			}
94
95			/**
96			* @return string
97			*/
98			public function getSelectedRowsName()
99			{
100			$elementName = $this->elementNames['selected_rows'];
101
102			if ($this->name) {
103			return sprintf("%s%s", $this->name, ucfirst($elementName));
104			}
105
106			return $elementName;
107			}
108
109			/**
110			* @return string
111			*/
112			protected function elementNameWithPrefix($name)
113			{
114			$elementName = $this->elementNames[$name];
115
116			if ($this->name) {
117			return sprintf("%s-%s", $this->name, $elementName);
118			}
119
120			return $elementName;
121			}
122			}
123

z-song / laravel-admin

Push — master ( 024746...0b49f1 )

HasElementNames A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

Duplication Side-by-Side

Filter issues like