Completed
Pull Request — master (#3506)
by jxlwqq
02:19
created
src/Form/Tab.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
         $all = $fields->toArray();
71 71
 
72 72
         foreach ($this->form->rows as $row) {
73
-            $rowFields = array_map(function ($field) {
73
+            $rowFields = array_map(function($field) {
74 74
                 return $field['element'];
75 75
             }, $row->getFields());
76 76
 
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
     public function getTabs()
105 105
     {
106 106
         // If there is no active tab, then active the first.
107
-        if ($this->tabs->filter(function ($tab) {
107
+        if ($this->tabs->filter(function($tab) {
108 108
             return $tab['active'];
109 109
         })->isEmpty()) {
110 110
             $first = $this->tabs->first();
Please login to merge, or discard this patch.
src/Grid/Filter/Layout/Column.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -73,7 +73,7 @@
 block discarded – undo
73 73
      */
74 74
     public function removeFilterByID($id)
75 75
     {
76
-        $this->filters = $this->filters->reject(function (AbstractFilter $filter) use ($id) {
76
+        $this->filters = $this->filters->reject(function(AbstractFilter $filter) use ($id) {
77 77
             return $filter->getId() == $id;
78 78
         });
79 79
     }
Please login to merge, or discard this patch.
src/Middleware/LogOperation.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@
 block discarded – undo
66 66
             return true;
67 67
         }
68 68
 
69
-        return $allowedMethods->map(function ($method) {
69
+        return $allowedMethods->map(function($method) {
70 70
             return strtoupper($method);
71 71
         })->contains($method);
72 72
     }
Please login to merge, or discard this patch.
src/Grid/Displayers/SwitchDisplay.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
         if ($keys->isEmpty()) {
31 31
             $key = $name;
32 32
         } else {
33
-            $key = $keys->shift().$keys->reduce(function ($carry, $val) {
33
+            $key = $keys->shift().$keys->reduce(function($carry, $val) {
34 34
                 return $carry."[$val]";
35 35
             });
36 36
         }
Please login to merge, or discard this patch.
src/Grid/Displayers/SwitchGroup.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@
 block discarded – undo
30 30
         if ($keys->isEmpty()) {
31 31
             $key = $name;
32 32
         } else {
33
-            $key = $keys->shift().$keys->reduce(function ($carry, $val) {
33
+            $key = $keys->shift().$keys->reduce(function($carry, $val) {
34 34
                 return $carry."[$val]";
35 35
             });
36 36
         }
Please login to merge, or discard this patch.
src/Grid/Column.php 2 patches
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
 
317 317
         $column = $this;
318 318
 
319
-        return $this->display(function ($value) use ($grid, $column, $abstract, $arguments) {
319
+        return $this->display(function($value) use ($grid, $column, $abstract, $arguments) {
320 320
             /** @var AbstractDisplayer $displayer */
321 321
             $displayer = new $abstract($value, $grid, $column, $this);
322 322
 
@@ -334,7 +334,7 @@  discard block
 block discarded – undo
334 334
      */
335 335
     public function using(array $values, $default = null)
336 336
     {
337
-        return $this->display(function ($value) use ($values, $default) {
337
+        return $this->display(function($value) use ($values, $default) {
338 338
             if (is_null($value)) {
339 339
                 return $default;
340 340
             }
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
      */
353 353
     public function view($view)
354 354
     {
355
-        return $this->display(function ($value) use ($view) {
355
+        return $this->display(function($value) use ($view) {
356 356
             $model = $this;
357 357
 
358 358
             return view($view, compact('model', 'value'))->render();
@@ -475,7 +475,7 @@  discard block
 block discarded – undo
475 475
         $grid = $this->grid;
476 476
         $column = $this;
477 477
 
478
-        $this->display(function ($value) use ($grid, $column, $class) {
478
+        $this->display(function($value) use ($grid, $column, $class) {
479 479
             /** @var AbstractDisplayer $definition */
480 480
             $definition = new $class($value, $grid, $column, $this);
481 481
 
@@ -493,7 +493,7 @@  discard block
 block discarded – undo
493 493
     protected function htmlEntityEncode($item)
494 494
     {
495 495
         if (is_array($item)) {
496
-            array_walk_recursive($item, function (&$value) {
496
+            array_walk_recursive($item, function(&$value) {
497 497
                 $value = htmlentities($value);
498 498
             });
499 499
         } else {
@@ -573,7 +573,7 @@  discard block
 block discarded – undo
573 573
      */
574 574
     protected function callSupportDisplayer($abstract, $arguments)
575 575
     {
576
-        return $this->display(function ($value) use ($abstract, $arguments) {
576
+        return $this->display(function($value) use ($abstract, $arguments) {
577 577
             if (is_array($value) || $value instanceof Arrayable) {
578 578
                 return call_user_func_array([collect($value), $abstract], $arguments);
579 579
             }
@@ -597,7 +597,7 @@  discard block
 block discarded – undo
597 597
     protected function callBuiltinDisplayer($abstract, $arguments)
598 598
     {
599 599
         if ($abstract instanceof Closure) {
600
-            return $this->display(function ($value) use ($abstract, $arguments) {
600
+            return $this->display(function($value) use ($abstract, $arguments) {
601 601
                 return $abstract->call($this, ...array_merge([$value], $arguments));
602 602
             });
603 603
         }
@@ -606,7 +606,7 @@  discard block
 block discarded – undo
606 606
             $grid = $this->grid;
607 607
             $column = $this;
608 608
 
609
-            return $this->display(function ($value) use ($abstract, $grid, $column, $arguments) {
609
+            return $this->display(function($value) use ($abstract, $grid, $column, $arguments) {
610 610
                 /** @var AbstractDisplayer $displayer */
611 611
                 $displayer = new $abstract($value, $grid, $column, $this);
612 612
 
Please login to merge, or discard this patch.
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
     /**
166 166
      * Extend column displayer.
167 167
      *
168
-     * @param $name
168
+     * @param string $name
169 169
      * @param $displayer
170 170
      */
171 171
     public static function extend($name, $displayer)
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
     /**
200 200
      * Set model for column.
201 201
      *
202
-     * @param $model
202
+     * @param Model $model
203 203
      */
204 204
     public function setModel($model)
205 205
     {
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
     /**
272 272
      * Get name of this column.
273 273
      *
274
-     * @return mixed
274
+     * @return string
275 275
      */
276 276
     public function getName()
277 277
     {
@@ -299,7 +299,7 @@  discard block
 block discarded – undo
299 299
     /**
300 300
      * Get label of the column.
301 301
      *
302
-     * @return mixed
302
+     * @return string
303 303
      */
304 304
     public function getLabel()
305 305
     {
@@ -386,7 +386,7 @@  discard block
 block discarded – undo
386 386
      * Display using display abstract.
387 387
      *
388 388
      * @param string $abstract
389
-     * @param array  $arguments
389
+     * @param Closure[]  $arguments
390 390
      *
391 391
      * @return Column
392 392
      */
Please login to merge, or discard this patch.
src/Grid/Displayers/Image.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
             $this->value = $this->value->toArray();
14 14
         }
15 15
 
16
-        return collect((array) $this->value)->filter()->map(function ($path) use ($server, $width, $height) {
16
+        return collect((array) $this->value)->filter()->map(function($path) use ($server, $width, $height) {
17 17
             if (url()->isValidUrl($path) || strpos($path, 'data:image') === 0) {
18 18
                 $src = $path;
19 19
             } elseif ($server) {
Please login to merge, or discard this patch.
src/Grid/Displayers/Editable.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -184,7 +184,7 @@
 block discarded – undo
184 184
             $attributes = array_merge($attributes, $this->attributes);
185 185
         }
186 186
 
187
-        $attributes = collect($attributes)->map(function ($attribute, $name) {
187
+        $attributes = collect($attributes)->map(function($attribute, $name) {
188 188
             return "$name='$attribute'";
189 189
         })->implode(' ');
190 190
 
Please login to merge, or discard this patch.
src/Console/ExportSeedCommand.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -89,7 +89,7 @@
 block discarded – undo
89 89
         $fields = \DB::getSchemaBuilder()->getColumnListing($table);
90 90
         $fields = array_diff($fields, $exceptFields);
91 91
 
92
-        $array = \DB::table($table)->get($fields)->map(function ($item) {
92
+        $array = \DB::table($table)->get($fields)->map(function($item) {
93 93
             return (array) $item;
94 94
         })->all();
95 95
 
Please login to merge, or discard this patch.