ModelForm - Code Metrics - Inspection of "[refactor]" - z-song/laravel-admin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b0d73a...d2854c )

by Song

created 2018-08-10 03:48 UTC

ModelForm A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	46
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes

Metric	Value
dl	0
loc	46
rs	10
c	0
b	0
f	0
wmc	4
lcom	0
cbo	1

3 Methods

Rating	Name	Size	Complexity
A	update()	4	1
A	destroy()	14	2
A	store()	4	1

<?php

namespace Encore\Admin\Controllers;

trait ModelForm
{
    /**
     * Update the specified resource in storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function update($id)
    {
        return $this->form()->update($id);
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Remove the specified resource from storage.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\Response
     */
    public function destroy($id)
    {
        if ($this->form()->destroy($id)) {
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            return response()->json([
                'status'  => true,
                'message' => trans('admin.delete_succeeded'),
            ]);
        } else {
            return response()->json([
                'status'  => false,
                'message' => trans('admin.delete_failed'),
            ]);
        }
    }

    /**
     * Store a newly created resource in storage.
     *
     * @return \Illuminate\Http\Response
     */
    public function store()
    {
        return $this->form()->store();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace Encore\Admin\Controllers;
4
5			trait ModelForm
6			{
7			/**
8			* Update the specified resource in storage.
9			*
10			* @param int $id
11			*
12			* @return \Illuminate\Http\Response
13			*/
14			public function update($id)
15			{
16			return $this->form()->update($id);
			0 ignored issues – show Bug introduced 2016-08-05 10:29 UTC by Report Bug Copy Issue Report It seems like `form()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
17			}
18
19			/**
20			* Remove the specified resource from storage.
21			*
22			* @param int $id
23			*
24			* @return \Illuminate\Http\Response
25			*/
26			public function destroy($id)
27			{
28			if ($this->form()->destroy($id)) {
			0 ignored issues – show Bug introduced 2016-10-22 16:56 UTC by Report Bug Copy Issue Report It seems like `form()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
29			return response()->json([
30			'status' => true,
31			'message' => trans('admin.delete_succeeded'),
32			]);
33			} else {
34			return response()->json([
35			'status' => false,
36			'message' => trans('admin.delete_failed'),
37			]);
38			}
39			}
40
41			/**
42			* Store a newly created resource in storage.
43			*
44			* @return \Illuminate\Http\Response
45			*/
46			public function store()
47			{
48			return $this->form()->store();
			0 ignored issues – show Bug introduced 2016-08-05 10:29 UTC by Report Bug Copy Issue Report It seems like `form()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
49			}
50			}
51

z-song / laravel-admin

Push — master ( b0d73a...d2854c )

ModelForm A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like