View GitHub Repository framework

Schedule Inspection
Subscribe
Test Failed
Push — master ( 317681...461660 )
by Xu
36:12
created

resources/lib/jquery-treegrid/js/jquery.treegrid.min.js   F

↳ Parent: Project

Complexity

Total Complexity 100
Complexity/F 1.54

Size

Lines of Code 1
Function Count 65

Duplication

Duplicated Lines 0
Ratio 0 %

Importance

Changes 1
Bugs 0 Features 0
Metric Value
cc 0
wmc 100
c 1
b 0
f 0
nc 0
mnd 3
bc 71
fnc 65
dl 0
loc 1
rs 3.12
bpm 1.0923
cpm 1.5384
noi 3

How to fix   Complexity   

Complexity

Complex classes like resources/lib/jquery-treegrid/js/jquery.treegrid.min.js often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

1 
!function(e){var t={initTree:function(t){var r=e.extend({},this.treegrid.defaults,t);return this.each(function(){var t=e(this);t.treegrid("setTreeContainer",e(this)),t.treegrid("setSettings",r),r.getRootNodes.apply(this,[e(this)]).treegrid("initNode",r),t.treegrid("getRootNodes").treegrid("render")})},initNode:function(t){return this.each(function(){var r=e(this);r.treegrid("setTreeContainer",t.getTreeGridContainer.apply(this)),r.treegrid("getChildNodes").treegrid("initNode",t),r.treegrid("initExpander").treegrid("initIndent").treegrid("initEvents").treegrid("initState").treegrid("initChangeEvent").treegrid("initSettingsEvents")})},initChangeEvent:function(){var t=e(this);return t.on("change",function(){var t=e(this);t.treegrid("render"),t.treegrid("getSetting","saveState")&&t.treegrid("saveState")}),t},initEvents:function(){var t=e(this);return t.on("collapse",function(){var t=e(this);t.removeClass("treegrid-expanded"),t.addClass("treegrid-collapsed")}),t.on("expand",function(){var t=e(this);t.removeClass("treegrid-collapsed"),t.addClass("treegrid-expanded")}),t},initSettingsEvents:function(){var t=e(this);return t.on("change",function(){var t=e(this);"function"==typeof t.treegrid("getSetting","onChange")&&t.treegrid("getSetting","onChange").apply(t)}),t.on("collapse",function(){var t=e(this);"function"==typeof t.treegrid("getSetting","onCollapse")&&t.treegrid("getSetting","onCollapse").apply(t)}),t.on("expand",function(){var t=e(this);"function"==typeof t.treegrid("getSetting","onExpand")&&t.treegrid("getSetting","onExpand").apply(t)}),t},initExpander:function(){var t=e(this),r=t.find("td").get(t.treegrid("getSetting","treeColumn")),i=t.treegrid("getSetting","expanderTemplate"),n=t.treegrid("getSetting","getExpander").apply(this);return n&&n.remove(),e(i).prependTo(r).click(function(){e(e(this).closest("tr")).treegrid("toggle")}),t},initIndent:function(){var t=e(this);t.find(".treegrid-indent").remove();for(var r=t.treegrid("getSetting","indentTemplate"),i=t.find(".treegrid-expander"),n=t.treegrid("getDepth"),d=0;n>d;d++)e(r).insertBefore(i);return t},initState:function(){var t=e(this);return t.treegrid(t.treegrid("getSetting","saveState")&&!t.treegrid("isFirstInit")?"restoreState":"expanded"===t.treegrid("getSetting","initialState")?"expand":"collapse"),t},isFirstInit:function(){var t=e(this).treegrid("getTreeContainer");return void 0===t.data("first_init")&&t.data("first_init",void 0===e.cookie(t.treegrid("getSetting","saveStateName"))),t.data("first_init")},saveState:function(){var t=e(this);if("cookie"===t.treegrid("getSetting","saveStateMethod")){var r=e.cookie(t.treegrid("getSetting","saveStateName"))||"",i=""===r?[]:r.split(","),n=t.treegrid("getNodeId");t.treegrid("isExpanded")?-1===e.inArray(n,i)&&i.push(n):t.treegrid("isCollapsed")&&-1!==e.inArray(n,i)&&i.splice(e.inArray(n,i),1),e.cookie(t.treegrid("getSetting","saveStateName"),i.join(","))}return t},restoreState:function(){var t=e(this);if("cookie"===t.treegrid("getSetting","saveStateMethod")){var r=e.cookie(t.treegrid("getSetting","saveStateName")).split(",");t.treegrid(-1!==e.inArray(t.treegrid("getNodeId"),r)?"expand":"collapse")}return t},getSetting:function(t){return e(this).treegrid("getTreeContainer")?e(this).treegrid("getTreeContainer").data("settings")[t]:null},setSettings:function(t){e(this).treegrid("getTreeContainer").data("settings",t)},getTreeContainer:function(){return e(this).data("treegrid")},setTreeContainer:function(t){return e(this).data("treegrid",t)},getRootNodes:function(){return e(this).treegrid("getSetting","getRootNodes").apply(this,[e(this).treegrid("getTreeContainer")])},getAllNodes:function(){return e(this).treegrid("getSetting","getAllNodes").apply(this,[e(this).treegrid("getTreeContainer")])},isNode:function(){return null!==e(this).treegrid("getNodeId")},getNodeId:function(){return null===e(this).treegrid("getSetting","getNodeId")?null:e(this).treegrid("getSetting","getNodeId").apply(this)},getParentNodeId:function(){return e(this).treegrid("getSetting","getParentNodeId").apply(this)},getParentNode:function(){return null===e(this).treegrid("getParentNodeId")?null:e(this).treegrid("getSetting","getNodeById").apply(this,[e(this).treegrid("getParentNodeId"),e(this).treegrid("getTreeContainer")])},getChildNodes:function(){return e(this).treegrid("getSetting","getChildNodes").apply(this,[e(this).treegrid("getNodeId"),e(this).treegrid("getTreeContainer")])},getDepth:function(){return null===e(this).treegrid("getParentNode")?0:e(this).treegrid("getParentNode").treegrid("getDepth")+1},isRoot:function(){return 0===e(this).treegrid("getDepth")},isLeaf:function(){return 0===e(this).treegrid("getChildNodes").length},isLast:function(){if(e(this).treegrid("isNode")){var t=e(this).treegrid("getParentNode");if(null===t){if(e(this).treegrid("getNodeId")===e(this).treegrid("getRootNodes").last().treegrid("getNodeId"))return!0}else if(e(this).treegrid("getNodeId")===t.treegrid("getChildNodes").last().treegrid("getNodeId"))return!0}return!1},isFirst:function(){if(e(this).treegrid("isNode")){var t=e(this).treegrid("getParentNode");if(null===t){if(e(this).treegrid("getNodeId")===e(this).treegrid("getRootNodes").first().treegrid("getNodeId"))return!0}else if(e(this).treegrid("getNodeId")===t.treegrid("getChildNodes").first().treegrid("getNodeId"))return!0}return!1},isExpanded:function(){return e(this).hasClass("treegrid-expanded")},isCollapsed:function(){return e(this).hasClass("treegrid-collapsed")},isOneOfParentsCollapsed:function(){var t=e(this);return!t.treegrid("isRoot")&&(!!t.treegrid("getParentNode").treegrid("isCollapsed")||t.treegrid("getParentNode").treegrid("isOneOfParentsCollapsed"))},expand:function(){return this.treegrid("isLeaf")||this.treegrid("isExpanded")?this:(this.trigger("expand"),this.trigger("change"),this)},expandAll:function(){var t=e(this);return t.treegrid("getRootNodes").treegrid("expandRecursive"),t},expandRecursive:function(){return e(this).each(function(){var t=e(this);t.treegrid("expand"),t.treegrid("isLeaf")||t.treegrid("getChildNodes").treegrid("expandRecursive")})},collapse:function(){return e(this).each(function(){var t=e(this);t.treegrid("isLeaf")||t.treegrid("isCollapsed")||(t.trigger("collapse"),t.trigger("change"))})},collapseAll:function(){var t=e(this);return t.treegrid("getRootNodes").treegrid("collapseRecursive"),t},collapseRecursive:function(){return e(this).each(function(){var t=e(this);t.treegrid("collapse"),t.treegrid("isLeaf")||t.treegrid("getChildNodes").treegrid("collapseRecursive")})},toggle:function(){var t=e(this);return t.treegrid(t.treegrid("isExpanded")?"collapse":"expand"),t},render:function(){return e(this).each(function(){var t=e(this);t.treegrid("isOneOfParentsCollapsed")?t.hide():t.show(),t.treegrid("isLeaf")||(t.treegrid("renderExpander"),t.treegrid("getChildNodes").treegrid("render"))})},renderExpander:function(){return e(this).each(function(){var t=e(this),r=t.treegrid("getSetting","getExpander").apply(this);r?t.treegrid("isCollapsed")?(r.removeClass(t.treegrid("getSetting","expanderExpandedClass")),r.addClass(t.treegrid("getSetting","expanderCollapsedClass"))):(r.removeClass(t.treegrid("getSetting","expanderCollapsedClass")),r.addClass(t.treegrid("getSetting","expanderExpandedClass"))):(t.treegrid("initExpander"),t.treegrid("renderExpander"))})}};e.fn.treegrid=function(r){return t[r]?t[r].apply(this,Array.prototype.slice.call(arguments,1)):"object"!=typeof r&&r?void e.error("Method with name "+r+" does not exists for jQuery.treegrid"):t.initTree.apply(this,arguments)},e.fn.treegrid.defaults={initialState:"expanded",saveState:!1,saveStateMethod:"cookie",saveStateName:"tree-grid-state",expanderTemplate:'<span class="treegrid-expander"></span>',indentTemplate:'<span class="treegrid-indent"></span>',expanderExpandedClass:"treegrid-expander-expanded",expanderCollapsedClass:"treegrid-expander-collapsed",treeColumn:0,getExpander:function(){return e(this).find(".treegrid-expander")},getNodeId:function(){var t=/treegrid-([A-Za-z0-9_-]+)/;return t.test(e(this).attr("class"))?t.exec(e(this).attr("class"))[1]:null},getParentNodeId:function(){var t=/treegrid-parent-([A-Za-z0-9_-]+)/;return t.test(e(this).attr("class"))?t.exec(e(this).attr("class"))[1]:null},getNodeById:function(e,t){var r="treegrid-"+e;return t.find("tr."+r)},getChildNodes:function(e,t){var r="treegrid-parent-"+e;return t.find("tr."+r)},getTreeGridContainer:function(){return e(this).closest("table")},getRootNodes:function(t){var r=e.grep(t.find("tr"),function(t){var r=e(t).attr("class");return/treegrid-([A-Za-z0-9_-]+)/.test(r)&&!/treegrid-parent-([A-Za-z0-9_-]+)/.test(r)});return e(r)},getAllNodes:function(t){var r=e.grep(t.find("tr"),function(t){var r=e(t).attr("class");return/treegrid-([A-Za-z0-9_-]+)/.test(r)});return e(r)},onCollapse:null,onExpand:null,onChange:null}}(jQuery);
3 ignored issues
– show
Coding Style introduced by
Consider using undefined instead of void(0). It is equivalent and more straightforward to read.
Loading history...
Comprehensibility introduced by
Usage of the sequence operator is discouraged, since it may lead to obfuscated code.

The sequence or comma operator allows the inclusion of multiple expressions where only is permitted. The result of the sequence is the value of the last expression.

This operator is most often used in for statements.

Used in another places it can make code hard to read, especially when people do not realize it even exists as a seperate operator.

This check looks for usage of the sequence operator in locations where it is not necessary and could be replaced by a series of expressions or statements.

var a,b,c;

a = 1, b = 1,  c= 3;

could just as well be written as:

var a,b,c;

a = 1;
b = 1;
c = 3;

To learn more about the sequence operator, please refer to the MDN.

Loading history...
Coding Style Best Practice introduced by
Curly braces around statements make for more readable code and help prevent bugs when you add further statements.

Consider adding curly braces around all statements when they are executed conditionally. This is optional if there is only one statement, but leaving them out can lead to unexpected behaviour if another statement is added later.

Consider:

if (a > 0)
    b = 42;

If you or someone else later decides to put another statement in, only the first statement will be executed.

if (a > 0)
    console.log("a > 0");
    b = 42;

In this case the statement b = 42 will always be executed, while the logging statement will be executed conditionally.

if (a > 0) {
    console.log("a > 0");
    b = 42;
}

ensures that the proper code will be executed conditionally no matter how many statements are added or removed.

Loading history...
2 
//# sourceMappingURL=jquery.treegrid.min.js.map
3