| Conditions | 12 |
| Paths | 12 |
| Total Lines | 38 |
| Code Lines | 36 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 104 | private function getCheckCode18($iSum) { |
||
| 105 | $sCode = ""; |
||
| 106 | switch ($iSum % 11) { |
||
| 107 | case 10 : |
||
| 108 | $sCode = "2"; |
||
| 109 | break; |
||
| 110 | case 9 : |
||
| 111 | $sCode = "3"; |
||
| 112 | break; |
||
| 113 | case 8 : |
||
| 114 | $sCode = "4"; |
||
| 115 | break; |
||
| 116 | case 7 : |
||
| 117 | $sCode = "5"; |
||
| 118 | break; |
||
| 119 | case 6 : |
||
| 120 | $sCode = "6"; |
||
| 121 | break; |
||
| 122 | case 5 : |
||
| 123 | $sCode = "7"; |
||
| 124 | break; |
||
| 125 | case 4 : |
||
| 126 | $sCode = "8"; |
||
| 127 | break; |
||
| 128 | case 3 : |
||
| 129 | $sCode = "9"; |
||
| 130 | break; |
||
| 131 | case 2 : |
||
| 132 | $sCode = "x"; |
||
| 133 | break; |
||
| 134 | case 1 : |
||
| 135 | $sCode = "0"; |
||
| 136 | break; |
||
| 137 | case 0 : |
||
| 138 | $sCode = "1"; |
||
| 139 | break; |
||
| 140 | } |
||
| 141 | return $sCode; |
||
| 142 | } |
||
| 165 | } |