$(ꞌ.btn-assignꞌ).click - Code Metrics - Inspection of "update" - yuncms/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 25de10...4cb17c )

by Xu

created 2018-03-24 12:19 UTC

$(ꞌ.btn-assignꞌ).click A

↳ Parent: src/admin/views/assignment/_script.js

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	15
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
c	1
b	0
f	0
nc	2
dl	15
loc	15
rs	9.4285
nop	0

2 Functions

Rating	Name	Duplication	Size	Complexity
A	ick	3	3	1
A	ick	3	3	1

$('i.glyphicon-refresh-animate').hide();
function updateItems(r) {
    _opts.items.avaliable = r.avaliable;

    _opts.items.assigned = r.assigned;
    search('avaliable');
    search('assigned');
}

$('.btn-assign').click(function () {
    var $this = $(this);
    var target = $this.data('target');
    var items = $('select.list[data-target="' + target + '"]').val();

    if (items.length) {
        $this.children('i.glyphicon-refresh-animate').show();
        $.post($this.attr('href'), {items: items}, function (r) {
            updateItems(r);
        }).always(function () {
            $this.children('i.glyphicon-refresh-animate').hide();
        });
    }
    return false;
});

$('.search[data-target]').keyup(function () {
    search($(this).data('target'));
});

function search(target) {
    var $list = $('select.list[data-target="' + target + '"]');
    $list.html('');
    var q = $('.search[data-target="' + target + '"]').val();

    var groups = {
        role: [$('<optgroup label="Roles">'), false],
        permission: [$('<optgroup label="Permission">'), false],
    };
    $.each(_opts.items[target], function (name, group) {

        if (name.indexOf(q) >= 0) {
            $('<option>').text(name).val(name).appendTo(groups[group][0]);
            groups[group][1] = true;
        }
    });
    $.each(groups, function () {
        if (this[1]) {
            $list.append(this[0]);
        }
    });
}

// initial
search('avaliable');
search('assigned');


1	View Code Duplication	$('i.glyphicon-refresh-animate').hide();
2		function updateItems(r) {
3		_opts.items.avaliable = r.avaliable;
		0 ignored issues – show Bug introduced 2018-03-24 19:09 UTC by Report Bug Copy Issue Report The variable `_opts` seems to be never declared. If this is a global, consider adding a `/** global: _opts */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
4		_opts.items.assigned = r.assigned;
5		search('avaliable');
6		search('assigned');
7		}
8
9		$('.btn-assign').click(function () {
10		var $this = $(this);
11		var target = $this.data('target');
12		var items = $('select.list[data-target="' + target + '"]').val();
13
14		if (items.length) {
15		$this.children('i.glyphicon-refresh-animate').show();
16		$.post($this.attr('href'), {items: items}, function (r) {
17		updateItems(r);
18		}).always(function () {
19		$this.children('i.glyphicon-refresh-animate').hide();
20		});
21		}
22		return false;
23		});
24
25		$('.search[data-target]').keyup(function () {
26		search($(this).data('target'));
27		});
28
29		function search(target) {
30		var $list = $('select.list[data-target="' + target + '"]');
31		$list.html('');
32		var q = $('.search[data-target="' + target + '"]').val();
33
34		var groups = {
35		role: [$('<optgroup label="Roles">'), false],
36		permission: [$('<optgroup label="Permission">'), false],
37		};
38		$.each(_opts.items[target], function (name, group) {
		0 ignored issues – show Bug introduced 2018-03-24 19:09 UTC by Report Bug Copy Issue Report The variable `_opts` seems to be never declared. If this is a global, consider adding a `/** global: _opts */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
39		if (name.indexOf(q) >= 0) {
40		$('<option>').text(name).val(name).appendTo(groups[group][0]);
41		groups[group][1] = true;
42		}
43		});
44		$.each(groups, function () {
45		if (this[1]) {
46		$list.append(this[0]);
47		}
48		});
49		}
50
51		// initial
52		search('avaliable');
53		search('assigned');
54

yuncms / framework

Push — master ( 25de10...4cb17c )

$(ꞌ.btn-assignꞌ).click A

Complexity

Size

Duplication

Importance

2 Functions

Duplication Side-by-Side

Filter issues like