resources/lib/metismenu/metisMenu.js - Code Metrics - Inspection of "update" - yuncms/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 59ad2d...412337 )

by Xu

created 2018-03-26 04:29 UTC

resources/lib/metismenu/metisMenu.js B

↳ Parent: Project

Complexity

Total Complexity	40
Complexity/F	2.35

Size

Lines of Code	258
Function Count	17

Duplication

Duplicated Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	0
c	1
b	0
f	0
nc	48
dl	0
loc	258
rs	8.2608
wmc	40
mnd	2
bc	36
fnc	17
bpm	2.1176
cpm	2.3529
noi	4

10 Functions

Rating	Name	Size	Complexity
B	MetisMenu.hide	36	4
B	MetisMenu.show	38	5
A	$.event.special.mmTransitionEnd.handle	8	2
A	$.fn.metisMenu.noConflict	4	1
A	$.fn.emulateTransitionEnd	14	1
A	MetisMenu.doubleTapToGo	18	3
A	metisMenu.js ➔ Plugin	18	1
A	metisMenu.js ➔ MetisMenu	7	1
A	metisMenu.js ➔ transitionEnd	19	3
A	MetisMenu.init	59	2

How to fix Complexity

/*
 * metismenu - v2.0.3
 * A jQuery menu plugin
 * https://github.com/onokumus/metisMenu
 *
 * Made by Osman Nuri Okumus
 * Under MIT License
 */

(function($) {
  'use strict';

  function transitionEnd() {
    var el = document.createElement('mm');

    var transEndEventNames = {
      WebkitTransition: 'webkitTransitionEnd',
      MozTransition: 'transitionend',
      OTransition: 'oTransitionEnd otransitionend',
      transition: 'transitionend'
    };

    for (var name in transEndEventNames) {
      if (el.style[name] !== undefined) {
        return {
          end: transEndEventNames[name]
        };
      }
    }
    return false;
  }

  $.fn.emulateTransitionEnd = function(duration) {
    var called = false;
    var $el = this;
    $(this).one('mmTransitionEnd', function() {
      called = true;
    });
    var callback = function() {
      if (!called) {
        $($el).trigger($transition.end);
      }
    };
    setTimeout(callback, duration);
    return this;
  };

  var $transition = transitionEnd();
  if (!!$transition) {
    $.event.special.mmTransitionEnd = {
      bindType: $transition.end,
      delegateType: $transition.end,
      handle: function(e) {
        if ($(e.target).is(this)) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
          return e.
          handleObj.
          handler.
          apply(this, arguments);
        }
      }
    };
  }

  var MetisMenu = function(element, options) {
    this.$element = $(element);
    this.options = $.extend({}, MetisMenu.DEFAULTS, options);
    this.transitioning = null;

    this.init();
  };

  MetisMenu.TRANSITION_DURATION = 350;

  MetisMenu.DEFAULTS = {
    toggle: true,
    doubleTapToGo: false,
    activeClass: 'active',
    collapseClass: 'collapse',
    collapseInClass: 'in',
    collapsingClass: 'collapsing'
  };

  MetisMenu.prototype.init = function() {
    var $this = this;
    var activeClass = this.options.activeClass;
    var collapseClass = this.options.collapseClass;
    var collapseInClass = this.options.collapseInClass;

    this
      .$element
      .find('li.' + activeClass)
      .has('ul')
      .children('ul')
      .addClass(collapseClass + ' ' + collapseInClass);

    this
      .$element
      .find('li')
      .not('.' + activeClass)
      .has('ul')
      .children('ul')
      .addClass(collapseClass);

    //add the 'doubleTapToGo' class to active items if needed
    if (this.options.doubleTapToGo) {
      this
        .$element
        .find('li.' + activeClass)
        .has('ul')
        .children('a')
        .addClass('doubleTapToGo');
    }

    this
      .$element
      .find('li')
      .has('ul')
      .children('a')
      .on('click.metisMenu', function(e) {
        var self = $(this);
        var $parent = self.parent('li');
        var $list = $parent.children('ul');
        e.preventDefault();

        if ($parent.hasClass(activeClass) && !$this.options.doubleTapToGo) {
          $this.hide($list);
        } else {
          $this.show($list);
        }

        //Do we need to enable the double tap
        if ($this.options.doubleTapToGo) {
          //if we hit a second time on the link and the href is valid, navigate to that url
          if ($this.doubleTapToGo(self) && self.attr('href') !== '#' && self.attr('href') !== '') {
            e.stopPropagation();
            document.location = self.attr('href');
            return;

          }
        }
      });
  };

  MetisMenu.prototype.doubleTapToGo = function(elem) {
    var $this = this.$element;
    //if the class 'doubleTapToGo' exists, remove it and return
    if (elem.hasClass('doubleTapToGo')) {
      elem.removeClass('doubleTapToGo');
      return true;
    }
    //does not exists, add a new class and return false
    if (elem.parent().children('ul').length) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
      //first remove all other class
      $this
        .find('.doubleTapToGo')
        .removeClass('doubleTapToGo');
      //add the class on the current element
      elem.addClass('doubleTapToGo');
      return false;
    }
  };

  MetisMenu.prototype.show = function(el) {
    var activeClass = this.options.activeClass;
    var collapseClass = this.options.collapseClass;
    var collapseInClass = this.options.collapseInClass;
    var collapsingClass = this.options.collapsingClass;
    var $this = $(el);
    var $parent = $this.parent('li');
    if (this.transitioning || $this.hasClass(collapseInClass)) {
      return;
    }

    $parent.addClass(activeClass);

    if (this.options.toggle) {
      this.hide($parent.siblings().children('ul.' + collapseInClass));
    }

    $this
      .removeClass(collapseClass)
      .addClass(collapsingClass)
      .height(0);

    this.transitioning = 1;
    var complete = function() {
      $this
        .removeClass(collapsingClass)
        .addClass(collapseClass + ' ' + collapseInClass)
        .height('');
      this.transitioning = 0;
    };
    if (!$transition) {
      return complete.call(this);
    }
    $this
      .one('mmTransitionEnd', $.proxy(complete, this))
      .emulateTransitionEnd(MetisMenu.TRANSITION_DURATION)
      .height($this[0].scrollHeight);
  };

  MetisMenu.prototype.hide = function(el) {
    var activeClass = this.options.activeClass;
    var collapseClass = this.options.collapseClass;
    var collapseInClass = this.options.collapseInClass;
    var collapsingClass = this.options.collapsingClass;
    var $this = $(el);

    if (this.transitioning || !$this.hasClass(collapseInClass)) {
      return;
    }

    $this.parent('li').removeClass(activeClass);
    $this.height($this.height())[0].offsetHeight;


    $this
      .addClass(collapsingClass)
      .removeClass(collapseClass)
      .removeClass(collapseInClass);

    this.transitioning = 1;

    var complete = function() {
      this.transitioning = 0;
      $this
        .removeClass(collapsingClass)
        .addClass(collapseClass);
    };

    if (!$transition) {
      return complete.call(this);
    }
    $this
      .height(0)
      .one('mmTransitionEnd', $.proxy(complete, this))
      .emulateTransitionEnd(MetisMenu.TRANSITION_DURATION);
  };

  function Plugin(option) {
    return this.each(function() {
      var $this = $(this);
      var data = $this.data('mm');
      var options = $.extend({},
        MetisMenu.DEFAULTS,
        $this.data(),
        typeof option === 'object' && option
      );

      if (!data) {
        $this.data('mm', (data = new MetisMenu(this, options)));
      }
      if (typeof option === 'string') {
        data[option]();
      }
    });
  }

  var old = $.fn.metisMenu;

  $.fn.metisMenu = Plugin;
  $.fn.metisMenu.Constructor = MetisMenu;

  $.fn.metisMenu.noConflict = function() {
    $.fn.metisMenu = old;
    return this;
  };

})(jQuery);


1			/*
2			* metismenu - v2.0.3
3			* A jQuery menu plugin
4			* https://github.com/onokumus/metisMenu
5			*
6			* Made by Osman Nuri Okumus
7			* Under MIT License
8			*/
9
10			(function($) {
11			'use strict';
12
13			function transitionEnd() {
14			var el = document.createElement('mm');
15
16			var transEndEventNames = {
17			WebkitTransition: 'webkitTransitionEnd',
18			MozTransition: 'transitionend',
19			OTransition: 'oTransitionEnd otransitionend',
20			transition: 'transitionend'
21			};
22
23			for (var name in transEndEventNames) {
24			if (el.style[name] !== undefined) {
25			return {
26			end: transEndEventNames[name]
27			};
28			}
29			}
30			return false;
31			}
32
33			$.fn.emulateTransitionEnd = function(duration) {
34			var called = false;
35			var $el = this;
36			$(this).one('mmTransitionEnd', function() {
37			called = true;
38			});
39			var callback = function() {
40			if (!called) {
41			$($el).trigger($transition.end);
42			}
43			};
44			setTimeout(callback, duration);
45			return this;
46			};
47
48			var $transition = transitionEnd();
49			if (!!$transition) {
50			$.event.special.mmTransitionEnd = {
51			bindType: $transition.end,
52			delegateType: $transition.end,
53			handle: function(e) {
54			if ($(e.target).is(this)) {
			0 ignored issues – show Complexity Best Practice introduced 2018-03-26 09:22 UTC by Report Bug Copy Issue Report There is no return statement if `$(e.target).is(this)` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
55			return e.
56			handleObj.
57			handler.
58			apply(this, arguments);
59			}
60			}
61			};
62			}
63
64			var MetisMenu = function(element, options) {
65			this.$element = $(element);
66			this.options = $.extend({}, MetisMenu.DEFAULTS, options);
67			this.transitioning = null;
68
69			this.init();
70			};
71
72			MetisMenu.TRANSITION_DURATION = 350;
73
74			MetisMenu.DEFAULTS = {
75			toggle: true,
76			doubleTapToGo: false,
77			activeClass: 'active',
78			collapseClass: 'collapse',
79			collapseInClass: 'in',
80			collapsingClass: 'collapsing'
81			};
82
83			MetisMenu.prototype.init = function() {
84			var $this = this;
85			var activeClass = this.options.activeClass;
86			var collapseClass = this.options.collapseClass;
87			var collapseInClass = this.options.collapseInClass;
88
89			this
90			.$element
91			.find('li.' + activeClass)
92			.has('ul')
93			.children('ul')
94			.addClass(collapseClass + ' ' + collapseInClass);
95
96			this
97			.$element
98			.find('li')
99			.not('.' + activeClass)
100			.has('ul')
101			.children('ul')
102			.addClass(collapseClass);
103
104			//add the 'doubleTapToGo' class to active items if needed
105			if (this.options.doubleTapToGo) {
106			this
107			.$element
108			.find('li.' + activeClass)
109			.has('ul')
110			.children('a')
111			.addClass('doubleTapToGo');
112			}
113
114			this
115			.$element
116			.find('li')
117			.has('ul')
118			.children('a')
119			.on('click.metisMenu', function(e) {
120			var self = $(this);
121			var $parent = self.parent('li');
122			var $list = $parent.children('ul');
123			e.preventDefault();
124
125			if ($parent.hasClass(activeClass) && !$this.options.doubleTapToGo) {
126			$this.hide($list);
127			} else {
128			$this.show($list);
129			}
130
131			//Do we need to enable the double tap
132			if ($this.options.doubleTapToGo) {
133			//if we hit a second time on the link and the href is valid, navigate to that url
134			if ($this.doubleTapToGo(self) && self.attr('href') !== '#' && self.attr('href') !== '') {
135			e.stopPropagation();
136			document.location = self.attr('href');
137			return;
			0 ignored issues – show Unused Code introduced 2018-03-26 09:22 UTC by Report Bug Copy Issue Report This return has no effect and can be removed. Loading history...
138			}
139			}
140			});
141			};
142
143			MetisMenu.prototype.doubleTapToGo = function(elem) {
144			var $this = this.$element;
145			//if the class 'doubleTapToGo' exists, remove it and return
146			if (elem.hasClass('doubleTapToGo')) {
147			elem.removeClass('doubleTapToGo');
148			return true;
149			}
150			//does not exists, add a new class and return false
151			if (elem.parent().children('ul').length) {
			0 ignored issues – show Complexity Best Practice introduced 2018-03-26 09:22 UTC by Report Bug Copy Issue Report There is no return statement if `elem.parent().children("ul").length` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
152			//first remove all other class
153			$this
154			.find('.doubleTapToGo')
155			.removeClass('doubleTapToGo');
156			//add the class on the current element
157			elem.addClass('doubleTapToGo');
158			return false;
159			}
160			};
161
162			MetisMenu.prototype.show = function(el) {
163			var activeClass = this.options.activeClass;
164			var collapseClass = this.options.collapseClass;
165			var collapseInClass = this.options.collapseInClass;
166			var collapsingClass = this.options.collapsingClass;
167			var $this = $(el);
168			var $parent = $this.parent('li');
169			if (this.transitioning \|\| $this.hasClass(collapseInClass)) {
170			return;
171			}
172
173			$parent.addClass(activeClass);
174
175			if (this.options.toggle) {
176			this.hide($parent.siblings().children('ul.' + collapseInClass));
177			}
178
179			$this
180			.removeClass(collapseClass)
181			.addClass(collapsingClass)
182			.height(0);
183
184			this.transitioning = 1;
185			var complete = function() {
186			$this
187			.removeClass(collapsingClass)
188			.addClass(collapseClass + ' ' + collapseInClass)
189			.height('');
190			this.transitioning = 0;
191			};
192			if (!$transition) {
193			return complete.call(this);
194			}
195			$this
196			.one('mmTransitionEnd', $.proxy(complete, this))
197			.emulateTransitionEnd(MetisMenu.TRANSITION_DURATION)
198			.height($this[0].scrollHeight);
199			};
200
201			MetisMenu.prototype.hide = function(el) {
202			var activeClass = this.options.activeClass;
203			var collapseClass = this.options.collapseClass;
204			var collapseInClass = this.options.collapseInClass;
205			var collapsingClass = this.options.collapsingClass;
206			var $this = $(el);
207
208			if (this.transitioning \|\| !$this.hasClass(collapseInClass)) {
209			return;
210			}
211
212			$this.parent('li').removeClass(activeClass);
213			$this.height($this.height())[0].offsetHeight;
			0 ignored issues – show introduced 2018-03-26 09:22 UTC by Report Bug Copy Issue Report The result of the property access to `$this.height($this.height()).0.offsetHeight` is not used. Loading history...
214
215			$this
216			.addClass(collapsingClass)
217			.removeClass(collapseClass)
218			.removeClass(collapseInClass);
219
220			this.transitioning = 1;
221
222			var complete = function() {
223			this.transitioning = 0;
224			$this
225			.removeClass(collapsingClass)
226			.addClass(collapseClass);
227			};
228
229			if (!$transition) {
230			return complete.call(this);
231			}
232			$this
233			.height(0)
234			.one('mmTransitionEnd', $.proxy(complete, this))
235			.emulateTransitionEnd(MetisMenu.TRANSITION_DURATION);
236			};
237
238			function Plugin(option) {
239			return this.each(function() {
240			var $this = $(this);
241			var data = $this.data('mm');
242			var options = $.extend({},
243			MetisMenu.DEFAULTS,
244			$this.data(),
245			typeof option === 'object' && option
246			);
247
248			if (!data) {
249			$this.data('mm', (data = new MetisMenu(this, options)));
250			}
251			if (typeof option === 'string') {
252			data[option]();
253			}
254			});
255			}
256
257			var old = $.fn.metisMenu;
258
259			$.fn.metisMenu = Plugin;
260			$.fn.metisMenu.Constructor = MetisMenu;
261
262			$.fn.metisMenu.noConflict = function() {
263			$.fn.metisMenu = old;
264			return this;
265			};
266
267			})(jQuery);
268

yuncms / framework

Push — master ( 59ad2d...412337 )

resources/lib/metismenu/metisMenu.js B

Complexity

Size

Duplication

Importance

10 Functions

How to fix Complexity

Complexity

Duplication Side-by-Side

Filter issues like