Ytake\LaravelAspect\Interceptor\AbstractLogger

Complexity

Total Complexity

2

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	1

1 Method

Rating	Name	Duplication	Size	Complexity
A	logFormatter()	0	19	2

<?php

/**
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
 * THE SOFTWARE.
 *
 * This software consists of voluntary contributions made by many individuals
 * and is licensed under the MIT license.
 *
 * Copyright (c) 2015-2016 Yuuki Takezawa
 *
 */
namespace Ytake\LaravelAspect\Interceptor;

use Ray\Aop\MethodInvocation;
use Ytake\LaravelAspect\Annotation\LoggableAnnotate;

/**
 * Class AbstractLogger
 */
class AbstractLogger
{
    /** @var string */
    protected $format = "%s:%s.%s";

    /**
     * @param LoggableAnnotate $annotation
     * @param MethodInvocation $invocation
     *
     * @return string[]
     */
    protected function logFormatter(LoggableAnnotate $annotation, MethodInvocation $invocation)
    {
        $context = [];
        $arguments = $invocation->getArguments();
        foreach ($invocation->getMethod()->getParameters() as $parameter) {
            $context['args'][$parameter->name] = $arguments[$parameter->getPosition()];
        }

        return [
            'level' => $annotation->value,

Accessing value on the interface Ytake\LaravelAspect\Annotation\LoggableAnnotate suggest that you code against a concrete implementation. How about adding an instanceof check?

            'message' => sprintf(
                $this->format,
                $annotation->name,

Accessing name on the interface Ytake\LaravelAspect\Annotation\LoggableAnnotate suggest that you code against a concrete implementation. How about adding an instanceof check?

                $invocation->getMethod()->class,
                $invocation->getMethod()->name
            ),
            'context' => $context,
        ];
    }
}