TokenManager::get() - Code Metrics - Inspection of "Added a 'usages' configuration to tokens (#13)" - yokai-php/security-token-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0563c6...cb42e4 )

by Yann

created 2017-04-08 08:54 UTC

TokenManager::get() A

↳ Parent: TokenManager

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	2
crap	1

<?php

namespace Yokai\SecurityTokenBundle\Manager;

use DateTime;
use Yokai\SecurityTokenBundle\Entity\Token;
use Yokai\SecurityTokenBundle\Factory\TokenFactoryInterface;
use Yokai\SecurityTokenBundle\InformationGuesser\InformationGuesserInterface;
use Yokai\SecurityTokenBundle\Repository\TokenRepositoryInterface;

/**
 * @author Yann Eugoné <[email protected]>
 */
class TokenManager implements TokenManagerInterface
{
    /**
     * @var TokenFactoryInterface
     */
    private $factory;

    /**
     * @var TokenRepositoryInterface
     */
    private $repository;

    /**
     * @var InformationGuesserInterface
     */
    private $informationGuesser;

    /**
     * @var UserManagerInterface
     */
    private $userManager;

    /**
     * @param TokenFactoryInterface       $factory
     * @param TokenRepositoryInterface    $repository
     * @param InformationGuesserInterface $informationGuesser
     * @param UserManagerInterface        $userManager
     */
    public function __construct(
        TokenFactoryInterface $factory,
        TokenRepositoryInterface $repository,
        InformationGuesserInterface $informationGuesser,
        UserManagerInterface $userManager
    ) {
        $this->factory = $factory;
        $this->repository = $repository;
        $this->informationGuesser = $informationGuesser;
        $this->userManager = $userManager;
    }

    /**
     * @inheritdoc
     */
    public function get($purpose, $value)
    {
        return $this->repository->get($value, $purpose);
    }

    /**
     * @inheritdoc
     */
    public function create($purpose, $user, array $payload = [])
    {
        do {
            $token = $this->factory->create($user, $purpose, $payload);
        } while ($this->repository->exists($token->getValue(), $purpose));

        $this->repository->create($token);

        return $token;
    }

    /**
     * @inheritdoc
     */
    public function setUsed(Token $token, DateTime $at = null)
    {
        @trigger_error(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            'The '.__METHOD__
            .' method is deprecated since version 2.2 and will be removed in 3.0. Use the consume() method instead.',
            E_USER_DEPRECATED
        );

        $this->consume($token, $at);
    }

    /**
     * @inheritDoc
     */
    public function consume(Token $token, DateTime $at = null)
    {
        $token->consume($this->informationGuesser->get(), $at);

        $this->repository->update($token);
    }

    /**
     * @inheritdoc
     */
    public function getUser(Token $token)
    {
        return $this->userManager->get($token->getUserClass(), $token->getUserId());
    }
}


1		<?php
2
3		namespace Yokai\SecurityTokenBundle\Manager;
4
5		use DateTime;
6		use Yokai\SecurityTokenBundle\Entity\Token;
7		use Yokai\SecurityTokenBundle\Factory\TokenFactoryInterface;
8		use Yokai\SecurityTokenBundle\InformationGuesser\InformationGuesserInterface;
9		use Yokai\SecurityTokenBundle\Repository\TokenRepositoryInterface;
10
11		/**
12		* @author Yann Eugoné <[email protected]>
13		*/
14		class TokenManager implements TokenManagerInterface
15		{
16		/**
17		* @var TokenFactoryInterface
18		*/
19		private $factory;
20
21		/**
22		* @var TokenRepositoryInterface
23		*/
24		private $repository;
25
26		/**
27		* @var InformationGuesserInterface
28		*/
29		private $informationGuesser;
30
31		/**
32		* @var UserManagerInterface
33		*/
34		private $userManager;
35
36		/**
37		* @param TokenFactoryInterface $factory
38		* @param TokenRepositoryInterface $repository
39		* @param InformationGuesserInterface $informationGuesser
40		* @param UserManagerInterface $userManager
41		*/
42	4	public function __construct(
43		TokenFactoryInterface $factory,
44		TokenRepositoryInterface $repository,
45		InformationGuesserInterface $informationGuesser,
46		UserManagerInterface $userManager
47		) {
48	4	$this->factory = $factory;
49	4	$this->repository = $repository;
50	4	$this->informationGuesser = $informationGuesser;
51	4	$this->userManager = $userManager;
52	4	}
53
54		/**
55		* @inheritdoc
56		*/
57	1	public function get($purpose, $value)
58		{
59	1	return $this->repository->get($value, $purpose);
60		}
61
62		/**
63		* @inheritdoc
64		*/
65	1	public function create($purpose, $user, array $payload = [])
66		{
67		do {
68	1	$token = $this->factory->create($user, $purpose, $payload);
69	1	} while ($this->repository->exists($token->getValue(), $purpose));
70
71	1	$this->repository->create($token);
72
73	1	return $token;
74		}
75
76		/**
77		* @inheritdoc
78		*/
79	1	public function setUsed(Token $token, DateTime $at = null)
80		{
81	1	@trigger_error(
		0 ignored issues – show Security Best Practice introduced 2017-04-08 08:03 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
82		'The '.__METHOD__
83	1	.' method is deprecated since version 2.2 and will be removed in 3.0. Use the consume() method instead.',
84	1	E_USER_DEPRECATED
85		);
86
87	1	$this->consume($token, $at);
88	1	}
89
90		/**
91		* @inheritDoc
92		*/
93	1	public function consume(Token $token, DateTime $at = null)
94		{
95	1	$token->consume($this->informationGuesser->get(), $at);
96
97	1	$this->repository->update($token);
98	1	}
99
100		/**
101		* @inheritdoc
102		*/
103	1	public function getUser(Token $token)
104		{
105	1	return $this->userManager->get($token->getUserClass(), $token->getUserId());
106		}
107		}
108

yokai-php / security-token-bundle

Push — master ( 0563c6...cb42e4 )

TokenManager::get() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like