ArchiveTokenCommand::execute() - Code Metrics - Inspection of "Updated composer branch alias" - yokai-php/security-token-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#25)

by Yann

created 2018-02-13 15:05 UTC

ArchiveTokenCommand::execute() A

↳ Parent: ArchiveTokenCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	20
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	20
ccs	0
cts	15
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	10
nc	2
nop	2
crap	6

<?php

namespace Yokai\SecurityTokenBundle\Command;

use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Yokai\SecurityTokenBundle\Archive\ArchivistInterface;

/**
 * @author Yann Eugoné <[email protected]>
 */
class ArchiveTokenCommand extends ContainerAwareCommand
{
    /**
     * @inheritDoc
     */
    protected function configure()
    {
        $this
            ->setName('yokai:security-token:archive')
            ->addOption('purpose', null, InputOption::VALUE_OPTIONAL, 'Filter tokens to archive on purpose.')
            ->addOption('before',  null, InputOption::VALUE_OPTIONAL, '[deprecated] Filter tokens to archive on created date.')

        ;
    }

    /**
     * @inheritDoc
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $purpose = $input->getOption('purpose');

        if ($input->getOption('before')) {
            @trigger_error(
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
                'The "before" option is deprecated since version 2.2 and will be removed in 3.0.',
                E_USER_DEPRECATED
            );
        }

        /** @var $archivist ArchivistInterface */
        $archivist = $this->getContainer()->get('yokai_security_token.archivist');

        $count = $archivist->archive($purpose);

        $output->writeln(
            sprintf('<info>Successfully archived <comment>%d</comment> security token(s).</info>', $count)
        );
    }
}


1			<?php
2
3			namespace Yokai\SecurityTokenBundle\Command;
4
5			use Symfony\Bundle\FrameworkBundle\Command\ContainerAwareCommand;
6			use Symfony\Component\Console\Input\InputInterface;
7			use Symfony\Component\Console\Input\InputOption;
8			use Symfony\Component\Console\Output\OutputInterface;
9			use Yokai\SecurityTokenBundle\Archive\ArchivistInterface;
10
11			/**
12			* @author Yann Eugoné <[email protected]>
13			*/
14			class ArchiveTokenCommand extends ContainerAwareCommand
15			{
16			/**
17			* @inheritDoc
18			*/
19			protected function configure()
20			{
21			$this
22			->setName('yokai:security-token:archive')
23			->addOption('purpose', null, InputOption::VALUE_OPTIONAL, 'Filter tokens to archive on purpose.')
24			->addOption('before', null, InputOption::VALUE_OPTIONAL, '[deprecated] Filter tokens to archive on created date.')
			0 ignored issues – show Coding Style introduced 2017-04-09 09:07 UTC by Report Bug Copy Issue Report Expected 1 space instead of 2 after comma in function call. Loading history...
25			;
26			}
27
28			/**
29			* @inheritDoc
30			*/
31			protected function execute(InputInterface $input, OutputInterface $output)
32			{
33			$purpose = $input->getOption('purpose');
34
35			if ($input->getOption('before')) {
36			@trigger_error(
			0 ignored issues – show Security Best Practice introduced 2017-04-08 08:36 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
37			'The "before" option is deprecated since version 2.2 and will be removed in 3.0.',
38			E_USER_DEPRECATED
39			);
40			}
41
42			/** @var $archivist ArchivistInterface */
43			$archivist = $this->getContainer()->get('yokai_security_token.archivist');
44
45			$count = $archivist->archive($purpose);
46
47			$output->writeln(
48			sprintf('<info>Successfully archived <comment>%d</comment> security token(s).</info>', $count)
49			);
50			}
51			}
52

yokai-php / security-token-bundle

Pull Request — master (#25)

ArchiveTokenCommand::execute() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like